Jump to content

Recommended Posts

Posted (edited)

I have no idea how to make it work, I tried playing with the codes for a couples of hours now. Here is my codes: 

package com.SupremeMarshal.MoreToolsTierMod.util.handlers;

import com.SupremeMarshal.MoreToolsTierMod.init.ModBlocks;
import com.SupremeMarshal.MoreToolsTierMod.init.ModItems;

import net.minecraft.item.ItemStack;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class RecipeHandler
{
	public static void registerSmelting()
	{
		GameRegistry.addSmelting(new ItemStack(ModBlocks.RUNE_ORECOAL_BLOCK ,1 ,0), new ItemStack(ModItems.RUNE_INGOT, 1), 1.0f); 
	}

}

Or is it possible to create a Smelting recipe with JSON file? I hope I get some help!

Also, do I need to do a Register thing for this class?
(I'm still new in coding Java)

Edited by supreme marshal
Posted (edited)
  On 4/12/2018 at 8:37 PM, larsgerrits said:

Are you calling RecipeHandler.registerSmelting?

Expand  

On RegistryHandler? I have but I'm not sure I did it correctly.

 

package com.SupremeMarshal.MoreToolsTierMod.util.handlers;

import com.SupremeMarshal.MoreToolsTierMod.init.ModBlocks;
import com.SupremeMarshal.MoreToolsTierMod.init.ModItems;
import com.SupremeMarshal.MoreToolsTierMod.util.IHasModel;

import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraft.item.crafting.CraftingManager;
import net.minecraft.world.storage.loot.functions.Smelt;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@EventBusSubscriber
public class RegistryHandler 
{
	
	//Calling RecipeHandler.registerSmelting
	public static void Client()
	{
		RecipeHandler.registerSmelting();
	}
	
	
	@SubscribeEvent
	public static void onItemRegister(RegistryEvent.Register<Item> event)
	{
		event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));
	}
	
	
	@SubscribeEvent
	public static void onBlockRegister(RegistryEvent.Register<Block> event)
	{
		event.getRegistry().registerAll(ModBlocks.BLOCKS.toArray(new Block[0]));
	}

I think that is what you mean by calling RecipeHandler.registerSmelting? 

Edited by supreme marshal
Posted

Why are you registering your recipes only on the client?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
  On 4/12/2018 at 9:38 PM, supreme marshal said:

I get some error log when I test the game:

 

[17:35:23] [main/ERROR] [FML]: Parsing error loading recipe ms:rune_ingot_smelting
com.google.gson.JsonSyntaxException: Unknown recipe type: minecraft:smelting

Expand  

Smelting does not use the JSON system

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
  On 4/12/2018 at 9:29 PM, supreme marshal said:

I only play on client version anyways. So can you help me for my problem?

Expand  

Even for single player you need to register it on the server thread.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted (edited)
	public static void Client()
	{
		RecipeHandler.registerSmelting();
	}
	
	public static void Common()
	{
		RecipeHandler.registerSmelting();
	}

Like this? I feel like it should be a bit more complicated than this. Is there something I need to implement in my proxy class? ClientProxy and CommonProxy.

Edited by supreme marshal
Posted

This is my whole RegistryHandler class:

 

package com.SupremeMarshal.MoreToolsTierMod.util.handlers;

import com.SupremeMarshal.MoreToolsTierMod.init.ModBlocks;
import com.SupremeMarshal.MoreToolsTierMod.init.ModItems;
import com.SupremeMarshal.MoreToolsTierMod.util.IHasModel;

import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraft.item.crafting.CraftingManager;
import net.minecraft.world.storage.loot.functions.Smelt;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@EventBusSubscriber
public class RegistryHandler 
{
	
	
	public static void Client()
	{
	RecipeHandler.registerSmelting();
	}
	
	public static void Common()
	{
	RecipeHandler.registerSmelting();
	}

	
	@SubscribeEvent
	public static void onItemRegister(RegistryEvent.Register<Item> event)
	{
		event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));
	}
	
	
	@SubscribeEvent
	public static void onBlockRegister(RegistryEvent.Register<Block> event)
	{
		event.getRegistry().registerAll(ModBlocks.BLOCKS.toArray(new Block[0]));
	}
	

	@SubscribeEvent
	public static void onModelRegister(ModelRegistryEvent event)
	{
		for(Item item : ModItems.ITEMS)	
		{
			if(item instanceof IHasModel)
			{
				((IHasModel)item).registerModels();
			}
		}
		
		for(Block block : ModBlocks.BLOCKS)	
		{
			if(block instanceof IHasModel)
			{
				((IHasModel)block).registerModels();
			}
		}
	}
}

 

Posted

You realize "common" is both sides, right?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

The way I register my smelting recipes is I have this in my RegistryHandler

	public static void initRegistries()
	{
		SmeltingRecipes.init();
	}

for you instead of "SmeltingRecipes.init();" it would be "RecipeHandler.registerSmelting();"

and then in my main mod class I call

RegistryHandler.initRegistries();

in my initialization event

Posted
  On 4/13/2018 at 5:00 PM, Hazmatik said:

The way I register my smelting recipes is I have this in my RegistryHandler

	public static void initRegistries()
	{
		SmeltingRecipes.init();
	}

for you instead of "SmeltingRecipes.init();" it would be "RecipeHandler.registerSmelting();"

and then in my main mod class I call

RegistryHandler.initRegistries();

in my initialization event

Expand  

OMFG THANK YOU IT WORKED!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
    • Crashes the server when trying to start. Error code -1. Log  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.