[1.12.2] Creating smelting recipe [SOLVED]

[supreme marshal]

I have no idea how to make it work, I tried playing with the codes for a couples of hours now. Here is my codes: 

package com.SupremeMarshal.MoreToolsTierMod.util.handlers;

import com.SupremeMarshal.MoreToolsTierMod.init.ModBlocks;
import com.SupremeMarshal.MoreToolsTierMod.init.ModItems;

import net.minecraft.item.ItemStack;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class RecipeHandler
{
	public static void registerSmelting()
	{
		GameRegistry.addSmelting(new ItemStack(ModBlocks.RUNE_ORECOAL_BLOCK ,1 ,0), new ItemStack(ModItems.RUNE_INGOT, 1), 1.0f); 
	}

}

Or is it possible to create a Smelting recipe with JSON file? I hope I get some help!

Also, do I need to do a Register thing for this class?
(I'm still new in coding Java)

Edited April 13, 2018 by supreme marshal

[larsgerrits]

Are you calling RecipeHandler.registerSmelting?

[supreme marshal]

36 minutes ago, larsgerrits said:

Are you calling RecipeHandler.registerSmelting?

On RegistryHandler? I have but I'm not sure I did it correctly.

 

package com.SupremeMarshal.MoreToolsTierMod.util.handlers;

import com.SupremeMarshal.MoreToolsTierMod.init.ModBlocks;
import com.SupremeMarshal.MoreToolsTierMod.init.ModItems;
import com.SupremeMarshal.MoreToolsTierMod.util.IHasModel;

import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraft.item.crafting.CraftingManager;
import net.minecraft.world.storage.loot.functions.Smelt;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@EventBusSubscriber
public class RegistryHandler 
{
	
	//Calling RecipeHandler.registerSmelting
	public static void Client()
	{
		RecipeHandler.registerSmelting();
	}
	
	
	@SubscribeEvent
	public static void onItemRegister(RegistryEvent.Register<Item> event)
	{
		event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));
	}
	
	
	@SubscribeEvent
	public static void onBlockRegister(RegistryEvent.Register<Block> event)
	{
		event.getRegistry().registerAll(ModBlocks.BLOCKS.toArray(new Block[0]));
	}

I think that is what you mean by calling RecipeHandler.registerSmelting? 

Edited April 12, 2018 by supreme marshal

[Draco18s]

Why are you registering your recipes only on the client?

[supreme marshal]

I only play on client version anyways. So can you help me for my problem?

 

Edited April 12, 2018 by supreme marshal

[supreme marshal]

I get some error log when I test the game:

 

[17:35:23] [main/ERROR] [FML]: Parsing error loading recipe ms:rune_ingot_smelting
com.google.gson.JsonSyntaxException: Unknown recipe type: minecraft:smelting

[Draco18s]

9 minutes ago, supreme marshal said:

I get some error log when I test the game:

 

[17:35:23] [main/ERROR] [FML]: Parsing error loading recipe ms:rune_ingot_smelting
com.google.gson.JsonSyntaxException: Unknown recipe type: minecraft:smelting

Smelting does not use the JSON system

[supreme marshal]

Good to know but that doesn't solve my problem. I am trying to solve this problem for over 6 hours now..

[supreme marshal]

I think my problem is on registering the Smelting Recipe, but I have no idea how to do it properly.

[Draco18s]

51 minutes ago, supreme marshal said:

I only play on client version anyways. So can you help me for my problem?

Even for single player you need to register it on the server thread.

[supreme marshal]

	public static void Client()
	{
		RecipeHandler.registerSmelting();
	}
	
	public static void Common()
	{
		RecipeHandler.registerSmelting();
	}

Like this? I feel like it should be a bit more complicated than this. Is there something I need to implement in my proxy class? ClientProxy and CommonProxy.

Edited April 13, 2018 by supreme marshal

[supreme marshal]

This is my whole RegistryHandler class:

 

package com.SupremeMarshal.MoreToolsTierMod.util.handlers;

import com.SupremeMarshal.MoreToolsTierMod.init.ModBlocks;
import com.SupremeMarshal.MoreToolsTierMod.init.ModItems;
import com.SupremeMarshal.MoreToolsTierMod.util.IHasModel;

import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraft.item.crafting.CraftingManager;
import net.minecraft.world.storage.loot.functions.Smelt;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@EventBusSubscriber
public class RegistryHandler 
{
	
	
	public static void Client()
	{
	RecipeHandler.registerSmelting();
	}
	
	public static void Common()
	{
	RecipeHandler.registerSmelting();
	}

	
	@SubscribeEvent
	public static void onItemRegister(RegistryEvent.Register<Item> event)
	{
		event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));
	}
	
	
	@SubscribeEvent
	public static void onBlockRegister(RegistryEvent.Register<Block> event)
	{
		event.getRegistry().registerAll(ModBlocks.BLOCKS.toArray(new Block[0]));
	}
	

	@SubscribeEvent
	public static void onModelRegister(ModelRegistryEvent event)
	{
		for(Item item : ModItems.ITEMS)	
		{
			if(item instanceof IHasModel)
			{
				((IHasModel)item).registerModels();
			}
		}
		
		for(Block block : ModBlocks.BLOCKS)	
		{
			if(block instanceof IHasModel)
			{
				((IHasModel)block).registerModels();
			}
		}
	}
}

 

[Draco18s]

You realize "common" is both sides, right?

[Hazmatik]

The way I register my smelting recipes is I have this in my RegistryHandler

	public static void initRegistries()
	{
		SmeltingRecipes.init();
	}

for you instead of "SmeltingRecipes.init();" it would be "RecipeHandler.registerSmelting();"

and then in my main mod class I call

RegistryHandler.initRegistries();

in my initialization event

[supreme marshal]

17 minutes ago, Draco18s said:

You realize "common" is both sides, right?

Yes that make sens. I tried with "Server" as well but it didn't solve my problem. My block still don't burn in the furnace.

[supreme marshal]

19 minutes ago, Hazmatik said:

The way I register my smelting recipes is I have this in my RegistryHandler

	public static void initRegistries()
	{
		SmeltingRecipes.init();
	}

for you instead of "SmeltingRecipes.init();" it would be "RecipeHandler.registerSmelting();"

and then in my main mod class I call

RegistryHandler.initRegistries();

in my initialization event

OMFG THANK YOU IT WORKED!