Jump to content

[SOLVED] [1.12.2] Player gets stuck in modified collision boxes


Recommended Posts

Posted (edited)

I'm trying to do some fancy stuff to mimic the behavior of the mod Repose, where blocks whose collision box is normally a full cube will act as stairs when you're walking up a slope. This makes it so you don't have to jump so much.

 

My code kinda works, but the player gets stuck inside the block. It's almost like the collision boxes are getting modified only some of the time, then changing back to a full cube and trapping the player. Sometimes I can get out for a second but then I get pulled back into the block. I initially suspected some kind of syncing problem, but it behaves the same when I run it on the server only and when I run it on both sides. It does nothing when run on the client only. Do I need to send some kind of packet to the client? Any idea what's going on?

 

Spoiler

    @SubscribeEvent
    public void onCollision(GetCollisionBoxesEvent event)
    {
        if (event.getEntity() != null && event.getEntity() instanceof EntityPlayer)
        {
            List<AxisAlignedBB> collisionBoxesList = event.getCollisionBoxesList();
            Iterator<AxisAlignedBB> collisionBoxesIterator = collisionBoxesList.iterator();
            List<AxisAlignedBB> stairCollisionBoxes = new ArrayList<>();

            while (collisionBoxesIterator.hasNext())
            {
                World world = event.getWorld();

                AxisAlignedBB currentAABB = collisionBoxesIterator.next();
                // Get center of AxisAlignedBB; note that AxisAlignedBB#getCenter is on client side only so won't work here
                double centerX = currentAABB.minX + (currentAABB.maxX - currentAABB.minX) * 0.5D;
                double centerY = currentAABB.minY + (currentAABB.maxY - currentAABB.minY) * 0.5D;
                double centerZ = currentAABB.minZ + (currentAABB.maxZ - currentAABB.minZ) * 0.5D;
                Vec3d vec = new Vec3d(centerX, centerY, centerZ);
                BlockPos pos = new BlockPos(vec.x, vec.y, vec.z);

                IBlockState state = world.getBlockState(pos);
                Block block = state.getBlock();

                    // BLOCKS ACT AS STAIRS

                    // Required block patterns:
                    // A1 = first air block
                    // A2 = second air block
                    // A3 = third air block
                    // XX = solid block
                    // SS = the block in question, which could be turned into a stair
                    // ?? = could be anything

                    // A2 A1 ??    A2 A1 X1
                    // A3 SS X1    A3 SS ??
                    // X2          X2

                    if (block.isNormalCube(state, world, pos) // SS
                            && world.getBlockState(pos.up()).getCollisionBoundingBox(world, pos.up()) == null) // A1
                    {
                        ArrayList<EnumFacing> STAIR_DIRECTIONS = new ArrayList<>();
                        STAIR_DIRECTIONS.addAll(Arrays.asList(EnumFacing.HORIZONTALS));

                        for (EnumFacing direction : EnumFacing.HORIZONTALS)
                        {
                            if (                               world.getBlockState(pos.offset(direction)).getCollisionBoundingBox(world, pos.offset(direction)) == null // A3
                                    && world.getBlockState(pos.offset(direction).up()).getCollisionBoundingBox(world, pos.offset(direction).up()) == null // A2
                                    && world.isBlockNormalCube(pos.offset(direction).down(), false) // X2
                                    && (world.isBlockNormalCube(pos.offset(direction.getOpposite()), false) // X1 or ??
                                    || world.isBlockNormalCube(pos.offset(direction.getOpposite()).up(), false))) // X1 or ??
                            {
                                // Conditions met - remove this direction from list to show we need to remove a stair piece on that side of the block
                                STAIR_DIRECTIONS.remove(direction);
                            }
                        }

                        // If a direction has been removed, it means we need to remove a stair piece from the block
                        // Note that the conditions should make it so the most you can remove is two directions, and they would have to be diagonal to each other
                        if (!STAIR_DIRECTIONS.containsAll(Arrays.asList(EnumFacing.HORIZONTALS)))
                        {
                            collisionBoxesIterator.remove();
                            stairCollisionBoxes.add(AABB_SLAB_BOTTOM.offset(pos));

                            if (STAIR_DIRECTIONS.contains(EnumFacing.NORTH))
                            {
                                if (STAIR_DIRECTIONS.contains(EnumFacing.EAST))
                                {
                                    stairCollisionBoxes.add(NE_CORNER.offset(pos));
                                }
                                if (STAIR_DIRECTIONS.contains(EnumFacing.WEST))
                                {
                                    stairCollisionBoxes.add(NW_CORNER.offset(pos));
                                }
                            }
                            if (STAIR_DIRECTIONS.contains(EnumFacing.SOUTH))
                            {
                                if (STAIR_DIRECTIONS.contains(EnumFacing.EAST))
                                {
                                    stairCollisionBoxes.add(SE_CORNER.offset(pos));
                                }
                                if (STAIR_DIRECTIONS.contains(EnumFacing.WEST))
                                {
                                    stairCollisionBoxes.add(SW_CORNER.offset(pos));
                                }
                            }
                        }
                    }
            }
            collisionBoxesList.addAll(stairCollisionBoxes);
        }
    }

 

 

Edited by Daeruin
Marking solved.
Posted

Can you explain why you think this would help?

 

I was guessing that maybe EntityPlayerSP#pushOutOfBlocks was trying to push the player out of the block, but then the player was falling back in, and was therefore getting stuck. So I tried cancelling PlayerSPPushOutOfBlocksEvent in the same conditions under which I'm modifying the collision boxes. No effect.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I have no idea what the flip is going on, I can load the modpack just fine at forge 42.2.0 but any forge version above it insta-crashes with exit code 1. Can somebody tell me what's going on, this is minecraft 1.20.1 Latest.log: https://pastebin.com/pBUL1ZFa
    • does anyone know how to incorporate custom noise settings into a custom dimension through the use of datagen, I have created a custon json file for the noise settings that I want but I just don't know how to get it to register with the generated json file of the custom dimension.   here is the code for the dimension class package net.hurst.lustria.worldgen.dimension; import com.mojang.datafixers.util.Pair; import net.hurst.lustria.Lustria; import net.hurst.lustria.worldgen.biome.ModBiomes; import net.hurst.lustria.worldgen.registries.LustriaNoiseSettings; import net.minecraft.core.HolderGetter; import net.minecraft.core.registries.Registries; import net.minecraft.data.worldgen.BootstapContext; import net.minecraft.resources.ResourceKey; import net.minecraft.resources.ResourceLocation; import net.minecraft.tags.BlockTags; import net.minecraft.util.valueproviders.ConstantInt; import net.minecraft.world.level.Level; import net.minecraft.world.level.biome.*; import net.minecraft.world.level.dimension.BuiltinDimensionTypes; import net.minecraft.world.level.dimension.DimensionType; import net.minecraft.world.level.dimension.LevelStem; import net.minecraft.world.level.levelgen.NoiseBasedChunkGenerator; import net.minecraft.world.level.levelgen.NoiseGeneratorSettings; import java.util.List; import java.util.OptionalLong; public class ModDimensions { public static final ResourceKey<LevelStem> LUSTRIA_KEY = ResourceKey.create(Registries.LEVEL_STEM, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim")); public static final ResourceKey<Level> LUSTRIA_LEVEL_KEY = ResourceKey.create(Registries.DIMENSION, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim")); public static final ResourceKey<DimensionType> LUSTRIA_DIM_TYPE = ResourceKey.create(Registries.DIMENSION_TYPE, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim_type")); public static void bootstrapType(BootstapContext<DimensionType> context) { context.register(LUSTRIA_DIM_TYPE, new DimensionType( OptionalLong.of(12000), // fixedTime false, // hasSkylight true, // hasCeiling false, // ultraWarm false, // natural 1.0, // coordinateScale true, // bedWorks false, // respawnAnchorWorks -64, // minY 256, // height 256, // logicalHeight BlockTags.INFINIBURN_OVERWORLD, // infiniburn BuiltinDimensionTypes.OVERWORLD_EFFECTS, // effectsLocation 0.0f, // ambientLight new DimensionType.MonsterSettings(false, false, ConstantInt.of(0), 0))); } public static void bootstrapStem(BootstapContext<LevelStem> context) { HolderGetter<Biome> biomeRegistry = context.lookup(Registries.BIOME); HolderGetter<DimensionType> dimTypes = context.lookup(Registries.DIMENSION_TYPE); HolderGetter<NoiseGeneratorSettings> noiseGenSettings = context.lookup(Registries.NOISE_SETTINGS); NoiseBasedChunkGenerator wrappedChunkGenerator = new NoiseBasedChunkGenerator( new FixedBiomeSource(biomeRegistry.getOrThrow(Biomes.BEACH)), noiseGenSettings.getOrThrow(NoiseGeneratorSettings.CAVES)); NoiseBasedChunkGenerator noiseBasedChunkGenerator = new NoiseBasedChunkGenerator( MultiNoiseBiomeSource.createFromList( new Climate.ParameterList<>(List.of(Pair.of( Climate.parameters(0.0F, 0.0F, 0.0F, 0.0F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.BEACH)), Pair.of( Climate.parameters(0.1F, 0.2F, 0.0F, 0.2F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.BIRCH_FOREST)), Pair.of( Climate.parameters(0.3F, 0.6F, 0.1F, 0.1F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.OCEAN)), Pair.of( Climate.parameters(0.4F, 0.3F, 0.2F, 0.1F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.DARK_FOREST)) ))), noiseGenSettings.getOrThrow(NoiseGeneratorSettings.CAVES)); LevelStem stem = new LevelStem(dimTypes.getOrThrow(ModDimensions.LUSTRIA_DIM_TYPE), noiseBasedChunkGenerator); context.register(LUSTRIA_KEY, stem); } } minecraft version is 1.20.1
    • Please read the FAQ (https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/) and post logs as described there using a site like https://mclo.gs and post the link to it here. It may have the information required to solve your problem.  
    • the error code comes up when i trry to run it and ive tried to fix it but i cant  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.