Search the Forums BEFORE making a new post.

Forge (14.23.3.2672+) incompatibility.

Posted May 3, 20187 yr

Forge version 14.23.3.2672 changed something in network packet encoding, using my mod causes this non-fatal exception:

[19:24:47] [Server thread/ERROR] [FML]: FMLIndexedMessageCodec exception caught
io.netty.handler.codec.EncoderException: java.lang.RuntimeException: Undefined discriminator for message type PlayerPermisionPacket in channel weissalbedo

I am not sure why this happens. This worked in previous versions. The packet was sent and processed successfully on the client.

This is my ClientNetworkHandler class:

package weissmoon.albedo.network;

import net.minecraftforge.fml.common.network.NetworkRegistry;
import net.minecraftforge.fml.common.network.simpleimpl.SimpleNetworkWrapper;
import net.minecraftforge.fml.relauncher.Side;
import weissmoon.albedo.Reference;

/**
 * Created by Weissmoon on 2/14/18.
 */
public class ClientNetworkHandler {

    public static final SimpleNetworkWrapper INSTANCE = NetworkRegistry.INSTANCE.newSimpleChannel(Reference.MOD_ID);

    public static void init () {
        INSTANCE.registerMessage(PlayerPermisionPacket.class, PlayerPermisionPacket.class, 0, Side.CLIENT);
    }
}

This is when my packet is sent:

package weissmoon.albedo;

import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.PlayerEvent;
import net.minecraftforge.fml.common.network.NetworkRegistry;
import weissmoon.albedo.network.ClientNetworkHandler;
import weissmoon.albedo.server.events.PlayerConnected;

import java.util.ArrayList;
import java.util.List;

/**
 * Created by Weissmoon on 2/18/18.
 */
public class PlayerConnectedClient extends PlayerConnected {

    private static boolean[] pso = new boolean[4];

    private static List<EntityPlayerMP> forgePlayers = new ArrayList<EntityPlayerMP>(1);

    @Override
    @SubscribeEvent
    public void onPlayerJoinWorldEvent(PlayerEvent.PlayerLoggedInEvent event) {
        EntityPlayerMP player = (EntityPlayerMP) event.player;
        Boolean hasForge = player.connection.getNetworkManager().channel().attr(NetworkRegistry.FML_MARKER).get();
        if (hasForge) {
            PlayerConnected.setupPackage();
            forgePlayers.add(player);
            ClientNetworkHandler.INSTANCE.sendTo(PlayerConnected.packet, player);
        }
    }

Quote

May 3, 20187 yr

You are getting the error because you are trying to send an unregistered packet.

Having a ClientNetworkHandler seems dubious here - you should be registering packets on both the sending and receiving sides.

Quote

May 4, 20187 yr

Author

I have a client and a server mod, because I have a dependency for a client side only mod. I register the same packets on both sides using the same channel.

Quote

May 4, 20187 yr

What happens in previous Forge versions if you have your current code use a discriminator other than 0?

Also, it would be helpful to see PlayerConnected, in particular the definition of packet and setupPackage().

Quote

May 8, 20187 yr

Author

I have always used a discriminator of 0 for my first packet in other mods and the packet always worked.

Here is the packet and the server side PlayerConnect.

package weissmoon.albedo.server.events;

import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.PlayerEvent;
import net.minecraftforge.fml.common.network.NetworkRegistry;
import weissmoon.albedo.server.ConfigurationHandlerServer;
import weissmoon.albedo.server.network.NetworkHandler;
import weissmoon.albedo.server.network.PlayerPermisionPacket;

/**
 * Created by Weissmoon on 1/15/18.
 */
public class PlayerConnected {

    protected static PlayerPermisionPacket packet = new PlayerPermisionPacket();

    @SubscribeEvent
    public void onPlayerJoinWorldEvent(PlayerEvent.PlayerLoggedInEvent event){
        EntityPlayerMP player = (EntityPlayerMP) event.player;
        if(player.connection.getNetworkManager().isLocalChannel())
            return;
        Boolean hasForge = player.connection.getNetworkManager().channel().attr(NetworkRegistry.FML_MARKER).get();
        if(hasForge){
            setupPackage();
            NetworkHandler.INSTANCE.sendTo(packet, player);
        }
    }

    protected static void setupPackage(){
        packet.players = ConfigurationHandlerServer.playerHeldServer;
        packet.items = ConfigurationHandlerServer.itemEntityServer;
        packet.world = ConfigurationHandlerServer.worldLightServer;
    }
}

package weissmoon.albedo.network;

import io.netty.buffer.ByteBuf;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;
import weissmoon.albedo.ClientProxy;

/**
 * Created by Weissmoon on 2/14/18.
 */
public class PlayerPermisionPacket implements IMessage, IMessageHandler<PlayerPermisionPacket, IMessage> {

    public static boolean items;
    public static boolean players;
    public static boolean world;

    @Override
    public void fromBytes(ByteBuf buf) {
        players = buf.readBoolean();
        items = buf.readBoolean();
        world = buf.readBoolean();
    }

    @Override
    public void toBytes(ByteBuf buf) {
        buf.writeBoolean(players);
        buf.writeBoolean(items);
        buf.writeBoolean(world);
    }

    @Override
    public IMessage onMessage(PlayerPermisionPacket message, MessageContext ctx) {
        ClientProxy.handleServerPermisionPacket(this);
        return null;
    }
}

Quote

3 weeks later...

May 28, 20187 yr

Author

I changed the fields.

Split IMessageHandler and IMessage.

ClientProxy.handleServerPermisionPacket(message);

This method is only present on the client mod.

But I still get the exception.

Quote

May 31, 20187 yr

Author

package weissmoon.albedo.network;

import io.netty.buffer.ByteBuf;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;
import weissmoon.albedo.ClientProxy;
import weissmoon.albedo.PermissionHandler;


/**
 * Created by Weissmoon on 2/14/18.
 */
public class PlayerPermisionPacket implements IMessage {

    public boolean items;
    public boolean players;
    public boolean world;

    protected static int os;

    @Override
    public void fromBytes(ByteBuf buf) {
        players = buf.readBoolean();
        items = buf.readBoolean();
        world = buf.readBoolean();
    }

    @Override
    public void toBytes(ByteBuf buf) {
        buf.writeBoolean(players);
        buf.writeBoolean(items);
        buf.writeBoolean(world);
    }

    public static class Handler implements IMessageHandler<PlayerPermisionPacket, IMessage> {

        @Override
        public IMessage onMessage(PlayerPermisionPacket message, MessageContext ctx) {
            PermissionHandler.handleServerPermisionPacket(message);
            return null;
        }
    }

    public int getOS(){
        return os;
    }
}

Quote

May 31, 20187 yr

Author

From my Mod file:

@EventHandler
public void postInit(FMLPostInitializationEvent event){
    ClientNetworkHandler.init();
    Lists.changedConfig();
}

Amended ClientNetworkHandler:

public static void init () {
    INSTANCE.registerMessage(PlayerPermisionPacket.Handler.class, PlayerPermisionPacket.class, 0, Side.CLIENT);
}

Did not change:

On 5/3/2018 at 3:47 AM, Weissmoon said:

This is when my packet is sent:


package weissmoon.albedo;

import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.PlayerEvent;
import net.minecraftforge.fml.common.network.NetworkRegistry;
import weissmoon.albedo.network.ClientNetworkHandler;
import weissmoon.albedo.server.events.PlayerConnected;

import java.util.ArrayList;
import java.util.List;

/**
 * Created by Weissmoon on 2/18/18.
 */
public class PlayerConnectedClient extends PlayerConnected {

    private static boolean[] pso = new boolean[4];

    private static List<EntityPlayerMP> forgePlayers = new ArrayList<EntityPlayerMP>(1);

    @Override
    @SubscribeEvent
    public void onPlayerJoinWorldEvent(PlayerEvent.PlayerLoggedInEvent event) {
        EntityPlayerMP player = (EntityPlayerMP) event.player;
        Boolean hasForge = player.connection.getNetworkManager().channel().attr(NetworkRegistry.FML_MARKER).get();
        if (hasForge) {
            PlayerConnected.setupPackage();
            forgePlayers.add(player);
            ClientNetworkHandler.INSTANCE.sendTo(PlayerConnected.packet, player);
        }
    }

The packet is sent when a player joins the world

[05:43:13] [Server thread/INFO] [net.minecraft.server.MinecraftServer]: Player641 joined the game
[05:43:13] [Server thread/ERROR] [FML]: FMLIndexedMessageCodec exception caught
io.netty.handler.codec.EncoderException: java.lang.RuntimeException: Undefined discriminator for message type PlayerPermisionPacket in channel weissalbedo
    at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:106) ~[MessageToMessageEncoder.class:4.1.9.Final]
    at io.netty.handler.codec.MessageToMessageCodec.write(MessageToMessageCodec.java:116) ~[MessageToMessageCodec.class:4.1.9.Final]
    at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:738) ~[AbstractChannelHandlerContext.class:4.1.9.Final]
    at io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:801) ~[AbstractChannelHandlerContext.class:4.1.9.Final]
    at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:814) ~[AbstractChannelHandlerContext.class:4.1.9.Final]
    at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:794) ~[AbstractChannelHandlerContext.class:4.1.9.Final]
    at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:831) ~[AbstractChannelHandlerContext.class:4.1.9.Final]
    at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:1032) ~[DefaultChannelPipeline.class:4.1.9.Final]
    at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:296) ~[AbstractChannel.class:4.1.9.Final]
    at net.minecraftforge.fml.common.network.simpleimpl.SimpleNetworkWrapper.sendTo(SimpleNetworkWrapper.java:250) [SimpleNetworkWrapper.class:?]
    at weissmoon.albedo.PlayerConnectedClient.onPlayerJoinWorldEvent(PlayerConnectedClient.java:30) [PlayerConnectedClient.class:?]
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_25_PlayerConnectedClient_onPlayerJoinWorldEvent_PlayerLoggedInEvent.invoke(.dynamic) [?:?]
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) [ASMEventHandler.class:?]
    at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182) [EventBus.class:?]
    at net.minecraftforge.fml.common.FMLCommonHandler.firePlayerLoggedIn(FMLCommonHandler.java:574) [FMLCommonHandler.class:?]
    at net.minecraft.server.management.PlayerList.initializeConnectionToPlayer(PlayerList.java:228) [PlayerList.class:?]
    at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.completeServerSideConnection(NetworkDispatcher.java:259) [NetworkDispatcher.class:?]
    at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.access$100(NetworkDispatcher.java:72) [NetworkDispatcher.class:?]
    at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.update(NetworkDispatcher.java:208) [NetworkDispatcher$1.class:?]
    at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:307) [NetworkManager.class:?]
    at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:197) [NetworkSystem.class:?]
    at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:863) [MinecraftServer.class:?]
    at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:741) [MinecraftServer.class:?]
    at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) [IntegratedServer.class:?]
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:590) [MinecraftServer.class:?]
    at java.lang.Thread.run(Thread.java:748) [?:1.8.0_131]
Caused by: java.lang.RuntimeException: Undefined discriminator for message type PlayerPermisionPacket in channel weissalbedo
    at net.minecraftforge.fml.common.network.FMLIndexedMessageToMessageCodec.encode(FMLIndexedMessageToMessageCodec.java:72) ~[FMLIndexedMessageToMessageCodec.class:?]
    at io.netty.handler.codec.MessageToMessageCodec$1.encode(MessageToMessageCodec.java:67) ~[MessageToMessageCodec$1.class:4.1.9.Final]
    at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:88) ~[MessageToMessageEncoder.class:4.1.9.Final]
    ... 25 more

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/64266-forge-142332672-incompatibility/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Orbital strike cannon fishing rod mod

@Astoxy The rods will break Ok that was a early build im just waiting for curse forge and modrinth to accept my mod btw here is v1.1.5
https://drive.google.com/file/d/1wa3-awKMEoxe2WUbxGZZDIxFo_QfLWCM/view?usp=sharing
v1.2.0 will be the final version

By FoxyWoxy · 24 minutes ago24 min
Orbital strike cannon fishing rod mod

mod works well it would be better if the fishing rod wasnt unbrekable tho hope u can make it for the newer versions @FoxyWoxy

By Astoxy · 1 hour ago1 hr
New Forum Design/Update: Issues and Suggestions

Hiho,

first of all I want to say that the new forum design looks really good.

However, there are currently two issues:

In the "Unread" section, the "Mark all as Read" feature seems to be missing - or am I just overlooking it somewhere?
Some threads don’t automatically get marked as read when you open them. So the post still shows up in "Unread," even though you’ve already viewed it.
Example Thread: https://forums.minecraftforge.net/topic/159415-cannot-find-client-log-entries/

Then I have a smaller suggestion, referring to the Text Editor:

It is possible to move out the "Inline Code"-Feature from the "More Formatting Options" and add it directly to the Text Editor Tool Bar?
Same for "Quote"-Feature inside the Create Section

These two features are used quite often (at least by me) - as far as I remember, they were also available in the old forum design.

@Paint_Ninja @LexManos

By TileEntity · Posted 4 hours ago4 hr
Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

That fixed it! it's still being weird and not actually printing anything to CMD but the logs look fine and eventually the gui generated looking normal. Thanks for your help I've done that on linux before but windows servers have always just worked with one click for some reason for me

By Linksapprentice · 6 hours ago6 hr
Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Make sure you are using Java 17 JDK

In the start script, replace the word "java" with the java 17 path (javaw.exe) and put it into quotation marks

By TileEntity · 9 hours ago9 hr

FoxyWoxy

Sign In

Forge (14.23.3.2672+) incompatibility.

Featured Replies

Join the conversation

Posts

Orbital strike cannon fishing rod mod

Orbital strike cannon fishing rod mod

New Forum Design/Update: Issues and Suggestions

Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)