Jump to content

A PR I submitted has been undone in Forge 1.5


Mevans

Recommended Posts

A while ago, I submitted a PR to Forge which exposed a few sleep-related methods and fields that were either private or unnecessarily client-side-only.

 

This was because sleeping in new dimensions did not work properly, never resetting the time of day, and to fix this I had to use reflection to access the sleep-related code every single world tick. Which of course had a huge impact on performance. Hence why I submitted the PR, to allow myself and others to access these things normally.

 

With the 1.5 update the changes I made seem to have disappeared and the code has reverted to its original private or client-side state. May I ask what has caused this? These changes were very important for my mods, so I apologise if they're perhaps just waiting to be re-implemented. I would appreciate being told if something like that is the case or if I have to submit a new PR. Thanks!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.