Jump to content

Detect if player is right-clicking on flowing water


Daeruin

Recommended Posts

The title pretty much says it. I've already managed to detect if the player is right clicking on a water source block. To do that, I use the following code to get a RayTraceResult, then check if the block at that position is equal to Blocks.WATER.

 

RayTraceResult code:

Spoiler

    private static RayTraceResult getRayTraceResultFromPlayer(World world, EntityLivingBase entity)
    {
        int reach = 4;
        float var4 = 1.0F;
        float pitch = entity.prevRotationPitch + (entity.rotationPitch - entity.prevRotationPitch) * var4;
        float yaw = entity.prevRotationYaw + (entity.rotationYaw - entity.prevRotationYaw) * var4;
        double posX = entity.prevPosX + (entity.posX - entity.prevPosX) * var4;
        double posY = entity.prevPosY + (entity.posY - entity.prevPosY) * var4 + 1.62D - entity.getYOffset();
        double posZ = entity.prevPosZ + (entity.posZ - entity.prevPosZ) * var4;
        Vec3d vec = new Vec3d(posX, posY, posZ);
        float var14 = MathHelper.cos(-yaw * 0.017453292F - (float) Math.PI);
        float var15 = MathHelper.sin(-yaw * 0.017453292F - (float) Math.PI);
        float var16 = -MathHelper.cos(-pitch * 0.017453292F);
        float var17 = MathHelper.sin(-pitch * 0.017453292F);
        float var18 = var15 * var16;
        float var20 = var14 * var16;

        Vec3d var23 = vec.addVector(var18 * reach, var17 * reach, var20 * reach);
        return world.rayTraceBlocks(vec, var23, true);
    }

 

 

However, when the player right clicks on flowing water, the ray trace does not detect it at all and instead detects the block immediately past the flowing water.

 

It seems like maybe the fault is in BlockLiquid#canCollideCheck, which returns false if the water level is anything other than 0 (not flowing). That method is used by World#rayTraceBlocks, which I'm using in my ray trace code. Is there a another way?

Link to comment
Share on other sites

17 hours ago, Daeruin said:

However, when the player right clicks on flowing water, the ray trace does not detect it at all and instead detects the block immediately past the flowing water.

Try

world.rayTraceBlocks(vec1, vec2, true, false, true)

 

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Thanks for the suggestion. I tried the parameters you suggested. It only seems to return the flowing water block (with a hit type of MISS) if there's no other block in range. If I'm close to the flowing water, it still returns the block behind the flowing water. I'm thinking I might need to do a custom ray trace.

Link to comment
Share on other sites

After copying World#rayTraceBlocks into my PlayerInteractEvent and messing around a bit, I can now say that the culprit was indeed BlockLiquid#canCollideCheck. It returns false if the block's level is anything other than 0 (full source water block) and prevents the ray trace from returning the flowing water block as a hit. So I just need to bypass that in my copy of World#rayTraceBlocks, and the ray trace now returns flowing water blocks.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • It will be about medeaival times
    • the mods are crashing and I'm not sure why so heres everything  crash log https://pastebin.com/RxLKbMNR  L2 Library (12library) has failed to load correctly java.lang.NoClassDefFoundError: org/antarcticgardens/newage/content/energiser/EnergiserBlock L2 Screen Tracker (12screentracker) has failed to load correctly java.lang.NoClassDefFoundError: Could not initialize class dev.xkmc.12library.base.L2Registrate Create: Interiors (interiors) has failed to load correctly java.lang.NoClassDefFoundError: Could not initialize class com.tterrag.registrate.AbstractRegistrate L2 Damage Tracker (12damagetracker) has failed to load correctly java.lang.NoClassDefFoundError: Could not initialize class dev.xkmc.l2library.base.L2Registrate Create Enchantment Industry (create_enchantment_industry) has failed to load correctly java.lang.NoClassDefFoundError: Could not initialize class com.simibubi.create.foundation.data.Createfiegistrate Create Crafts & Additions (createaddition) has failed to load correctly java.lang.NoClassDefFoundError: Could not initialize class com.simibubi.create.foundation.data.CreateRegistrate Create Slice & Dice (sliceanddice) has failed to load correctly java.lang.NoClassDefFoundError: Could not initialize class com.simibubi.create.foundation.data.CreateRegistrate L2 Tabs (12tabs) has failed to load correctly java.lang.NoClassDefFoundError: Could not initialize class dev.xkmc.l2library.base.L2Registrate Modular Golems (modulargolems) has failed to load correctly java.lang.NoClassDefFoundError: Could not initialize class dev.xkmc.l2library.base.L2Registrate Create: Steam 'n' FRails (railways) has failed to load correctly java.lang.NoClassDefFoundError : Could not initialize class com.simibubi.create.foundation.data.Createfregistrate Cuisine Delight (cuisinedelight) has failed to load correctly java.lang.NoClassDefFoundError: Could not initialize class dev.xkmc.12library.base.L2Registrate Create (create) has failed to load correctly java.lang.NoClassDefFoundError: Could not initialize class com.simibubi.create.Create Guardian Beam Defense (creategbd) has failed to load correctly java.lang.NoClassDefFoundError: Could not initialize class com.simibubi.create.foundation.data.CreateRegistrate L2 Item Selector (12itemselector) has failed to load correctly java.lang.NoClassDefFoundError: Could not initialize class dev.xkmc.l2library.base.L2Registrate
    • hey there, I have been using Forge for years without any problems, but for some time now I have been getting this error message when I click on “Installer” under the downloads. This happens on all versions. I have tried various things but have not gotten any results. If anyone has a solution, I would be very grateful!
    • I don't have mcreator installed.
    • the session has expired, what if the modified LAN Server displays the same screen after logging in as after logging in to the premium server from a non-premium account? Minecraft Forge 1.20.1 CurseForge. I also use Mod LAN World Plug n Play
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.