Jump to content

Recommended Posts

Posted

I am trying to add glass slabs to my mod but for the life of me I can not find anywhere on the internet that can explain to me how to not have the bottom of my block allow you to see through the world, how would I prevent this from happening?

2018-08-04_08.06.07.png

Posted
  On 8/4/2018 at 12:07 PM, trolio said:

I am trying to add glass slabs to my mod but for the life of me I can not find anywhere on the internet that can explain to me how to not have the bottom of my block allow you to see through the world, how would I prevent this from happening?

Expand  

Post your code. Also override Block#isOpaqueCube(IBlockState).

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

Ok that might of happened while trying to fix my issue I was having what do I need to change in my class files to get this to work correctly going off the code I already have.

Posted
  On 8/4/2018 at 10:56 PM, trolio said:

Ok that might of happened while trying to fix my issue I was having what do I need to change in my class files to get this to work correctly going off the code I already have.

Expand  

Just return false instead of true. Opaque means is it see through. Sorry about long response time, got my own problems with forge lol.

Posted

Straight out of BlockGlass.java:

@SideOnly(Side.CLIENT)
public BlockRenderLayer getBlockLayer()
    {
        return BlockRenderLayer.CUTOUT;
    }

public boolean isFullCube(IBlockState state)
    {
        return false;
    }

looking at the forge code is really helpful.

Posted

ok so I am still at a loss for getting everything to work correctly if upload my entire project to github if one of you could take a look at it and comment back where and what I need to change that would help me out alot as when it comes to glass related blocks I have never used them before.

Posted
  On 8/4/2018 at 11:24 PM, Big_Bad_E said:

Is it? I think it is Forge's code cause it is open sourced and MC code is licensed.

Expand  

The package is net.minecraft.block not net.minecraftforge.block It is Minecraft code, Mojang allows modding, but the only way to mod something is to interact with there code. In this case Forge provides code that you can look at, but not edit. And applies some changes though asm, and patches so you can view them.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted
  On 8/4/2018 at 11:28 PM, trolio said:

ok so I am still at a loss for getting everything to work correctly if upload my entire project to github if one of you could take a look at it and comment back where and what I need to change that would help me out alot as when it comes to glass related blocks I have never used them before.

Expand  

Posting to github will help a lot at debugging.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted
  On 8/4/2018 at 11:28 PM, trolio said:

ok so I am still at a loss for getting everything to work correctly if upload my entire project to github if one of you could take a look at it and comment back where and what I need to change that would help me out alot as when it comes to glass related blocks I have never used them before.

Expand  

Sure.

  On 8/4/2018 at 11:28 PM, Animefan8888 said:

The package is net.minecraft.block not net.minecraftforge.block It is Minecraft code, Mojang allows modding, but the only way to mod something is to interact with there code. In this case Forge provides code that you can look at, but not edit. And applies some changes though asm, and patches so you can view them.

Expand  

Forge's code in the git with patches is in the package org.minecraft, and I think the Block class is forge code, and BlockGlass extends Block, so unless Block is not modified by forge, then BLockGlass has to be forge code.

Posted
  On 8/4/2018 at 11:33 PM, Big_Bad_E said:

Forge's code in the git with patches is in the package org.minecraft, and I think the Block class is forge code, and BlockGlass extends Block, so unless Block is not modified by forge, then BLockGlass has to be forge code.

Expand  

Not exactly sure what you are trying to say, but if you look in your minecraft jar file you will see the package is net.minecraft...

Forge does patch the Block class, but that doesn't mean it isn't Minecraft code. The only thing forge did was add a few fields and methods and made it implement IForgeRegistry.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted
  On 8/4/2018 at 11:37 PM, Animefan8888 said:

Not exactly sure what you are trying to say, but if you look in your minecraft jar file you will see the package is net.minecraft...

Forge does patch the Block class, but that doesn't mean it isn't Minecraft code. The only thing forge did was add a few fields and methods and made it implement IForgeRegistry.

Expand  

What I mean by it's forge code is that the class was edited by forge, not the class is completely made by forge.

I'm assuming Minecraft BlockGlass code isn't a copy of the Forge BlockGlass code.

Posted
  On 8/4/2018 at 11:46 PM, Big_Bad_E said:

What I mean by it's forge code is that the class was edited by forge, not the class is completely made by forge.

I'm assuming Minecraft BlockGlass code isn't a copy of the Forge BlockGlass code.

Expand  

Forge didn't change the BlockGlass code at all. All of the code that we are looking at in the net.minecraft package is decompiled minecraft code that has been edited to be readable by the MCP team.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Make a test with another Launcher like the Curseforge Launcher, MultiMC or AT Launcher
    • can anyone help me i am opening forge and add modpacks and then it says unable to update native luancher and i redownlaod java and the luancher it self?
    • The problem occurs also in 1.20.1 Forge, but with an "Error executing task on client" instead. I have "Sinytra Connector" installed. On 1.21.5 Fabric, there is no problem. When this happens, the chat message before the death screen appears gets sent, with an extra dash added.
    • Well, as usual, it was user error. Naming mismatch in sounds.json.  Please delete this post if you find it necessary. 
    • Hello Forge community.  I'm running into an issue with a mod I'm working on.  To preface, I can call /playsound modId:name music @a and I can hear the sound I registered being played in game. Great!  However, I cannot get it to trigger via my mod code.    Registration: public static final RegistryObject<SoundEvent> A_WORLD_OF_MADNESS = SOUND_EVENTS.register("a_world_of_madness", () -> new SoundEvent(new ResourceLocation("tetheredsouls", "a_world_of_madness")));   Playback: Minecraft mc = Minecraft.getInstance(); if (!(mc.player instanceof LocalPlayer) || mc.level == null) return; LocalPlayer player = (LocalPlayer) mc.player; BlockPos pos = player.blockPosition(); SoundEvent track = ModSounds.A_WORLD_OF_MADNESS.get(); System.out.println(track); System.out.println(pos); System.out.println(player); // play exactly like the tutorial: client-only, at the player's position try { mc.level.playLocalSound( player.getX(), player.getY(), player.getZ(), track, SoundSource.MUSIC, // Or MASTER if needed 1f, 1f, false ); System.out.println("[DEBUG] playSound success: " + track.getLocation()); } catch (Exception e) { System.err.println("[ERROR] Failed to play sound: " + track.getLocation()); e.printStackTrace(); } Sounds.json:   { "theme_of_laura": { "category": "music", "sounds": [ { "name": "tetheredsouls:a_world_of_madness", "stream": true } ] } } Things I have tried: - multiple .ogg files. Short .ogg files (5 seconds, <100KB).  - default minecraft sounds imported from import net.minecraft.sounds.SoundEvents; These work given my code. No idea why these are different.  - playSound() method, as well as several others in past iterations that did not work   I would be forever grateful if somebody could point me in the right direction. I've looked at several mod github repositories and found extremely similar code to what I'm doing. I've also found several threads in this forum that did not solve my issue. I just cannot figure out what I'm doing differently, and why I'm able to queue sounds manually with playsound but the code won't play it (despite confirming the code is being run with the debug statements.)
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.