Jump to content

Recommended Posts

Posted

When I Run the client, and put the items in the correct order in the crafting table, nothing comes out at all! Here is my json file:

{
  "type": "minecraft:crafting_shaped",
  "pattern": [
    " A ",
    "ASA",
    " A "
  ],
  "key": {
    "S": {
      "item": "minecraft:bone"
    },
    "A": [
      {
        "item": "minecraft:cooked_beef"
      },
    ]
  },
  "result": {
    "item": "im:pet_treat"
  }
}

im:pet_treat is an item id in the game. I tested this with other items and blocks and even changed the result but it still didn't work. Can anyone help?

Posted

Your recipe json has syntax errors. Specifically these lines:

  On 8/5/2018 at 3:49 PM, cherrylime said:

"A":
[
    {
        "item": "minecraft:cooked_beef"
    },
]

Expand  

As an advice - install any kind of json syntax plugin in your IDE. It will then tell you if your json has syntax errors.

Alternatively you can check your json files through a json validator like jsonlint.

  • Like 1
Posted

Here is my new code. It still does not work. Do I have to do anything to register the crafting recipe?

{
  "type": "minecraft:crafting_shaped",
  "pattern": [
    " A ",
    "ASA",
    " A "
  ],
  "key": {
    "S": {
      "item": "minecraft:bone"
    },
    "A": [
      {
        "item": "minecraft:cooked_beef"
      },
    ]
  },
  "result": {
    "item": "im:pet_treat",
    "data": 0
  }
}

Posted

I changed the code to this to make the JSON valid, but it still is not working in the game.

{
  "type": "minecraft:crafting_shaped",
  "pattern": [
    " A ",
    "ASA",
    " A "
  ],
  "key": {
    "S": {
      "item": "minecraft:bone"
    },
    "A": {
        "item": "minecraft:cooked_beef"
   },
  "result": {
    "item": "im:pet_treat",
    "data": 0
  }
  }
}

Posted

By changing the structure of your json. Currently your result property is one of the properties specified in the key object. It however must be on the same level as the type property(have no parent). Pull it up one level. See this page on the minecraft wiki for the json structure.

Posted

I have changed my code to this:

{
  "type": "minecraft:crafting_shaped",
  "pattern": [
    " A ",
    "ASA",
    " A "
  ],
  "key": {
    "S": {
      "item": "minecraft:bone"
    },
    "A": {
        "item": "minecraft:cooked_beef"
   }
    }
       "result": {
    "item": "im:pet_treat",
    "data": 0
  }
}

 

However no result shows up. Do I need to register this crafting recipe on a different class or interface?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

  Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

  Your link has been automatically embedded.   Display as a link instead

  Your previous content has been restored.   Clear editor

  You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • The problem occurs also in 1.20.1 Forge, but with an "Error executing task on client" instead. I have "Sinytra Connector" installed. On 1.21.5 Fabric, there is no problem. When this happens, the chat message before the death screen appears gets sent, with an extra dash added.
    • Well, as usual, it was user error. Naming mismatch in sounds.json.  Please delete this post if you find it necessary. 
    • Hello Forge community.  I'm running into an issue with a mod I'm working on.  To preface, I can call /playsound modId:name music @a and I can hear the sound I registered being played in game. Great!  However, I cannot get it to trigger via my mod code.    Registration: public static final RegistryObject<SoundEvent> A_WORLD_OF_MADNESS = SOUND_EVENTS.register("a_world_of_madness", () -> new SoundEvent(new ResourceLocation("tetheredsouls", "a_world_of_madness")));   Playback: Minecraft mc = Minecraft.getInstance(); if (!(mc.player instanceof LocalPlayer) || mc.level == null) return; LocalPlayer player = (LocalPlayer) mc.player; BlockPos pos = player.blockPosition(); SoundEvent track = ModSounds.A_WORLD_OF_MADNESS.get(); System.out.println(track); System.out.println(pos); System.out.println(player); // play exactly like the tutorial: client-only, at the player's position try { mc.level.playLocalSound( player.getX(), player.getY(), player.getZ(), track, SoundSource.MUSIC, // Or MASTER if needed 1f, 1f, false ); System.out.println("[DEBUG] playSound success: " + track.getLocation()); } catch (Exception e) { System.err.println("[ERROR] Failed to play sound: " + track.getLocation()); e.printStackTrace(); } Sounds.json:   { "theme_of_laura": { "category": "music", "sounds": [ { "name": "tetheredsouls:a_world_of_madness", "stream": true } ] } } Things I have tried: - multiple .ogg files. Short .ogg files (5 seconds, <100KB).  - default minecraft sounds imported from import net.minecraft.sounds.SoundEvents; These work given my code. No idea why these are different.  - playSound() method, as well as several others in past iterations that did not work   I would be forever grateful if somebody could point me in the right direction. I've looked at several mod github repositories and found extremely similar code to what I'm doing. I've also found several threads in this forum that did not solve my issue. I just cannot figure out what I'm doing differently, and why I'm able to queue sounds manually with playsound but the code won't play it (despite confirming the code is being run with the debug statements.)
    • Delete the tensura-reincarnated/common.toml file (config folder)
  • Topics

  • Create New...

Important Information

By using this site, you agree to our Terms of Use.