Jump to content

[1.12.2] Fast TESR rendered items turn dark [SOLVED]


mylimo

Recommended Posts

Hi,

if have the following issue: from some angles the items in a bowl and stand I try to render with Fast TESR turn dark:

2018-08-05_21_03_29.thumb.png.22fc6ba8a35c08e2873ebc0423b91a89.png

2018-08-05_21_03_47.thumb.png.66dd6ac460dd62a87d3327dcd8bf844f.png

 

Here is the Code of the two Render-Classes

Render of the Stand

package com.mylimo.miraculous.client.render;

import com.mylimo.miraculous.tileentity.TileEntityMagicStand;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.BufferBuilder;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.client.renderer.RenderHelper;
import net.minecraft.client.renderer.block.model.ItemCameraTransforms;
import net.minecraft.item.ItemStack;
import net.minecraftforge.client.model.animation.FastTESR;
import net.minecraftforge.items.CapabilityItemHandler;
import net.minecraftforge.items.IItemHandler;

public class RenderMagicStand extends FastTESR<TileEntityMagicStand>
{
    private float angle = 0;

    @Override
    public void renderTileEntityFast(TileEntityMagicStand te, double x, double y, double z, float partialTicks, int destroyStage, float partial, BufferBuilder buffer)
    {
        IItemHandler itemHandler = te.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, null);

        ItemStack itemStack = itemHandler.getStackInSlot(0);

        if (itemStack.isEmpty())
        {
            return;
        }



        GlStateManager.pushMatrix();
        GlStateManager.translate(x + 0.5f, y + 0.58f, z + 0.5f);
        GlStateManager.rotate( angle ,0.0f,1.0f,0);
        angle = angle + 1;
        if (angle == 361) angle = 0;
        GlStateManager.disableLighting();
        RenderHelper.enableStandardItemLighting();
        Minecraft.getMinecraft().getRenderItem().renderItem(itemStack, ItemCameraTransforms.TransformType.GROUND);
        RenderHelper.disableStandardItemLighting();

        GlStateManager.enableLighting();
        GlStateManager.popMatrix();
    }
}

 

Render of the Bowl

package com.mylimo.miraculous.client.render;

import com.mylimo.miraculous.tileentity.TileEntityMagicBowl;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.BufferBuilder;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.client.renderer.RenderHelper;
import net.minecraft.client.renderer.block.model.ItemCameraTransforms;
import net.minecraft.item.ItemStack;
import net.minecraftforge.client.model.animation.FastTESR;
import net.minecraftforge.items.CapabilityItemHandler;
import net.minecraftforge.items.IItemHandler;

public class RenderMagicBowl extends FastTESR<TileEntityMagicBowl>
{
    private float angle = 0;

    @Override
    public void renderTileEntityFast(TileEntityMagicBowl te, double x, double y, double z, float partialTicks, int destroyStage, float partial, BufferBuilder buffer)
    {
        IItemHandler itemHandler = te.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, null);

        ItemStack executor = itemHandler.getStackInSlot(0);
        ItemStack power = itemHandler.getStackInSlot(1);
        ItemStack definer = itemHandler.getStackInSlot(2);

        if (executor.isEmpty() && power.isEmpty() && definer.isEmpty()) return;

        GlStateManager.pushMatrix();
        GlStateManager.translate(x + 0.365f, y + 0.2f, z + 0.578f);
        GlStateManager.scale(0.5f, 0.5f, 0.5f);
        GlStateManager.rotate( angle ,0.0f,1.0f,0.0f);
        GlStateManager.disableLighting();
        RenderHelper.enableStandardItemLighting();
        Minecraft.getMinecraft().getRenderItem().renderItem(power, ItemCameraTransforms.TransformType.GROUND);
        RenderHelper.disableStandardItemLighting();

        GlStateManager.enableLighting();
        GlStateManager.popMatrix();

        GlStateManager.pushMatrix();
        GlStateManager.translate(x + 0.5f, y + 0.2f, z + 0.344f);
        GlStateManager.scale(0.5f, 0.5f, 0.5f);
        GlStateManager.rotate( angle ,0.0f,1.0f,0.0f);
        GlStateManager.disableLighting();
        RenderHelper.enableStandardItemLighting();
        Minecraft.getMinecraft().getRenderItem().renderItem(executor, ItemCameraTransforms.TransformType.GROUND);
        RenderHelper.disableStandardItemLighting();

        GlStateManager.enableLighting();
        GlStateManager.popMatrix();

        GlStateManager.pushMatrix();
        GlStateManager.translate(x + 0.635f, y + 0.2f, z + 0.578f);
        GlStateManager.scale(0.5f, 0.5f, 0.5f);
        GlStateManager.rotate( angle ,0.0f,1.0f,0.0f);
        GlStateManager.disableLighting();
        RenderHelper.enableStandardItemLighting();
        Minecraft.getMinecraft().getRenderItem().renderItem(definer, ItemCameraTransforms.TransformType.GROUND);
        RenderHelper.disableStandardItemLighting();

        GlStateManager.enableLighting();
        GlStateManager.popMatrix();

        angle = angle + 1;
        if (angle == 361) angle = 0;
    }
}

 

It's probably really bad code, because I don't really know what I am doing there. (Sorry, I'm trying to learn). If someone could recommend me a Tutorial about this topic that would be awesome!

Here is also a link to the Github Repository of this mod: https://github.com/Mylimo/Miraculous

 

If someone could help me that, would be awesome!

Edited by mylimo
Link to comment
Share on other sites

2 hours ago, mylimo said:

I don't really know what I am doing there. (Sorry, I'm trying to learn). If someone could recommend me a Tutorial about this topic that would be awesome!

FastTESR is for rendering tile entities in batch. That happens by initalizing the drawing buffer once, then the mods can upload vertices to the buffer passed and after everything is done there is a final draw call. That is way more performant than a regualr TESR since a regular TESR can use anywhere from 1 to infinity draw calls per render invocation where as FastTESR uses 1 draw call per however many TileEntities there are and draw calls are expensive. That however comes at a cost of a fixes BufferBuilder format and a fixed GL state. So yes, you can't use GlStateManager in a FastTESR since it screws with the GL state.

In general you should use a FastTESR for a model that you can draw with the BufferBuilder that may or may not be animated. I have some utility methods to use with a FastTESR(like rendering an obj model or a cuboid) here if you want an example of what the FastTESR can be used for.

However a FastTESR can't be used for some things. Pretty much anything that requires GL state changing or draw calls is incompatible with a FastTESR, and item rendering requires both.

Hope this explanation makes it clearer for you as to when to use a FastTESR and when to use a regular TESR.

  • Thanks 1
Link to comment
Share on other sites

Haha, yes! :D

 

Transparent alot is best alot.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I have a problem, I am trying to put two different effects to two different armors but when I run it only the emerald armor effect works. This is the code public class ModArmorItem extends ArmorItem{ private static final Map<ArmorMaterial, MobEffectInstance> MATERIAL_TO_EFFECT_MAP = (new ImmutableMap.Builder<ArmorMaterial, MobEffectInstance>()) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.HERO_OF_THE_VILLAGE,200, 1,false,false, true)) .put(ModArmorMaterials.OBSIDIAN, new MobEffectInstance(MobEffects.FIRE_RESISTANCE,200, 1,false,false, true)).build(); public ModArmorItem(ArmorMaterial pMaterial, Type pType, Properties pProperties) { super(pMaterial, pType, pProperties); } @Override public void onArmorTick(ItemStack stack, Level world, Player player){ if (!world.isClientSide()) { if (hasFullSuitOfArmorOn(player)) { evaluateArmorEffects(player); } } } private void evaluateArmorEffects(Player player) { for (Map.Entry<ArmorMaterial,MobEffectInstance> entry : MATERIAL_TO_EFFECT_MAP.entrySet()){ ArmorMaterial mapArmorMaterial = entry.getKey(); MobEffectInstance mapStatusEffect = entry.getValue(); if (hasCorrectArmorOn(mapArmorMaterial, player)) { addStatusEffectForMaterial(player, mapArmorMaterial, mapStatusEffect); } } } private void addStatusEffectForMaterial(Player player, ArmorMaterial mapArmorMaterial, MobEffectInstance mapStatusEffect) { boolean hasPlayerEffect = player.hasEffect(mapStatusEffect.getEffect()); if (hasCorrectArmorOn(mapArmorMaterial, player) && !hasPlayerEffect) { player.addEffect(new MobEffectInstance(mapStatusEffect)); } } private boolean hasCorrectArmorOn(ArmorMaterial material, Player player) { for (ItemStack armorStack : player.getInventory().armor){ if (!(armorStack.getItem() instanceof ArmorItem)) { return false; } } ArmorItem helmet = ((ArmorItem)player.getInventory().getArmor(3).getItem()); ArmorItem breastplace = ((ArmorItem)player.getInventory().getArmor(2).getItem()); ArmorItem leggins = ((ArmorItem)player.getInventory().getArmor(1).getItem()); ArmorItem boots = ((ArmorItem)player.getInventory().getArmor(0).getItem()); return helmet.getMaterial() == material && breastplace.getMaterial() == material && leggins.getMaterial() == material && boots.getMaterial() == material; } private boolean hasFullSuitOfArmorOn(Player player){ ItemStack helmet = player.getInventory().getArmor(3); ItemStack breastplace = player.getInventory().getArmor(2); ItemStack leggins = player.getInventory().getArmor(1); ItemStack boots = player.getInventory().getArmor(0); return !helmet.isEmpty() && !breastplace.isEmpty() && !leggins.isEmpty() && !boots.isEmpty(); } } Also when I place two effects on the same armor, the game crashes. Here is the crash file. The code is the same, only this part is different   private static final Map<ArmorMaterial, MobEffectInstance> MATERIAL_TO_EFFECT_MAP = (new ImmutableMap.Builder<ArmorMaterial, MobEffectInstance>()) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.HERO_OF_THE_VILLAGE,200, 1,false,false, true)) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.FIRE_RESISTANCE,200, 1,false,false, true)).build(); I hope you guys can help me. Thanks.
    • I removed all related embeddium and oculus mods, i just tested it by disconnecting and the error happened again. heres the report https://pastebin.com/1kcR5wAt   EDIT: i tried removing xaeros and also smoothboot thinking there may be an issue there, nothing, heres that report too. https://pastebin.com/zQS7i9rM
    • Hi, I need suggestions. I am a beginner in Minecraft Modding. I would like to apply custom effects to some armors, something like: more chance to drop seeds, change zombie awareness, drop more pieces of wood when chopping logs, and things like that. How would you recommend me to do it, is there any library that has something similar and which ones would you recommend me?.
    • "downloading minecraft server failed, invalid Checksum. try again, or manually place server.jar to skip download"    
    • You have to create an Entity class called PlayerPart and use multiple of them to make the different parts of the player. See EnderDragonPart.java source code. The green hitboxes of the dragon are all EnderDragonParts
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.