Jump to content

Weird Behaviour with TileEntity Container (Items getting dropped when clicked)


Recommended Posts

Posted

Hello. I have this intriguing problem here: I have this TileEntity that functions somewhat like a chest, with 12x9 slots...

 

Here's the problem: Based on

screen.png,

 

The blank spots are the places where, when an Item is present (regardless of stack size), when I click on it, it gets dropped. Left-click drops 1, right-click drops the whole stack.

 

The slots with items inside behave normally...

 

Here are the relevant code files:

TileEntity: http://pastebin.com/pXHAuCW9

Container: http://pastebin.com/BBSy4nMh

Gui: http://pastebin.com/tWqC8jWr

 

Help? This was a direct result of porting the mod over to 1.5, I didn't have any problems with this in 1.4.7 and I suspect it's the new inventory features that's causing it...

 

Any help is much appreciated, thanks!

Posted

I believe the code that's causing that behavior is in your block class. Here's the code I use:

private void dropItems(World world, int x, int y, int z){

                Random rand = new Random();

 

                TileEntity tileEntity = world.getBlockTileEntity(x, y, z);

                if (!(tileEntity instanceof IInventory)) {

                        return;

                }

                IInventory inventory = (IInventory) tileEntity;

 

                for (int i = 0; i < inventory.getSizeInventory(); i++) {

                        ItemStack item = inventory.getStackInSlot(i);

 

                        if (item != null && item.stackSize > 0) {

                                float rx = rand.nextFloat() * 0.8F + 0.1F;

                                float ry = rand.nextFloat() * 0.8F + 0.1F;

                                float rz = rand.nextFloat() * 0.8F + 0.1F;

 

                                EntityItem entityItem = new EntityItem(world,

                                                x + rx, y + ry, z + rz,

                                                new ItemStack(item.itemID, item.stackSize, item.getItemDamage()));

 

                                if (item.hasTagCompound()) {

                                        //entityItems.setTagCompound((NBTTagCompound) item.getTagCompound().copy());

                                }

 

                                float factor = 0.05F;

                                entityItem.motionX = rand.nextGaussian() * factor;

                                entityItem.motionY = rand.nextGaussian() * factor + 0.2F;

                                entityItem.motionZ = rand.nextGaussian() * factor;

                                world.spawnEntityInWorld(entityItem);

                                item.stackSize = 0;

                        }

                }

                }

  • 2 weeks later...
Posted

im having the EXACT same problem, i have been able to see that its coming from either the Container, the TileEntity or both. So far i simply passed a ContainerChest to my block/tileentity/gui and the clicking problems seems to be solved. i need to investiate more so ill copy the whole ContainerChest into my custom Container and try to understand exactly how our code is causing the problem

 

EDIT: it seems container have a certain area(on the screen) themselves, and clicking on a slot that is outside that area will insta-drop the item

 

EDIT 2: i was right bout the slot behing "out of range of the gui" to fix it, make sur in your gui you resize the xSize and ySize of your gui to fit the length and width of your container placement, also modify guiLeft and guiTop if needed

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello , when I try to launch the forge installer it just crash with a message for 0,5 secondes. I'm using java 17 to launch it. Here's the link of the error :https://cdn.corenexis.com/view/?img=d/ma24/qs7u4U.jpg  
    • You will find the crash-report or log in your minecraft directory (crash-report or logs folder)
    • Use a modpack which is using these 2 mods as working base:   https://www.curseforge.com/minecraft/modpacks/life-in-the-village-3
    • inicie un mundo donde instale Croptopia y Farmer's Delight, entonces instale el addon Croptopia Delight pero no funciona. es la version 1.18.2
    • Hello all. I'm currently grappling with the updateShape method in a custom class extending Block.  My code currently looks like this: The conditionals in CheckState are there to switch blockstate properties, which is working fine, as it functions correctly every time in getStateForPlacement.  The problem I'm running into is that when I update a state, the blocks seem to call CheckState with the position of the block which was changed updated last.  If I build a wall I can see the same change propagate across. My question thus is this: is updateShape sending its return to the neighbouring block?  Is each block not independently executing the updateShape method, thus inserting its own current position?  The first statement appears to be true, and the second false (each block is not independently executing the method). I have tried to fix this by saving the block's own position to a variable myPos at inception, and then feeding this in as CheckState(myPos) but this causes a worse outcome, where all blocks take the update of the first modified block, rather than just their neighbour.  This raises more questions than it answers, obviously: how is a different instance's variable propagating here?  I also tried changing it so that CheckState did not take a BlockPos, but had myPos built into the body - same problem. I have previously looked at neighbourUpdate and onNeighbourUpdate, but could not find a way to get this to work at all.  One post on here about updatePostPlacement and other methods has proven itself long superceded.  All other sources on the net seem to be out of date. Many thanks in advance for any help you might offer me, it's been several days now of trying to get this work and several weeks of generally trying to get round this roadblock.  - Sandermall
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.