Search the Forums BEFORE making a new post.

1.12.2 How to make a life steal enchantment by percentage [SOLVED]

Posted August 8, 20187 yr

Actually, I have done one:

	@Override
	public void onEntityDamaged (EntityLivingBase user, Entity target, int level) {
		user.heal(1 + level);
	}

...

But I have a problem, this heals the player a flat amount. My idea is to heal the player a percentage of the damage dealt to the target. How can I get the amount of damaged provoked to the enemy in order to calculate my life steal?

Edited August 9, 20187 yr by Enderlook

Quote

August 8, 20187 yr

4 hours ago, Enderlook said:

But I have a problem, this heals the player a flat amount. My idea is to heal the player a percentage of the damage dealt to the target. How can I get the amount of damaged provoked to the enemy in order to calculate my life steal?

You're not able to apply your Enchantment Effect in that method. You will need to subscribe to the LivingDamageEvent or LivingAttackEvent.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

August 8, 20187 yr

Author

55 minutes ago, Animefan8888 said:

You're not able to apply your Enchantment Effect in that method. You will need to subscribe to the LivingDamageEvent or LivingAttackEvent.

Ok, I've tried with this code (and the same with LivingDamageEvent) but it seems don't work:

	@SubscribeEvent
	public void vampire(LivingAttackEvent event) {
		Object attacker = event.getSource().getTrueSource();
		if (attacker instanceof EntityLivingBase) {
			EntityLivingBase entityAttacker = (EntityLivingBase)attacker;
			if(!entityAttacker.getEntityWorld().isRemote) {
				int level = EnchantmentHelper.getEnchantmentLevel(ENCHANTEMNT_VAMPIRISM, entityAttacker.getHeldItemMainhand());
				entityAttacker.heal(event.getAmount() * (level / 5));
			}	
		}	
	}

What am I doing wrong?

Quote

August 8, 20187 yr

12 minutes ago, Enderlook said:

What am I doing wrong?

Is your event registered?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

August 9, 20187 yr

Author

14 minutes ago, Animefan8888 said:

Is your event registered?

... isn't "@SubscribeEvent" the way to register the event? I've another event registered in that way (for another enchantment) and they work. All of them are registered in the same class under the "@EventBusSubscriber(modid=ExtraCraft.MOD_ID)"

Quote

August 9, 20187 yr

If you use @EventBusSubscriber you have to make the event method static

Quote

August 9, 20187 yr

Author

16 minutes ago, Terrails said:

If you use @EventBusSubscriber you have to make the event method static

Ups, I've forgotten that. And which method is better? Register them like I do, or in the other way?

Quote

August 9, 20187 yr

7 minutes ago, Enderlook said:

Ups, I've forgotten that. And which method is better? Register them like I do, or in the other way?

It ultimately doesn't matter.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/65797-1122-how-to-make-a-life-steal-enchantment-by-percentage-solved/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted 2 hours ago2 hr
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted 10 hours ago10 hr
incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Dealing with modded server issues can be a real headache been there! At least you can keep your look stress-free with a fresh low taper fade.

By AriaDawn · 10 hours ago10 hr
Help with file conversion

This is really helpful

By Brialeblanc · 15 hours ago15 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 21 hours ago21 hr

Ugdhar

Sign In

1.12.2 How to make a life steal enchantment by percentage [SOLVED]

Featured Replies

Join the conversation

Posts

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Help with file conversion

Cobblemon invalid player data

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)