[Solved] 1.12| IBakedModel done, how to rotate using IModel & ICustomModelLoader?

[CAS_ual_TY]

hello, itse me again.

Basically I setup a working "structure" in which Items have different attachments which are then rendered overlayed on to the item. These attachments have multiple json models and textures: The model and texture of the attachment itself and a model and texture for each item it can be put on to.

All IBakedModels are setup correctly and everything is working; except for the rotations, those are off. I have checked and this does not come from the json files (when not using IBakedModels then all rotations are fine, I also tested json+rotation+IBakedModel but the rotations there dont matter at all).

Now, I have already researched a bit, about using IModel and ICustomModelLoader but I have questions:

- Should I simply point ICustomModelLoader to a new IModel, which then just points to the IBakedModel and thats it?

- IBakedModel requires a lot of other models so that i works which are fetched from the ModelBakeEvent. How would I get those when using the ICustomModelLoader? Would I use the ::onResourceManagerReload function to get these models?

- Any examples out there I could take a look at?

- This is the solution(s) I found via google. Any better ones out there?

Edited August 24, 2018 by CAS_ual_TY

[Cadiboo]

22 hours ago, CAS_ual_TY said:

hello, itse me again.

Basically I setup a working "structure" in which Items have different attachments which are then rendered overlayed on to the item. These attachments have multiple json models and textures: The model and texture of the attachment itself and a model and texture for each item it can be put on to.

All IBakedModels are setup correctly and everything is working; except for the rotations, those are off. I have checked and this does not come from the json files (when not using IBakedModels then all rotations are fine, I also tested json+rotation+IBakedModel but the rotations there dont matter at all).

Now, I have already researched a bit, about using IModel and ICustomModelLoader but I have questions:

- Should I simply point ICustomModelLoader to a new IModel, which then just points to the IBakedModel and thats it?

- IBakedModel requires a lot of other models so that i works which are fetched from the ModelBakeEvent. How would I get those when using the ICustomModelLoader? Would I use the ::onResourceManagerReload function to get these models?

- Any examples out there I could take a look at?

- This is the solution(s) I found via google. Any better ones out there?

Can you restate your question more clearly? I can’t quite understand what your asking.

I don’t think that in-code model rotations are possible, won’t these be done inside the JSON?

[CAS_ual_TY]

2 hours ago, Cadiboo said:

Can you restate your question more clearly? I can’t quite understand what your asking.

I don’t think that in-code model rotations are possible, won’t these be done inside the JSON?

Sorry, yes I should have asked more clearly but you nailed it. Rotation is what is off and I need to fix that in code. Basically in the IBakedModel different json models are simply combined and rendered together. Adding rotation inside these json models does not change anything, however.

I have googled and it seems that i have to work with ICustomModelLoader ahd IModel, but I have had these questions above about that.

Thanks in advance

[Cadiboo]

10 hours ago, CAS_ual_TY said:

Sorry, yes I should have asked more clearly but you nailed it. Rotation is what is off and I need to fix that in code. Basically in the IBakedModel different json models are simply combined and rendered together. Adding rotation inside these json models does not change anything, however.

I have googled and it seems that i have to work with ICustomModelLoader ahd IModel, but I have had these questions above about that.

Thanks in advance

What is wrong with your rotations? They should be defined in your json files and not modified by the code?

[CAS_ual_TY]

14 hours ago, Cadiboo said:

What is wrong with your rotations? They should be defined in your json files and not modified by the code?

I have already said that I am in fact defining the rotations in the json models and that I do not modify them in code at all. Here is an example:

https://imgur.com/a/thAr5ET

 

Anyways, I have found the solution to the problem. The IBakedModel interface has default methods which are defining that. I have simply added

 

	@Override
	public ItemCameraTransforms getItemCameraTransforms()
	{
		return this.modelMain.getItemCameraTransforms();
	}
	
	@Override
	public boolean isAmbientOcclusion(IBlockState blockState)
	{
		return this.modelMain.isAmbientOcclusion(blockState);
	}
	
	@Override
	public Pair<? extends IBakedModel, Matrix4f> handlePerspective(TransformType transformType)
	{
		return this.modelMain.handlePerspective(transformType);
	}

 

to the class. The modelMain field is of course the model which previously is stored at the ModelResourceLocation before it is replaced at that exact location with this IBakedModel.

 

EDIT:

So I figured some more stuff out. You need to do this instead:

 

	@Override
	public Pair<? extends IBakedModel, Matrix4f> handlePerspective(TransformType transformType)
	{
		return Pair.of(this, this.modelMain.handlePerspective(transformType).getRight());
	}

 

Edited August 24, 2018 by CAS_ual_TY