[Solved][1.12] Entity#setAir(int air) does nothing

[Spaceboy Ross]

I'm trying to add the moon into my mod and I've added an event handler that handles entity events. Whenever I spawn an entity on the moon in my mod, the entity doesn't suffocate.

@Mod.EventBusSubscriber
public class EntityHandler {
	
	@SubscribeEvent
	public static void onEntitySpawn(EntityJoinWorldEvent event) {
		if(event.getEntity().dimension == GundamDimensions.moonID) {
			event.getEntity().setAir(0);
			PacketHandler.INSTANCE.sendToServer(new PacketEntitySyncServer(event.getEntity()));
		}
	}
}

 

Edited September 24, 2018 by Spaceboy Ross

[Draco18s]

Suffocation only occurs when an entity is inside a solid block or under water. If it's in "air" (or what the game believes to be air) the amount of air isn't even queried.

 

For example:

You can't drown in lava. Try it.

Edited September 24, 2018 by Draco18s

[Spaceboy Ross]

Just now, Draco18s said:

Suffocation only occurs when an entity is inside a solid block or under water. If it's in "air" (or what the game believes to be air) the amount of air isn't even queried.

Well, how do I make an airless dimension then?

[Draco18s]

The only mod that I know of that did it is GalactiCraft and they had to completely rewrite entire classes (in non-compatible ways) to do it.

[V0idWa1k3r]

Wouldn't you be able to just periodically(LivingUpdateEvent, check if Entity.ticksExisted % X == 0 to make the check happen once every X ticks) check whether the entity has a "space suit" or similar equipped and if not deal drowning damage via Entty#attackEntityFrom? As far as I can see there is no reason to use ASM here.

Edited September 24, 2018 by V0idWa1k3r

[Spaceboy Ross]

3 minutes ago, V0idWa1k3r said:

Wouldn't you be able to just periodically(LivingUpdateEventor something, check if Entity.ticksExisted % X == 0 to make the check happen once every X ticks) check whether the entity has a "space suit" or similar equipped and if not deal drowning damage via Entty#attackEntityFrom? As far as I can see there is no reason to use ASM here.

It works, thanks for telling me that.