[1.12.2] What's wrong with EntityAINearestAttackableTarget?

[SapphireSky]

I'm trying to make a mob (extends EntityMob) and am basically copying tasks from existing mobs, but EntityAINearestAttackableTarget is giving me warnings that it's generic.

This is the default code, in any given mob class with a big yellow underline in Eclipse:

this.targetTasks.addTask(1, new EntityAINearestAttackableTarget(this, EntityPlayer.class, true));
this.targetTasks.addTask(2, new EntityAINearestAttackableTarget(this, EntityVillager.class, false));
this.targetTasks.addTask(3, new EntityAINearestAttackableTarget(this, EntityIronGolem.class, true));

 

Yet if I apply the suggested fix, it doesn't show a warning:

this.targetTasks.addTask(1, new EntityAINearestAttackableTarget<EntityPlayer>(this, EntityPlayer.class, true));
this.targetTasks.addTask(2, new EntityAINearestAttackableTarget<EntityVillager>(this, EntityVillager.class, false));
this.targetTasks.addTask(3, new EntityAINearestAttackableTarget<EntityIronGolem>(this, EntityIronGolem.class, true));

 

My question is, why? Why does it give me a warning if it's the Vanilla code that obviously works?

Is it going to be problematic if I ignore the warning? Or if I fix the warning?

[Animefan8888]

1 hour ago, SapphireSky said:

I'm trying to make a mob (extends EntityMob) and am basically copying tasks from existing mobs, but EntityAINearestAttackableTarget is giving me warnings that it's generic.

This is the default code, in any given mob class with a big yellow underline in Eclipse:

this.targetTasks.addTask(1, new EntityAINearestAttackableTarget(this, EntityPlayer.class, true));
this.targetTasks.addTask(2, new EntityAINearestAttackableTarget(this, EntityVillager.class, false));
this.targetTasks.addTask(3, new EntityAINearestAttackableTarget(this, EntityIronGolem.class, true));

 

Yet if I apply the suggested fix, it doesn't show a warning:

this.targetTasks.addTask(1, new EntityAINearestAttackableTarget<EntityPlayer>(this, EntityPlayer.class, true));
this.targetTasks.addTask(2, new EntityAINearestAttackableTarget<EntityVillager>(this, EntityVillager.class, false));
this.targetTasks.addTask(3, new EntityAINearestAttackableTarget<EntityIronGolem>(this, EntityIronGolem.class, true));

 

My question is, why? Why does it give me a warning if it's the Vanilla code that obviously works?

Is it going to be problematic if I ignore the warning? Or if I fix the warning?

No it's completely fine if you leave it with the yellow underline. It just wants you to specify a type argument.

[diesieben07]

Vanilla code is decompiled, so it's not perfect.

Generics are erased, so List<String> becomes just List once compiled. So it is hard for the decompiler to get back this information.

Raw types (what Eclipse warns you about) are a legacy feature of Java and should not be used. So no, it is not "completely fine".