I'm having trouble making a bale of hay.

[Zeigfreid]

I encountered difficulty when trying to make a blockstate for a block with rotation like a log, or a hay bale. I've read this and this, and I know that `hay_bale` has an `axis` property with three values `x`, `y`, and `z`. I haven't been able to make the rotations work (the block shows up as a blank texture in world). If I leave off the `axis` property entirely, the block renders properly (just, without rotation). 

 

When I looked around at other mods (botania, harvestcraft) for examples of blocks with rotation, they are using minecraft blockstates (like, `"axis=x": {}`) rather than forge blockstates. I also poked through the blockstates folders of some jabelar's mods, but without knowing exactly what I'm looking for it's like...

 

looking for a needle in a hay stack?

 

My class is very simple and just extends `HayBlock`. My blockstate looks like this:

 

{
  "forge_marker": 1,
  "defaults": {
    "textures": {
      "all": "tutorial:blocks/tatami"
    },
    "uvlock": true,
    "model": "cube_all"
  },
  "variants": {
    "normal": [{ }],
    "inventory": [{ }],
    "axis": {
      "x": { "y": 0 },
      "y": { },
      "z": { "y": 90 }
    }
  }
}

 

What is my misconception?

 

Thanks for your advice in advance!

[V0idWa1k3r]

34 minutes ago, Zeigfreid said:

"y": { },

Don't have empty variants. It isn't supposed to be empty anyway - if the X axis is the default one and the Z is rotated by 90 degrees on the Y axis then the Y variant should be rotated by 90 degrees on either X or Z axis. 

34 minutes ago, Zeigfreid said:

examples of blocks with rotation, they are using minecraft blockstates (like, `"axis=x": {}`) rather than forge blockstates. I also poked through the blockstates folders of some jabelar's mods, but without knowing exactly what I'm looking for it's like...

Here is my example of using a blockstate with rotation.

 

34 minutes ago, Zeigfreid said:

If I leave off the `axis` property entirely, the block renders properly (just, without rotation). 

This actually means that your block doesn't have the rotation property at all, since if it had a property that wasn't specified in it's blockstate file it would have a missing model since it's blockstate file is invalid. Either you are not relaying the correct information or you don't have the property in your BlockStateContainer.

 

34 minutes ago, Zeigfreid said:

My class is very simple and just extends `HayBlock`.

Show it anyway, you have some conflicting information here.

[Zeigfreid]

Thanks! Here's the class, but it is honestly just HayBlock.

 

package net.shadowfacts.tutorial;

import net.minecraft.block.BlockHay;
import net.minecraft.entity.Entity;
import net.minecraft.item.Item;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class BlockTatami extends BlockHay implements ItemModelProvider {

	public BlockTatami () {
		super();

		setUnlocalizedName("tatami");
		setRegistryName("tatami");
	}
	
	@Override
	public void registerItemModel(Item item) {
		TutorialMod.proxy.registerItemRenderer(item, 0, "tatami");
	}
	
	/* unfortunately, tatami will not save you from a fall */
    public void onFallenUpon(World worldIn, BlockPos pos, Entity entityIn, float fallDistance)
    {
    	// NO-OP
    }
}

 

(oh I just noticed that I missed an @Override ? )

 

(also, I realize that repeating hard coded strings is a bad idea, I'm just trying to get it working)

Edited October 21, 2018 by Zeigfreid

[Zeigfreid]

Hmm yeah definitely not working. I changed the json to this: 

 

{
  "forge_marker": 1,
  "defaults": {
    "textures": {
      "all": "tutorial:blocks/tatami"
    },
    "uvlock": true,
    "model": "cube_all"
  },
  "variants": {
    "normal": [
      {}
    ],
    "inventory": [
      {}
    ],
    "axis": {
      "x": {
        "textures": {
          "all": "tutorial:blocks/orecopper"
        },
        "model": "cube_all",
        "x": 90,
        "y": 90
      },
      "y": {
        "model": "cube_all"
      },
      "z": {
        "model": "cube_all",
        "x": 90
      }
    }
  }
}

 

In the hopes. When I place a block on the x axis I should get an oreCopper, but I don't! So there must be something I'm missing elsewhere.

 

I extend from BayHale and when I use the minecraft blockstates like "axis=x" and "axis=y" in my json I get the default texture, but the texture has "tatami#axis=z" or "tatami#axis=y" written on it, so in that case I know that the rotation is working. When I use the forge blockstates though, I just see the blank texture, or (once I added those `model: cube_all` lines, which I had assumed would be redundant) I get just the default tatami model. So... so something's up.

 

Your `BlockLog` class extends BlockRotatedPillar directly, where as I was extending BlockHay (which is a really simple class that adds very little, and I figure a tatami mat is very close to a bale of hay in principle). Maybe I will try to extend BlockRotatePillar instead.

 

Anyway, I have your repo to dig around in now (thanks) so I'm sure I will be able to figure it out!

 

Thanks!

Edited October 21, 2018 by Zeigfreid

[Cadiboo]

Don’t use IHasModel (or something similar I.e. ItemModelProvider). Nothing to do with model registration requires private/protected access. You can register all your models in 3 lines of code. Also don’t implement it on a Block. Also interface names should start with “I”.

 

Did you try looking at the vanilla hay blockstate?

[Zeigfreid]

Thanks for the lint Cadiboo  I did in fact try looking at the `hay_block.json` file in `assets.mincraft.blockstats`, but I received an error  "Problems opening editor for hay_block.json: System editor can only open file base resources".

[Cadiboo]

JSON is just a glorified text file. If your using Eclipse you can install a JSON plugin or you can install some other text editor. I suggest Sublime Text as it has amazing text highlighting and even some syntax highlighting. It’s very intuitive and built for programmers and I’ve never had a single issue with it. 

[Zeigfreid]

Hmm, Cadiboo it isn't that I am unable to edit JSON files at all (I edited the one above, right?) it's that when I try to open a JSON file in assets.minecraft.blockstates I get an error. I get a similar error if I try to open a png from assets.minecraft.textures.blocks. I think it is because these files are in a jar? It's weird though because I can open a .class file from net.minecraft.client.main so...

[Cadiboo]

What OS are you on? I know that native editors on OSX restrict editing in /Library/, and I assume other operating systems might do something similar. But reading and copying shouldn’t be restricted

[Zeigfreid]

Ah problem solved! I am now able to view JSON files. The key was I had so far been using an external editor to work with my own JSON files (vscode). An external editor isn't allowed to open files from inside a jar maybe? Anyway, when I set the default open with to eclipse's internal generic text editor I was then able to open hay_bale.json. However, as expected, it is a minecraft blockstate not a forge blockstate...

 

{
    "variants": {
        "axis=y": { "model": "hay" },
        "axis=z": { "model": "hay", "x": 90 },
        "axis=x": { "model": "hay", "x": 90, "y": 90 }
    }
}

 

(but I'm glad to have the correct rotations)

Edited October 22, 2018 by Zeigfreid

[Zeigfreid]

I'm going to copy/paste the implementation of `BlockRotatedPillar` and fill it with `println` statements to get a sense of what is and isn't happening.

[Cadiboo]

You really don’t need forges blockstate, it’s meant for more complicated stuff. Use that blockstate and just substitute in your block & mod and your done

[Cadiboo]

3 minutes ago, Zeigfreid said:

I'm going to copy/paste the implementation of `BlockRotatedPillar` and fill it with `println` statements to get a sense of what is and isn't happening.

This is a good idea in general, however it probably won’t really help as models aren’t handled in your block’s code.

[Zeigfreid]

Hmm if I define separate textures for each facing I am able to get those separate textures to show. For example:

 

{
  "forge_marker": 1,
  "defaults": {
    "textures": {
      "all": "tutorial:blocks/tatami"
    },
    "uvlock": true,
    "model": "cube_all",
    "transform": "forge:default-block"
  },
  "variants": {
    "normal": [
      {}
    ],
    "inventory": [
      {}
    ],
    "axis": {
      "y": { 
        "textures": {
          "all": "tutorial:blocks/orecopper"
        },
        "model": "cube_all"
      },
      "z": {
        "model": "cube_all",
        "x": 90
      },
      "x": {
        "model": "cube_all",
        "x": 90,
        "y": 90
      }
    }
  }
}

 

In this case, the orecopper texture shows when I place the block against the y axis. In addition, when I view the debug info with F3 I am able to see that the blocks variant is being chosen correctly. So the correct variant is being chosen based on the property value. It's the rotation that isn't happening.

 

I've double checked my rotation values against the hay_block.json values, and then I also took time to "figure out" an intuition for which rotation corresponds which which action on the block in the world (I was kind of flying blind). If I click against the a block face that lies in a plane normal to the x axis, then I am selecting axis=x. With a bale of hey I see a rotation of the block 90 degrees around the x axis and then 90 degrees around the y axis (which is vertical). I've convinced myself that if the rotations were happening, I would definitely be seeing the orientations that I want to see.

 

That being said: looks like its back to the tutorial mines for me!

[Cadiboo]

7 hours ago, Cadiboo said:

You really don’t need forges blockstate, it’s meant for much more complicated stuff. Use the vanilla hay_bale blockstate and just substitute in your block & mod and your done!