{Solved} Right click action going through twice

[BigSpidey]

My onItemRightClick event keeps going through twice, and even with diagnostics I can't find out why. Any help is appreciate, thank you! {note that many of the contents of this code are simply placeholders}

....................................................................

public class BakugoQuirk extends ItemBase 
{
    public BakugoQuirk(String name) 
    {
        super(name);
        this.setMaxDamage(500);
        this.isDamageable();
    }
    
    public void onUpdate(ItemStack item, World worldIn, Entity playerIn)
    {
        if (item.getItemDamage() != 0)
        {
            item.setItemDamage(499);    //Item damage gain per tick
        }
    }
    
    public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn) 
    {
        ItemStack item = playerIn.getHeldItem(handIn);
        Vec3d aim = playerIn.getLookVec();
        
        System.out.println("testing for first condition, ItemDamage is " + item.getItemDamage());
        if(item.getItemDamage() == 0)
        {
            playerIn.sendMessage(new TextComponentString("100% charge attack"));
            EntityLargeFireball fireball = new EntityLargeFireball(worldIn, playerIn, 1,1,1);
            fireball.setPosition(playerIn.posX + aim.x * 1.5D, playerIn.posY + aim.y * 1.5D , playerIn.posZ + aim.z * 1.5D);
            fireball.accelerationX = aim.x * 0.1; 
            fireball.accelerationY = aim.y * 0.1; 
            fireball.accelerationZ = aim.z * 0.1; 
            worldIn.spawnEntity(fireball);
            item.setItemDamage(499);
            System.out.println("ItemDamage is " + item.getItemDamage() + " after test");
        }
        else if(item.getItemDamage() > 0)
        {
            System.out.println("Going into second condition with " + item.getItemDamage() + " Item Damage");
            EntityLargeFireball fireball = new EntityLargeFireball(worldIn, playerIn, 1,1,1);
            fireball.setPosition(playerIn.posX + aim.x * 1.5D, playerIn.posY + aim.y * 1.5D , playerIn.posZ + aim.z * 1.5D);
            fireball.accelerationX = aim.x * 0.1; 
            fireball.accelerationY = aim.y * 0.1; 
            fireball.accelerationZ = aim.z * 0.1; 
            worldIn.spawnEntity(fireball);
            playerIn.sendMessage(new TextComponentString("50%-100% charge attack"));
            item.setItemDamage(item.getMaxDamage() - 1);
        }
        
        

    
    
        return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, item);
    }

 

 

 

EDIT {SOLVED}:

Just ended up adding a broad 

"if (worldIn.isRemote == false )"

over much of the code including the entity spawn and the chat message

Edited October 24, 2018 by BigSpidey

[Daeruin]

The method is likely being called once on the server and once on the client. Add a println statement and check if world.isRemote is true or false. True means it's the client, false means it's the server. My guess is you probably need it to run on both sides, so there's no problem.

[Cadiboo]

It’s also fired for both hands I believe

Edited October 23, 2018 by Cadiboo

[V0idWa1k3r]

  On 10/23/2018 at 5:21 AM, Cadiboo said:

It’s also fired for both hands I believe

Expand  

You are confusing this method with the right click event. The event will indeed fire for both hands. The Item#onItemRightClick will only fire for the hand holding the item.

 

  On 10/22/2018 at 9:30 PM, BigSpidey said:

            worldIn.spawnEntity(fireball);

Expand  

You can't do this without first checking whether the side the action is happening on is a server. Otherwise it will create a "ghost" entity on the client that will stay there untill relog. As @Daeruin said

  On 10/23/2018 at 5:11 AM, Daeruin said:

check if world.isRemote is true or false. True means it's the client, false means it's the server

Expand  

 

  On 10/22/2018 at 9:30 PM, BigSpidey said:

            playerIn.sendMessage(new TextComponentString("100% charge attack"));

Expand  

Same with this, you need to check the side. Otherwise you are sending the message twice.

[BigSpidey]

  On 10/23/2018 at 12:33 PM, V0idWa1k3r said:

You are confusing this method with the right click event. The event will indeed fire for both hands. The Item#onItemRightClick will only fire for the hand holding the item.

 

You can't do this without first checking whether the side the action is happening on is a server. Otherwise it will create a "ghost" entity on the client that will stay there untill relog. As @Daeruin said

 

Same with this, you need to check the side. Otherwise you are sending the message twice.

Expand  

Thanks to everyone here, I have solved the problem! 

[Cadiboo]

Please post your final code and mark the topic as solved to help people in the future