Item onUpdate() not working as intended.

[WolfHybrid23]

Hello, So I am creating an item that will burn the player if they aren't immune to fire and don't have fire protection armor, However the event doesn't appear to be getting called... Can someone explain what I did wrong?
 

public class SolstoneRockItem extends ItemBlockBase{
	public SolstoneRockItem()
	{
		super(ModBlocks.SOLSTONE_ROCK, "solstone_rock", "SolstoneRock");
	}
	@Override
	public void onUpdate(ItemStack s, World w, Entity e, int l, boolean h)
	{
		for(ItemStack armor : e.getArmorInventoryList())
		{
			NBTTagList enchList = armor.getEnchantmentTagList();
			for(int i = 0; i < enchList.tagCount(); i++)
			{
				if(enchList.getCompoundTagAt(i).getInteger("id") == Enchantment.getEnchantmentID(Enchantments.FIRE_PROTECTION))return;
			}
		}
		e.attackEntityFrom(DamageSource.ON_FIRE, 1.0f);
	}
}

Thank you!

EDIT:

It appears that onUpdate isn't being called period. I will try a different approach.

Edited October 25, 2018 by WolfHybrid23

[diesieben07]

24 minutes ago, WolfHybrid23 said:

ItemBlockBase

Don't do this.

 

24 minutes ago, WolfHybrid23 said:

It appears that onUpdate isn't being called period.

How did you come to this conclusion? onUpdate works fine.

[WolfHybrid23]

4 minutes ago, diesieben07 said:

Don't do this.

 

How did you come to this conclusion? onUpdate works fine.

I just tried onUpdate without any return statements and my code didn't execute, also the reason I used an ItemBlockBase was so I could override onUpdate in the first place. And because the Item I wanted to update was an ItemBlock.

Edited October 25, 2018 by WolfHybrid23

[diesieben07]

Just now, WolfHybrid23 said:

and my code didn't execute

Again: How did you come to this conclusion?

 

1 minute ago, WolfHybrid23 said:

also the reason I used an ItemBlockBase was so I could override onUpdate in the first place.

This does not make sense. onUpdate is a method in Item, you do not need a "base class" to override it.

[WolfHybrid23]

How do I override it then?
I'm new to forge development sorry. I mainly use C++ and GML...

Edited October 25, 2018 by WolfHybrid23

[diesieben07]

Just now, WolfHybrid23 said:

How do I override it then?

Just like you did in your code above. But you do not need ItemBlockBase. Why do you have it?

[WolfHybrid23]

Could you give me an example?

Here is the code for ItemBlockBase:
 

public class ItemBlockBase extends ItemBlock{
	public ItemBlockBase(Block b, String name, String unlocalName)
	{
		super(b);
		this.setRegistryName(name);
		this.setUnlocalizedName(unlocalName);
		this.setCreativeTab(CreativeTabs.BUILDING_BLOCKS);
		ModItems.ITEMS.add(this);
	}
}

 

[diesieben07]

1 minute ago, WolfHybrid23 said:

Here is the code for ItemBlockBase:
 

public class ItemBlockBase extends ItemBlock{
	public ItemBlockBase(Block b, String name, String unlocalName)
	{
		super(b);
		this.setRegistryName(name);
		this.setUnlocalizedName(unlocalName);
		this.setCreativeTab(CreativeTabs.BUILDING_BLOCKS);
		ModItems.ITEMS.add(this);
	}
}

 

This kind of class is an antipattern. More generally, using inheritance for reusing code is an antipattern, that is not what inheritance exists for. Use composition instead.

 

2 minutes ago, WolfHybrid23 said:

Could you give me an example?

class MyItemBlock extends ItemBlock {
  @Override
  public void onUpdate(ItemStack s, World w, Entity e, int l, boolean h) {
    // do stuff
  }
}

 

[WolfHybrid23]

Okay...

[WolfHybrid23]

It's still not damaging me. @diesieben07
 

public class SolstoneRockItem extends ItemBlock{
	public SolstoneRockItem()
	{
		super(ModBlocks.SOLSTONE_ROCK);
		this.setRegistryName("solstone_rock");
		this.setUnlocalizedName("SolstoneRock");
		ModItems.ITEMS.add(this);
	}
	@Override
	public void onUpdate(ItemStack s, World w, Entity e, int l, boolean h)
	{
		if(e.isImmuneToFire() || e.getIsInvulnerable())return;
		for(ItemStack armor : e.getArmorInventoryList())
		{
			for(int k = 0; k < armor.getEnchantmentTagList().tagCount(); k++)
			{
				if(armor.getEnchantmentTagList().getCompoundTagAt(k).getString("id") == "fire_protection")return;
			}
		}
		e.attackEntityFrom(DamageSource.ON_FIRE,1.0f);
	}
}

 

Edited October 25, 2018 by WolfHybrid23

[diesieben07]

Just now, WolfHybrid23 said:

It's still not damaging me.

Ah, so you finally answered my question from above:

14 minutes ago, diesieben07 said:

Again: How did you come to this conclusion?

In the future: Use the debugger to figure out what is happening.

 

Your code to check for Enchantments is broken (you cannot compare Strings with ==). To check for enchantments on a specific ItemStack use EnchantmentHelper.getEnchantmentLevel. To check for enchantments on a complete entity (probably what you want) use EnchantmentHelper.getMaxEnchantmentLevel.

[WolfHybrid23]

1 minute ago, diesieben07 said:

Ah, so you finally answered my question from above:

In the future: Use the debugger to figure out what is happening.

 

Your code to check for Enchantments is broken (you cannot compare Strings with ==). To check for enchantments on a specific ItemStack use EnchantmentHelper.getEnchantmentLevel. To check for enchantments on a complete entity (probably what you want) use EnchantmentHelper.getMaxEnchantmentLevel.

Like this? 

if(EnchantmentHelper.getEnchantmentLevel(Enchantments.FIRE_PROTECTION, armor) > 0)return;

 

[diesieben07]

1 minute ago, WolfHybrid23 said:

Like this? 

if(EnchantmentHelper.getEnchantmentLevel(Enchantments.FIRE_PROTECTION, armor) > 0)return;

 

That would check for one piece, yes. However you should not exclusively just check the armor pieces. Use the method that checks the whole entity for you.

[WolfHybrid23]

Just now, diesieben07 said:

That would check for one piece, yes. However you should not exclusively just check the armor pieces. Use the method that checks the whole entity for you.

Okay, Thank you so very much for your help. And thanks for being patent with me too!

[WolfHybrid23]

2 minutes ago, diesieben07 said:

That would check for one piece, yes. However you should not exclusively just check the armor pieces. Use the method that checks the whole entity for you.

It seems it's still not damaging me. I am at a loss.

[diesieben07]

1 minute ago, WolfHybrid23 said:

It seems it's still not damaging me. I am at a loss.

Post updated code.

[WolfHybrid23]

2 minutes ago, diesieben07 said:

Post updated code.

Oh My Gosh... I am perhaps the biggest idiot to ever mod minecraft. I didn't update my ModItems class to use the SolstoneRock class instead of the ModBlockBase class...
Yep it works now...

Edited October 25, 2018 by WolfHybrid23

[Cadiboo]

You should delete any “base” classes