Jump to content

Problem with reading arrow NBT, also weird entity behavior.


theishiopian

Recommended Posts

I'm trying to get the potion effect attached to a tipped arrow upon impact, but I'm running into two weird, possibly related issues. The first is that all arrows, tipped are not, turn into tipped arrows when fired, with regular arrows giving off blue particles. Second, the nbt tag is completely blank when I read it. 

 

Code:

https://pastebin.com/9ezTvh70

Link to comment
Share on other sites

17 minutes ago, theishiopian said:

The first is that all arrows, tipped are not, turn into tipped arrows when fired, with regular arrows giving off blue particles.

https://bugs.mojang.com/browse/MC-107941

 

18 minutes ago, theishiopian said:

Second, the nbt tag is completely blank when I read it. 

You are doing everything you could do completely wrong. First of all Entity#readEntityFromNBT deserializes the entity in question from the NBT provided. The NBT won't change, since the entity is reading from it, not writing into it. Finally you don't need to mess with NBT at all. Check if the arrow is an instance of EntityTippedArrow(hint: you are already doing it), cast it to one and obtain the potion effect from said arrow. Use reflection if you have to.

Link to comment
Share on other sites

6 minutes ago, theishiopian said:

I tried using reflection initially, but it didnt work when the mod was built.

Additionally, when checking whether the arrow is an instance of EntityTippedArrow, it always returns true, regardless of whether the arrow is tipped or not.

use ReflectionHelper

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

7 minutes ago, theishiopian said:

I tried using reflection initially, but it didnt work when the mod was built.

Then you likely didn't provide the SRG name. Minecraft is obfuscated. It means that the field/class/method names in the compiled game differ from those in the source code. Use ReflectionHelper - it gives you methods which take multiple names for the thing you are searching for. Provide both the MCP(deobfuscated) name and SRG(obfuscated-ish). It's actually a bit more complex(there are three levels of names, Notch, SRG, MCP), you can ask for more if you'd like to know more. You can get the SRG names from mcpbot or from %user_folder%\.gradle\caches\minecraft\de\oceanlabs\mcp\mcp_snapshot\%snapshot_data%\%game_version%\srgs

 

11 minutes ago, theishiopian said:

Additionally, when checking whether the arrow is an instance of EntityTippedArrow, it always returns true, regardless of whether the arrow is tipped or not.

It's because technically all arrows apart from spectral ones are TippedArrows.

Link to comment
Share on other sites

5 minutes ago, theishiopian said:

ok, well what does a field look like in here?

field_XXXXX. The line will also start with the letters FD(FielD) For example, the ones you are interested in:

FD: net/minecraft/entity/projectile/EntityTippedArrow/potion net/minecraft/entity/projectile/EntityTippedArrow/field_184560_g
FD: net/minecraft/entity/projectile/EntityTippedArrow/customPotionEffects net/minecraft/entity/projectile/EntityTippedArrow/field_184561_h

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello all, I recently tried to upgrade my Minecraft mod to version 1.21.3, and I seem to have a problem with the `RenderSystem#setShaderColor` method. Here is how the screen is usually supposed to look like: Here is how it looks at present: To further explain, the note labels atop of the note buttons are colored cyan (here) using `RenderSystem#setShaderColor`. The note buttons and labels get their colors from their native texture - white. This means that even though I set the coloring to apply to the label (top), it is applied to the button (bottom). What I conclude is happening then, in essence, is that this method (at least for my case) does not color the blit after - but rather the blit before..?  This also blocks me from later resetting the shader, as I need to set it back to white before the blitting is done, and not when it's done. So like... what? I've tested this further with other components that require this method, and this preceding-like behavior seems to be pretty consistent for them too.   I should mention that all the snippets I am about to show have all worked in past versions. In my class `ClientUtil`, the following methods are defined: public static void setShaderColor(final Color color, final float alpha) { RenderSystem.setShaderColor( color.getRed() / 255f, color.getGreen() / 255f, color.getBlue() / 255f, alpha ); } public static void setShaderColor(final Color color) { setShaderColor(color, 1); } public static void resetShaderColor() { setShaderColor(Color.WHITE); } //... public static RenderType guiRT(final ResourceLocation loc) { return RenderType.guiTextured(loc); } And here is the snippet from `NoteButtonRenderer#renderNote` using it: // "Note" here refers to those symbols in the middle of a note button protected void renderNote(final GuiGraphics gui, final InstrumentThemeLoader themeLoader) { final int noteWidth = noteButton.getWidth()/2, noteHeight = noteButton.getHeight()/2; ClientUtil.setShaderColor((noteButton.isPlaying() && !foreignPlaying) ? themeLoader.notePressed() : themeLoader.noteReleased() ); gui.blit(ClientUtil::guiRT, noteTextureProvider.get(), noteButton.getX() + noteWidth/2, noteButton.getY() + noteHeight/2, 0, 0, noteWidth, noteHeight, noteWidth, noteButton.getHeight()/2 ); ClientUtil.resetShaderColor(); } You may find the full source here. The odd thing is that Minecraft does seem to use this method the regular way I showed, for instance `SkyRenderer#renderSkyDisc` (not sure if I'l allowed to paste it). Could it be that I'm doing something wrong that leads to this issue..? I'm really stumped on this one.  I couldn't really find any change logs or documentation for this rendering API (even in this Fabric blog post), so I'm sorry if this seems obvious or anything.  Either way, any help would be appreciated.
    • This did work. rip Quark Thank you
    • It says Quark Requires zeta. do i just remove Quark? https://mclo.gs/cq799kI
    • It refers to the mod elenaidodge Backup the world and make a test without it
    • Remove the mod Zeta   If you have further issues, add the new crash-report with sites like https://mclo.gs/ and paste the link to it here
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.