Jump to content

[1.12.2] Item texture is black and purple cube


Bomb787

Recommended Posts

I'm making a mod that adds decorations and I can't seem to get the textures working. When I hold the item I in my hand it shows up as a black and purple square in the middle of my screen with "vmm:LH_new#inventory" in front.

Here is my code:

Common Proxy:

Spoiler

package bomb787.vmm.proxy;

import net.minecraft.item.Item;

public class CommonProxy {
    
    public void registerItemRenderer(Item item, int meta, String id) {
        
    }

}

Client Proxy:

Spoiler

package bomb787.vmm.proxy;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.model.ModelLoader;

public class ClientProxy extends CommonProxy {
    
    public void registerItemRenderer(Item item, int meta, String id) {
        
        ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(item.getRegistryName(), id));
        
    }

}

RegistryHandler:

Spoiler

package bomb787.vmm.util.handlers;

import bomb787.vmm.init.ItemInit;
import bomb787.vmm.util.IHasModel;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@EventBusSubscriber
public class RegistryHandler {
    
    @SubscribeEvent
    public static void onItemRegister(RegistryEvent.Register<Item> event) {
        
        event.getRegistry().registerAll(ItemInit.ITEMS.toArray(new Item[0]));
        
    }
    
    @SubscribeEvent
    public static void onModelRegister(ModelRegistryEvent event) {
        
        for(Item item : ItemInit.ITEMS) {
            
            if(item instanceof IHasModel) {
                
                ((IHasModel)item).registerModels();
                
            }
            
        }
        
    }

}
 

 IHasModel:

Spoiler

package bomb787.vmm.util;

public interface IHasModel {
    
    public void registerModels();
    
}
 

Item Base:

Spoiler

package bomb787.vmm.items;

import bomb787.vmm.Main;
import bomb787.vmm.init.ItemInit;
import bomb787.vmm.proxy.ClientProxy;
import bomb787.vmm.util.IHasModel;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;

public class ItemBase extends Item implements IHasModel{
    
    public ItemBase(String name) {
        setUnlocalizedName(name);
        setRegistryName(name);
        setCreativeTab(CreativeTabs.MATERIALS);
        
        ItemInit.ITEMS.add(this);
    }
    
    @Override
    public void registerModels() {
        
        Main.proxy.registerItemRenderer(this, 0, "inventory");
        
    }
}

ItemInit:

Spoiler

package bomb787.vmm.init;

import java.util.ArrayList;
import java.util.List;

import bomb787.vmm.items.ItemBase;
import net.minecraft.item.Item;

public class ItemInit {
    
    public static final List<Item> ITEMS = new ArrayList<Item>();
    
    public static final Item NewLHLogo = new ItemBase("LH_new");
    
}

 

Am I doing something wrong? I'm following this as the tutorial: 

 

Link to comment
Share on other sites

Well for starters I can tell you that this tutorial is total BS if only because it claims that it works for 1.13 right there in the title... Forge for 1.13 isn't out yet. How can the author be so sure that it will work for forge that isn't out yet is beyound me. Likely it is just there as clickbait. You should never follow a coding tutorial that uses clickbait.

11 minutes ago, Bomb787 said:

Common Proxy:

CommonProxy makes no sense. Proxies exist to separate sided-only code. If your code is common it goes anywhere but your proxy.

 

11 minutes ago, Bomb787 said:

IHasModel

IHasModel is stupid. All items need models, no exception, and nothing about model registration needs access to private/protected data. Register your models directly in the ModelRegistryEvent.

 

12 minutes ago, Bomb787 said:

Item Base

ItemBase is an antipattern. There is already ItemBase, it's called Item.

 

12 minutes ago, Bomb787 said:

public static final Item NewLHLogo = new ItemBase("LH_new");

Don't ever use static initializers. Instantinate your stuff directly in the registry event.

 

Do you see why this tutorial is crap? Literally everything it told you to do is wrong and now you have to redo everything. Congratulations, this tutorial just wasted a bunch of your time!

 

As for the actual issue:

Registry names must be entirely lower-case

Link to comment
Share on other sites

A bit of self-promotion, but I’ve been working on a tutorialish thing for a while now. You might want to use it. You should definitely read through the README at least as it has a bunch of useful information and links to other tutorials. https://github.com/Cadiboo/Example-Mod

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi, I'm asking for your help because I can't figure out how to make it so that when an item is crafted on the Crafting Table, it returns the item to the player's inventory and makes the item lose durability. I've tried looking everywhere without success. Like for the crafting of the cake which returns the empty bucket to the player, but also makes it lose durability.  
    • Description of issue: Tried to run MC client, crashing with java.lang.NoSuchFieldError. I Went into SRG fields, found that f_271198 does exist, but Forge thinks this field does not exist.   Crash Report: ---- Minecraft Crash Report ---- // I let you down. Sorry Time: 2024-02-22 09:21:29 Description: Mod loading error has occurred java.lang.Exception: Mod Loading has failed     at net.minecraftforge.logging.CrashReportExtender.dumpModLoadingCrashReport(CrashReportExtender.java:48) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading}     at net.minecraftforge.client.loading.ClientModLoader.completeModLoading(ClientModLoader.java:119) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraft.client.Minecraft.lambda$new$6(Minecraft.java:611) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}     at net.minecraft.Util.ifElse(Util.java:432) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading}     at net.minecraft.client.Minecraft.lambda$new$7(Minecraft.java:602) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}     at net.minecraftforge.client.loading.ForgeLoadingOverlay.render(ForgeLoadingOverlay.java:146) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading}     at net.minecraft.client.renderer.GameRenderer.render(GameRenderer.java:931) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}     at net.minecraft.client.Minecraft.runTick(Minecraft.java:1250) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}     at net.minecraft.client.Minecraft.run(Minecraft.java:801) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}     at net.minecraft.client.main.Main.main(Main.java:234) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:runtimedistcleaner:A}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {}     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}     at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {}     at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:91) ~[fmlloader-1.20.4-49.0.30.jar:?] {}     at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.lambda$makeService$0(CommonLaunchHandler.java:75) ~[fmlloader-1.20.4-49.0.30.jar:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) ~[modlauncher-10.1.2.jar:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:74) ~[modlauncher-10.1.2.jar:?] {}     at cpw.mods.modlauncher.Launcher.run(Launcher.java:114) ~[modlauncher-10.1.2.jar:?] {}     at cpw.mods.modlauncher.Launcher.main(Launcher.java:73) ~[modlauncher-10.1.2.jar:?] {}     at cpw.mods.modlauncher.BootstrapEntry.main(BootstrapEntry.java:17) ~[modlauncher-10.1.2.jar:?] {}     at net.minecraftforge.bootstrap.Bootstrap.moduleMain(Bootstrap.java:97) ~[bootstrap-2.0.0.jar!/:?] {}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {}     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}     at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {}     at net.minecraftforge.bootstrap.Bootstrap.start(Bootstrap.java:48) ~[bootstrap-2.0.0.jar!/:?] {}     at net.minecraftforge.bootstrap.ForgeBootstrap.main(ForgeBootstrap.java:18) ~[bootstrap-2.0.0.jar!/:?] {} A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- Head -- Thread: Render thread Suspected Mod:      Better Biomes (betterbiomes), Version: 0.1.4.3         at TRANSFORMER/betterbiomes@0.1.4.3/net.crypticverse.betterbiomes.util.BetterBiomeWoodTypes.<clinit>(BetterBiomeWoodTypes.java:8) Stacktrace:     at net.crypticverse.betterbiomes.util.BetterBiomeWoodTypes.<clinit>(BetterBiomeWoodTypes.java:8) ~[betterbiomes-forge-2.1.4.6-1.20.4.jar!/:2.1.4.6-1.20.4] {re:classloading} -- MOD betterbiomes -- Details:     Mod File: /C:/Users/myUser/BetterBiomes-Forge/run/mods/betterbiomes-forge-2.1.4.6-1.20.4.jar     Failure message: Better Biomes (betterbiomes) has failed to load correctly         java.lang.NoSuchFieldError: f_271198_     Mod Version: 0.1.4.3     Mod Issue URL: NOT PROVIDED     Exception message: java.lang.NoSuchFieldError: f_271198_ Stacktrace:     at net.crypticverse.betterbiomes.util.BetterBiomeWoodTypes.<clinit>(BetterBiomeWoodTypes.java:8) ~[main/:?] {re:classloading}     at net.crypticverse.betterbiomes.BetterBiomes.<init>(BetterBiomes.java:55) ~[main/:?] {re:classloading}     at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] {}     at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?] {}     at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] {}     at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) ~[?:?] {}     at java.lang.reflect.Constructor.newInstance(Constructor.java:480) ~[?:?] {}     at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:66) ~[javafmllanguage-1.20.4-49.0.30.jar!/:49.0.30] {}     at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$5(ModContainer.java:125) ~[fmlcore-1.20.4-49.0.30.jar!/:1.0] {}     at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}     at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796) ~[?:?] {}     at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] {}     at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] {}     at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] {}     at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] {}     at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] {} -- System Details -- Details:     Minecraft Version: 1.20.4     Minecraft Version ID: 1.20.4     Operating System: Windows 10 (amd64) version 10.0     Java Version: 17.0.9, Eclipse Adoptium     Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Eclipse Adoptium     Memory: 578548144 bytes (551 MiB) / 1128267776 bytes (1076 MiB) up to 8522825728 bytes (8128 MiB)     CPUs: 20     Processor Vendor: GenuineIntel     Processor Name: 12th Gen Intel(R) Core(TM) i7-12700K     Identifier: Intel64 Family 6 Model 151 Stepping 2     Microarchitecture: Alder Lake     Frequency (GHz): 3.61     Number of physical packages: 1     Number of physical CPUs: 12     Number of logical CPUs: 20     Graphics card #0 name: NVIDIA GeForce RTX 3070 Ti     Graphics card #0 vendor: NVIDIA (0x10de)     Graphics card #0 VRAM (MB): 4095.00     Graphics card #0 deviceId: 0x2482     Graphics card #0 versionInfo: DriverVersion=31.0.15.3699     Memory slot #0 capacity (MB): 16384.00     Memory slot #0 clockSpeed (GHz): 4.80     Memory slot #0 type: Unknown     Memory slot #1 capacity (MB): 16384.00     Memory slot #1 clockSpeed (GHz): 4.80     Memory slot #1 type: Unknown     Virtual memory max (MB): 37373.42     Virtual memory used (MB): 22391.79     Swap memory total (MB): 4864.00     Swap memory used (MB): 95.69     JVM Flags: 1 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump     ModLauncher: 10.1.2     ModLauncher launch target: forge_userdev_client     ModLauncher naming: mcp     ModLauncher services:          / slf4jfixer PLUGINSERVICE          / runtimedistcleaner PLUGINSERVICE          / runtime_enum_extender PLUGINSERVICE          / object_holder_definalize PLUGINSERVICE          / capability_token_subclass PLUGINSERVICE          / accesstransformer PLUGINSERVICE          / eventbus PLUGINSERVICE          / mixin PLUGINSERVICE          / fml TRANSFORMATIONSERVICE          / mixin TRANSFORMATIONSERVICE      FML Language Providers:          lowcodefml@49         minecraft@1.0         javafml@49.0.30     Mod List:                                                            |Minecraft                     |minecraft                     |1.20.4              |COMMON_SET|Manifest: NOSIGNATURE         TerraBlender-forge-1.20.4-3.3.0.12_mapped_official|TerraBlender                  |terrablender                  |3.3.0.12            |COMMON_SET|Manifest: NOSIGNATURE                                                           |Forge                         |forge                         |49.0.30             |COMMON_SET|Manifest: NOSIGNATURE         betterbiomes-forge-2.1.4.6-1.20.4.jar             |Better Biomes                 |betterbiomes                  |0.1.4.3             |ERROR     |Manifest: NOSIGNATURE         Notebook-api-forge-1.20.4-1.1.0.4_mapped_official_|Notebook                      |notebook                      |1.1.0.4             |COMMON_SET|Manifest: NOSIGNATURE     Crash Report UUID: ad19c004-038a-4777-adbc-0504acf15d93     FML: 0.0     Forge: net.minecraftforge:49.0.30
    • Some kind of issue/conflict with eureka - also try other builds of it
    • doesn't work But after trying to make a boat with Valkyrien Skies, I got this : https://pastebin.com/bxnDcHr3 maybe the problem comes from valkyrien skies itself ?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.