Blockstates Property for a Block

[Siqhter]

Ok, thanks that was very helpful. Everything in that post however I was already implementing, except one method, but I think it's still not syncing. Is that everything I have to do in the TE?

If I'm pulling the color from the TE

Spoiler

@Override
public IBlockState getActualState(IBlockState state, IBlockAccess worldIn, BlockPos pos) {
    super.getActualState(state, worldIn, pos);
    TileEntityCounter tileEntity = (TileEntityCounter) worldIn.getTileEntity(pos);
    EnumDyeColor color = tileEntity.getColor();

    return state.withProperty(COLOR, color);
}

Then I don't know how to get the data for each color, it just returns what I defined color as

Spoiler

private EnumDyeColor color = EnumDyeColor.RED;

 

[Siqhter]

This is everything updated in the tileentity class. I guess I'm just not understanding something.

Spoiler

private EnumDyeColor color = EnumDyeColor.RED;

public EnumDyeColor getColor()
{
    return this.color;
}

public void setColor(EnumDyeColor color)
{
    this.color = color;
    this.markDirty();
}

@Override
public void readFromNBT(NBTTagCompound compound) {
    super.readFromNBT(compound);
    this.color = EnumDyeColor.byMetadata(compound.getInteger("color"));
}

@Override
public NBTTagCompound writeToNBT(NBTTagCompound compound) {
    super.writeToNBT(compound);
    compound.setInteger("color", this.color.getMetadata());
    return compound;
}

private void notifyBlockUpdate() {
    final IBlockState state = getWorld().getBlockState(getPos());
    getWorld().notifyBlockUpdate(getPos(), state, state, 3);
}

@Override
public void markDirty() {
    super.markDirty();
    notifyBlockUpdate();
}

public NBTTagCompound getUpdateTag()
{
    return this.writeToNBT(new NBTTagCompound());
}

public SPacketUpdateTileEntity getUpdatePacket()
{
    return new SPacketUpdateTileEntity(this.pos, 11, this.getUpdateTag());
}

@Override
public void onDataPacket(final NetworkManager net, final SPacketUpdateTileEntity pkt) {
    readFromNBT(pkt.getNbtCompound());
    notifyBlockUpdate();
}

@Override
public boolean shouldRefresh(final World world, final BlockPos pos, final IBlockState oldState, final IBlockState newSate) {
    return oldState.getBlock() != newSate.getBlock();
}

 

[Cadiboo]

3 hours ago, Siqhter said:

this.color = EnumDyeColor.byMetadata(compound.getInteger("color"));

what if the compound doesn't have the "color" integer?

3 hours ago, Siqhter said:

public NBTTagCompound getUpdateTag() { return this.writeToNBT(new NBTTagCompound()); } public SPacketUpdateTileEntity getUpdatePacket() { return new SPacketUpdateTileEntity(this.pos, 11, this.getUpdateTag()); }

Why aren't these @Overrides?

 

Where are you actually calling the sync from?
This is pretty much just another bunch of reasons to use seperate blocks

[Siqhter]

12 hours ago, Cadiboo said:

This is pretty much just another bunch of reasons to use seperate blocks

I know, but I had used a tileentity to store facing values, and I'm just confused on how to literally swap the color and facing properties, not saying I'm going to keep it this way, just want to finish it how I started it.

12 hours ago, Cadiboo said:

what if the compound doesn't have the "color" integer?

Could you explain what you mean here?

[Siqhter]

Here is the latest block code

Spoiler

public EnumDyeColor getColor(final IBlockAccess world, final BlockPos pos)
{
    final TileEntityCounter tileEntity = getTileEntity(world, pos);
    return tileEntity != null ? tileEntity.getColor() : EnumDyeColor.RED;
}

public void setColor(final IBlockAccess world, final BlockPos pos, final EnumDyeColor color)
{
    final TileEntityCounter tileEntity = getTileEntity(world, pos);
    if (tileEntity != null) {
        tileEntity.setColor(color);
    }
}

@Override
public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
    setColor(worldIn, pos, getColor(worldIn, pos));
}

@Override
public IBlockState getActualState(IBlockState state, IBlockAccess worldIn, BlockPos pos) {
    return state.withProperty(COLOR, getColor(worldIn, pos));
}

 

[Siqhter]

Sorry I had changed that method around before and I forgot it wasn't doing anything. That works now, just wondering why this method, when dye is applied, changes the block to a random color and not the corresponding one.

Spoiler

@Override
public boolean onBlockActivated(final World worldIn, final BlockPos pos, final IBlockState state, final EntityPlayer playerIn, final EnumHand hand, final EnumFacing side, final float hitX, final float hitY, final float hitZ)
{
    final ItemStack heldItem = playerIn.getHeldItem(hand);
    TileEntity tileEntity = worldIn.getTileEntity(pos);
    ItemStack stack = playerIn.getHeldItem(hand);
    int meta = stack.getMetadata();

    if (tileEntity instanceof TileEntityCounter) {
        TileEntityCounter tileEntityCouch = (TileEntityCounter) tileEntity;
        if (!heldItem.isEmpty()) {
            if (heldItem.getItem() instanceof ItemDye) {
                ((TileEntityCounter) tileEntity).setColor(EnumDyeColor.byMetadata(meta));
                if (!playerIn.isCreative()) {
                    heldItem.shrink(1);
                }
                return true;
            }
        }
    }
    return false;
}

 

[Siqhter]

1 hour ago, diesieben07 said:

The dye item uses a different metadata value. You need to use EnumDyeColor.byDyeDamage.

Thank you.

[Siqhter]

If tile entity is not saving the color on quitting the map, would that be a sync issue? Not sure why it just started.

Nevermind.

Edited December 29, 2018 by Siqhter

[Siqhter]

However, would you know what I would need to use to get the correct drop? I can't seem to use byDyeDamage.

[Siqhter]

It worked when I was storing color in metadata, but not now that it's store in a TE.

@Override
public void getDrops(NonNullList<ItemStack> drops, IBlockAccess world, BlockPos pos, IBlockState state, int fortune) {
    drops.add(new ItemStack(this, 1, this.getMetaFromState(state)));
}

[Siqhter]

3 minutes ago, diesieben07 said:

Well, yes, you now don't store anything in the metadata, so calling getMetaFromState does not do anything.

I know, I was just showing you what method I was using previously and I'm wondering how to update it. I tried calling getColor from the tileentity, but still stuck.

[Siqhter]

30 minutes ago, diesieben07 said:

Well, item metadata can hold a full 16 bits

So, as opposed to using a tileentity?

[Siqhter]

3 hours ago, diesieben07 said:

Tile entities are for blocks. Not items.

Oh I see what you mean. When I do use metadata to get the color for the block drop, it returns a random color, not the correct one. I fixed this earlier with byDyeDamage, but I don't know how to do it in this context.

Edited December 30, 2018 by Siqhter

[Cadiboo]

How are you getting the meta now?

[Siqhter]

15 minutes ago, Cadiboo said:

How are you getting the meta now?

I'm storing the color property in a tileentity. But I don't know if that's what you're asking for. This works fine for getting the block's correct color state when placed.

Spoiler

public EnumDyeColor getColor(final IBlockAccess world, final BlockPos pos)
{
    final TileEntityColored tileEntity = getTileEntity(world, pos);
    return tileEntity != null ? tileEntity.getColor() : EnumDyeColor.RED;
}

public void setColor(final IBlockAccess world, final BlockPos pos, final EnumDyeColor color)
{
    final TileEntityColored tileEntity = getTileEntity(world, pos);
    if (tileEntity != null) {
        tileEntity.setColor(color);
    }
}

@Override
public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
    int meta = stack.getMetadata();
    setColor(worldIn, pos, EnumDyeColor.byMetadata(meta));
}

@Override
public IBlockState getActualState(IBlockState state, IBlockAccess worldIn, BlockPos pos) {
    return state.withProperty(COLOR, getColor(worldIn, pos));
}