SoundTypes

[wsman217]

Ok so I have spent the past 4-5 hours working on trying to make a custom sounds type. I have found out how to do it with SoundEvents that are already in the game but I want to take it 1 step farther and put in my own SoundEvents. I have a class that makes the sounds events and all but for some reason when I try and use my SoundType for example as the setSoundType of a block, the game crashes and I recieve a null pointer exception. I know they are not null because I add a println that printed both the SoundEvent and the SoundType. If anyone has any kind of insight on this problem I would love to hear it because this is making me go insane.

[desht]

Would need to see your code, but custom SoundEvent objects should be registered via a registry event, similar to custom Block or Item objects.  As an example: https://github.com/TeamPneumatic/pnc-repressurized/blob/master/src/main/java/me/desht/pneumaticcraft/lib/Sounds.java (the RL() method in there is just a convenience method to get a ResourceLocation with the mod's domain).  See also https://mcforge.readthedocs.io/en/latest/effects/sounds/.

 

Note that SoundType and SoundEvent are not the same thing, but you seem to be conflating them a bit here.

[wsman217]

Sorry i forgot to post the code last night i will do that in a bit, i am registering the SoundEvents and the SoundTypes require SountType(double, double, SoundEvent, SoundEvent, SoundEvent, SoundEvent, SoundEvent, float, float, boolean)

[wsman217]

Here is the link to my GitHub with all of my code on it. Sorry it isn't very clean.

[V0idWa1k3r]

To register custom sounds you also need a sounds.json in your assets/modid folder like I do here. You can read up on it's format more here, on the official minecraft wiki.

You will of course need to register the SoundEvent within the appropriate RegistryEvent similar to how I do here. Make sure your registry name matches the one you have given to the sound in the sounds.json file.

To actually obtain a reference to your SoundEvent to use it later(to play it for example) you would use ObjectHolders like I do here.

After that you should be able to play your sound just fine similar to how I do here.

 

As for your repo:

Quote

ForgeRegistries.SOUND_EVENTS.register(sound);

Don't do this. Use the registry provided to you by the event.

 

https://github.com/wsman217/Learning-Mod/blob/master/src/main/java/com/wsman217/learningmod/init/ModBlocks.java#L15

https://github.com/wsman217/Learning-Mod/blob/master/src/main/java/com/wsman217/learningmod/init/ModItems.java#L40

Don't use static initializers. Instantinate your stuff directly in the appropriate RegistryEvent.

 

https://github.com/wsman217/Learning-Mod/blob/master/src/main/java/com/wsman217/learningmod/blocks/BlockBase.java

BlockBase/ItemBase/XBase is an antipattern. There is already a BlockBase, it's called Block.

 

https://github.com/wsman217/Learning-Mod/blob/master/src/main/java/com/wsman217/learningmod/proxy/CommonProxy.java

CommonProxy makes no sense. Proxies exist to separate sided-only code. If your code is common it goes anywhere but your proxy.

 

Quote

serverSide = Reference.COMMON_PROXY_CLASS

This makes even less sense. A server proxy provides noop implementations for client-only methods or invokes methods that would crash the physical client. A common proxy by definition can't be your server proxy.

 

https://github.com/wsman217/Learning-Mod/blob/master/src/main/java/com/wsman217/learningmod/util/IHasModel.java

IHasModel is stupid. All items need models, no exception, and nothing about model registration requires access to private/protected data. Register your models in the ModelRegistryEvent directly.

 

https://github.com/wsman217/Learning-Mod/blob/master/src/main/java/com/wsman217/learningmod/sounds/SoundTypes.java#L13

And here is the cause of your issue - the dreaded static initializers. By the time this is constructed your SoundEvent is still null, hence your crash.

[wsman217]

Ok so what I am understanding is not to use statics, the BlockBase class that is in there is completely useless, and the proxy stuff is also useless, and that the cause of the crash is because I declared some stuff as static? Sorry if I misunderstood some of that there is a lot to take in there. Thank you for taking the time to reply.

[V0idWa1k3r]

5 minutes ago, wsman217 said:

the cause of the crash is because I declared some stuff as static?

No, the cause of the crash is because the object is instantinated before your sound event is. It can be static all you want, it's the instantination that matters. Hence the name - static initializer.

7 minutes ago, wsman217 said:

he BlockBase class that is in there is completely useless

That is correct.

 

7 minutes ago, wsman217 said:

the proxy stuff is also useless

The proxy in your case is useless but in general case it isn't, you are just doing it wrong. Don't use a CommonProxy, use an interface, like an IProxy as the official docs tell you to do.

[wsman217]

Thank you for clarifying that for me so how do I instantiate the sound event before the object. Sorry this is probably a really stupid question I am still just fairly new to modding and Java is a very large language with many things that I still don't understand.

[V0idWa1k3r]

5 minutes ago, wsman217 said:

Thank you for clarifying that for me so how do I instantiate the sound event before the object.

This question answers itself. You do so by instantinating the SoundEvent first, then the SoundType. I don't think I could explain this in a more obvious way, sorry.

[wsman217]

Ok so looking through your code I don't understand what ExPRegistryNames is or where it comes from could you explain that to me?

[V0idWa1k3r]

https://github.com/V0idWa1k3r/ExPetrum/blob/master/src/main/java/v0id/api/exp/data/ExPRegistryNames.java

It's just a collection of strings that are made into ResourceLocations on demand.