Item Not Rendering

[DiamondMiner88]

I'm following this tutorial, I did everything that he did before the block part, i checked the image that its a 16x16 pixel img, but my item is still not rendering but there are no errors in the log, like forge is detecting it but not displaying it for some reason.

Harry Talks

Github

[DiamondMiner88]

So the Code style: I have no idea how to avoid the IHasModel. The Common Proxy: in 1.9  i made a mod with a client/server proxy, no common but im not sure if that same method will work in 1.12

How do I the the registry beside the ForgeRegistryEvent?

I compared my other working mod to this one, the registry looks to me exactly the same, here's the working one: CharacterMod

Where do i call the registry from?

Edited December 27, 2018 by DiamondMiner88

[DiamondMiner88]

I gave up on that tutorial so ill try to work with the CharacterMod, that one I already have working. Where do i change the static initializers? I tried making onItemRegister non-static but it didn't even register the items. The proxies: is this how you do it? CrayfishTM Only I don't know what to put instead of ModItems.registerRenders() in ClientProxy. And i still dont get what you mean by:

  On 12/27/2018 at 6:24 PM, diesieben07 said:

Subscribe to ModelRegistryEvent. In there go through all your items and call ModelLoader.setCustomModelResourceLocation (or whatever else you might need to register the model). There is no action needed in the Item class.

Expand  

In what class do i subscribe to ModelRegistryEvent and call ModelLoader.setCustomResourceLocation?

[DiamondMiner88]

And in RegistryHandler it says:

for (Item item : ModItems.ITEMS) {
            if (item instanceof IHasModel) {
                ((IHasModel)item).registerModels();
            }
        }

what do i put instead of the

item instanceof IHasModel

 

[DiamondMiner88]

So do i just remove

for (Item item : ModItems.ITEMS) {
            if (item instanceof IHasModel) {
                ((IHasModel)item).registerModels();
            }
        }

Because doesn't it serve a point? It registersModels, right?

[DiamondMiner88]

Wait i dont get it... how do i subscribe from the client proxy class what annotation do i use? I have no idea how subscribing works. I made the ServerProxy but in the Client i already have

public void registerItemRenderer(Item item, int meta, String id) {
        ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(item.getRegistryName(), id));
    }

this i what is my ClientProxy class is:

package com.diamondminer88.mod.character.proxy;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.model.ModelLoader;

public class ClientProxy implements CommonProxy {
    public void registerItemRenderer(Item item, int meta, String id) {
        ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(item.getRegistryName(), id));
    }
    public void init() {
        ModelLoader.setCustomModelResourceLocation();
    }

}

I updated my Github too.

[DiamondMiner88]

Would I remove the method registerItemRenderer() or just subscribe it to that and what would i do with the init() method? The subscribing still makes no sense for me. What purpose does it serve?

Edited December 29, 2018 by DiamondMiner88

[DiamondMiner88]

Ok so i get what subscribing is but how do i subscribe to ModelRegistryEvent? And do i call ModelLoader from my RegistryHandler or my ClientProxy? i also added in my Main.init() proxy.init();

[DiamondMiner88]

  On 12/30/2018 at 1:38 AM, diesieben07 said:

  On 12/30/2018 at 1:36 AM, DiamondMiner88 said:

i also added in my Main.init() proxy.init();

Expand  

Why? 

Expand  

Wait so you're saying that that's not needed to call the proxies? Does this call them at the right time?

@SidedProxy(clientSide = Reference.CLIENT_PROXY, serverSide = Reference.SERVER_PROXY)
public static CommonProxy proxy;

 

  On 12/30/2018 at 1:38 AM, diesieben07 said:

  On 12/30/2018 at 1:36 AM, DiamondMiner88 said:

Ok so i get what subscribing is but how do i subscribe to ModelRegistryEvent?

Expand  

Like any other event.

Expand  

Other subscribing events i see are like this

	@SubscribeEvent
    public static void onBlockRegister(RegistryEvent.Register<Block> event) {
        event.getRegistry().registerAll(ModBlocks.BLOCKS.toArray(new Block[0]));
    }

Should i do @SubscribeEvent with WHAT underneath?

[Eiachh]

I think even I can help here so I will try

so basically to make everything simpler for you
First you want a registry_handler which registers the items through Forge( no not the textures just the item "unlocalizedname" and "registryName") and it should look something similar to this
 

@EventBusSubscriber  
public class RegistryHandler {

	
	
    @SubscribeEvent //for @SubscribeEvent you would have to register your class BUT because of the @EventbusSubscriber you don't have to if i am correct
    public static void registerItemsasdasd(Register<Item> event) {


        final Item[] items = {
                new ItemBasic("BasicStar","basic_star_item"),  //the item that you are making (you have the same class in your git so this should be ok
        };
        event.getRegistry().registerAll(items); //this will use the register to tell the game that this thing even exceists
    }

}

Then if you registered your items you need some way to tell that you want a model or picture or whatever for your item so you do this
 

@EventBusSubscriber(Side.CLIENT)
public class ModelRegistryHandler {
 
    @SubscribeEvent
    public static void registerModels(ModelRegistryEvent event) {
        registerModel(TutorialItems.BASIC_STAR_ITEM);  //here comes the problem. You need a reference for your item(basically you could use just a "registryName" without getting the item reference but you will need later anyways
	}
	
	private static void registerModel(Item item) {
        ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));
    }
}

To get your item reference one way is to do this:

@ObjectHolder(MainModpls.MODID)
public class TutorialItems {
 
    public static final Item BASIC_STAR_ITEM = null;
//This will just simply look through items thats in the namespace of MainModpls.MODID and if it finds a match it fills the value of your variable in more easier way: you I constructed the basicItem with the registryName=basic_star_item(small letters and theese things _ ) and if it finds that name here with CAPITALS then it sets the value
}

To be honest if you implement theese things it should work just be aware from here for the "picture" of your item it will look for a .json file in: assets.yourMODID.models.item.registryNameofyouritem.json
json contains this:
 

{
    "parent": "item/generated",
    "textures": {
        "layer0": "yourMODID:items/name_of_the_picture_without_the_.png_at_the_and"
    }
}

and it looks for the picture which is .png here:
assets.yourMODID.textures.items.yourpicture.png

YES ITEMS NOT ITEM AND IN MODELS YES ITEM NOT ITEMS
I hope from here you can decode what jumps to where and what happens cause I am sure nobody will give a more detailed explanation here

[DiamondMiner88]

Sorry for the very late reply, (I started to play other games *cough cough fortnite* and forgot about MC but got back to finishing my mod.) I have one more question. The ItemBasic class contains what? I am trying to register it but have no idea what to put instead of the previous version with the IHasModel. I updated my Github. Here

[DavidM]

Remember how in the ModelRegistry event subscriber you registered the models of items like:

ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));

 

Well, just invoke the method with each item in your mod instead of checking for IHasModel first.

 

EDIT: Your current code should be fine. Just remove all references of IHasModel.

 

  On 3/31/2019 at 4:39 AM, DiamondMiner88 said:

ItemBasic class contains what?

Expand  

You should not be using anything like ItemBase of BlockBase (abusing inheritance).

Instantiate, add to your modItems, and register your items in the subscriber for RegistryEvent.Register<Item>; there is no need for an ItemBase.

Edited March 31, 2019 by DavidM

[DiamondMiner88]

Sorry i don't know what you mean by

  On 3/31/2019 at 5:24 AM, DavidM said:

invoke the method

Expand  

English is not my first language so i don't understand what that means.

Also in my ItemBase it says

ModItems.ITEMS.add(this);

and

@Override
public void registerModels() {
    Main.proxy.registerItemRenderer(this, 0, "inventory");
}

Since for the adding to the array one i already have a another one, do i just remove it?

The registerModels() I'm pretty sure i just remove it since i already have

@SubscribeEvent
public static void registerModels(ModelRegistryEvent event) {
    for (Item item : ModItems.itemArray) {
        registerModel(item);
    }
}

private static void registerModel(Item item) {
    ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));
}

In my ModelRegistryHandler.

If i were to avoid ItemBasics, etc. how would i do that? What about changing options for it like

setCreativeTab(TabCharacterMod.TAB_CHARACTER_MOD);

Isin't what i already have the same as what you said?

Edited March 31, 2019 by DiamondMiner88

[DavidM]

  On 3/31/2019 at 5:24 AM, DavidM said:

ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));

Expand  

This line of code registers the model for the item.

The “item” variable is an instance of an Item.

 

In order to register the models for all your items, run the line of code above for each one of your item; for each item, replace the “item” variable with that item.

 

  On 3/31/2019 at 2:35 PM, DiamondMiner88 said:

invoke the method

Expand  

This basically means “calling the method” (or running the method, if that’s easier to understand).

Edited March 31, 2019 by DavidM

[DiamondMiner88]

But I already have called

ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));

As i see, I made an item in ModItems and added it to the itemArray. Then in ModelRegistryHandler for every object in the array it calls that piece of code.

Since i already called that i remove

ModItems.ITEMS.add(this);

and

@Override
public void registerModels() {
    ModelRegistryHandler.//Here
}

Right?

And in my ClientProxy I have

@SubscribeEvent
public void registerItemRenderer(Item item, int meta, String id) {
    ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(item.getRegistryName(), id));
}

I remove that too since i already registered the model client-side?

[DavidM]

  On 3/31/2019 at 2:35 PM, DiamondMiner88 said:

If i were to avoid ItemBasics, etc. how would i do that? What about changing options for it like

setCreativeTab(TabCharacterMod.TAB_CHARACTER_MOD);

Isin't what i already have the same as what you said?

Expand  

You can either 1) Do it in the constructor of your item or 2) Call the method son your item when you first instantiate it in Register<Item> subscriber.

 

  On 3/31/2019 at 3:14 PM, DiamondMiner88 said:

@Override public void registerModels() { ModelRegistryHandler.//Here }

Expand  

There is no need to put the method in your item class; all item models should be registered that way, and registering the model does not need any private data.

Therefore, just call

registerItemRenderer

for each of your item in the subscriber for ModelRegistryEvent.

 

In addition, the tutorial you are following has a lot of bad practices.

You might want to take a look at Cadiboo's example mod to learn about good practices for modding: https://github.com/Cadiboo/Example-Mod

Edited March 31, 2019 by DavidM

[DiamondMiner88]

Ur confusing me. Where do i call

  On 3/31/2019 at 3:24 PM, DavidM said:

registerItemRenderer

Expand  

from?

From what you said i understand that i should call registerItemRender in my ClientProxy from registerModels in my ModelRegistryHandler. Right?

And i think ill stick with ItemBases for now until i have the rest of the puzzle solved.

Thanks for linking me Cadiboo's mod though ill look through it.

Edited March 31, 2019 by DiamondMiner88