Jump to content

Recommended Posts

Posted

Hello, I have made a custom TNT with a custom explosion, but I wanted the explosion to be huge, like 1,000,000+ blocks. It works fine but obviously there is a huge lag when detonating, I was wondering how I could add a very slight delay between each time a block is removed. Here is my code: 

static int tick = 0;
    @SubscribeEvent
	public static void onClientTick(TickEvent.ClientTickEvent event) {
    	
	if(tick == 80) {
	
		
	System.out.print("DELAY");
	tick = 0;
	
    }
	 tick++;
    }
    	

    /**
     * Does the first part of the explosion (destroy blocks)
     */
    @Override
    public void doExplosionA()
    {
    	
        Set<BlockPos> set = Sets.<BlockPos>newHashSet();
       
       long time = world.getWorldTime();
       int blocksDestroyed = 0; 
       int radius = this.size;
       int center = radius / 2;
       
       
    	   for (int j = center - radius; j < center + radius; j++)
        {
            for (int k = center - radius; k < center + radius; k++)
            {
                for (int l = center - radius; l < center + radius; l++)
                {
                	
                	double distSq = (j-center) * (j-center) + (k-center) * (k-center) + (l-center) * (l-center);
                	
                	
                	if(distSq <= (radius) * (radius)) {
                		
                		BlockPos pos = new BlockPos(x + j - center, y + k - center, z + l - center);
                		if(world.getBlockState (pos) != Blocks.BEDROCK.getDefaultState()){
                			
                			
                			world.setBlockState(pos, Blocks.AIR.getDefaultState());
                			
                			

I added the ClientTickEvent, because I thought it would be the way to go, but cant figure out how to add the delay after each block gets removed. Any help is appreciated, thanks.

Posted (edited)
  On 2/3/2019 at 10:02 PM, funsize888 said:

1,000,000+ blocks

Expand  

This isn’t viable. I would say 1024 blocks (16 chunks) is the absolute max, and I would reccomend something like 64-128.

You need to subscribe to the server tick event. I would do this by keeping track of what position I was at, and effectively distributing the nested for loop over multiple ticks. Remember to keep track of which explosion you’re doing

Edited by Cadiboo

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
  On 2/4/2019 at 1:48 AM, Cadiboo said:

This isn’t viable. I would say 1024 blocks (16 chunks) is the absolute max, and I would reccomend something like 64-128.

You need to subscribe to the server tick event. I would do this by keeping track of what position I was at, and effectively distributing the nested for loop over multiple ticks. Remember to keep track of which explosion you’re doing

Expand  

What do you mean by keep track of the position im at? or which explosion, its only one explosion.

Posted
  On 2/4/2019 at 3:14 AM, funsize888 said:

What do you mean by keep track of the position im at?

Expand  

I would turn the for loop into something that executes every tick.

 

  On 2/4/2019 at 3:14 AM, funsize888 said:

which explosion, its only one explosion.

Expand  

What if another explosion happens while the first is still happening? Because you aren’t doing everything all at once, other stuff can happen in the meantime

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
  On 2/4/2019 at 4:54 AM, Cadiboo said:

I would turn the for loop into something that executes every tick.

 

What if another explosion happens while the first is still happening? Because you aren’t doing everything all at once, other stuff can happen in the meantime

Expand  

ok so now I have this: 

 static int tick = 0;
    static int timer = 0;
    @SubscribeEvent
	public static void onServerTick(TickEvent.ServerTickEvent event) {
    	
    	if(tick == 40) {
    		
    		
    		
    		tick = 0;
    		timer++;
    		System.out.print(timer);
    		if(timer >= 20) {
    			timer = 0;
    		}
    	}tick++;
    }
    
    		
    		

    
    	

    /**
     * Does the first part of the explosion (destroy blocks)
     */
    @Override
    public void doExplosionA()
    {
    	
        Set<BlockPos> set = Sets.<BlockPos>newHashSet();
        Set<IBlockState> states = Sets.<IBlockState>newHashSet();
       
       long time = world.getWorldTime();
       int blocksDestroyed = 0; 
       int radius = this.size;
       int center = radius / 2;
       
       if(timer == 20) {
    	   for (int j = center - radius; j < center + radius; j++)
        {
            for (int k = center - radius; k < center + radius; k++)
            {
                for (int l = center - radius; l < center + radius; l++)
                {
                	
                	double distSq = (j-center) * (j-center) + (k-center) * (k-center) + (l-center) * (l-center);
                	
                	
                	if(distSq <= (radius) * (radius)) {
                		
                		BlockPos pos = new BlockPos(x + j - center, y + k - center, z + l - center);
                		if(world.getBlockState (pos) != Blocks.BEDROCK.getDefaultState()){
                			
                			
                			
                			
                			world.setBlockToAir(pos);
                			timer = 0;
                			
                				
                				blocksDestroyed++;
                				System.out.println(timer);
                				
               			
                		}
                	}
                }
                	
            }
            
        }
            
        }

but obviously the if statement will only run if the timer = 20. So the code isnt run at all. how do I wait for the timer to = 20?

Posted

What is that code meant to do? It’s not valid java

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted (edited)
  On 2/5/2019 at 4:58 AM, Cadiboo said:

What is that code meant to do? It’s not valid java

Expand  

That’s the part  struggling with, I’m not sure how I would delay the for loop for a certain amount of ticks. 

 

Maybe I could save all the blocks from the loop and place them one by one with a delay?

Edited by funsize888
Posted

You need to find a way to distribute your logic over multiple ticks. Pre-generating a list of coordinates would work, but would use up massive amounts of memory. I would distribute my loop over multiple ticks

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
    • Crashes the server when trying to start. Error code -1. Log  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.