Jump to content

[Solved] [1.12.2] Placing structures in ChunkGenerator causes "cascading worldgen" errors


MajikalExplosions

Recommended Posts

Hi!  I'm new to MC modding, so I'm not too sure whether the format of this post is correct or not - if it isn't, please let me know how to change it in the future.

 

I'm working on a mod that generates one structure (16*y*16, y is anywhere between 4 and 32) in every chunk(it's supposed to completely fill the chunk on the surface from 0,0 to 16,16), which is why it's 16 blocks wide and 16 blocks long).  The structures are in .nbt files that load like they're supposed to and show up in-game - sometimes.  However, the structures aren't showing up in every chunk; rather, they show up only close to the chunk 0, 0 and are randomly scattered all over.  When I teleport myself over, it says that my mod is causing "cascading worldgen" issues.  I'm pretty sure it's because my structures aren't spawning in the chunks like they're supposed to and instead are overlapping into other chunks.  My problem is that I don't know why this happens and how to fix it.

 

Below is the code snippet from my ChunkGenerator class (yes, it implements IChunkGenerator).  I overrode the generateStructures function and added my own code.  I am aware that this is probably a terrible way to do this (it's probably in the wrong function and class), but I'm not sure how to make it better.  Can I have some advice?

 

@Override
    public boolean generateStructures(Chunk chunkIn, int x, int z) {//chunkIn isn't used.
    	PlacementSettings ps = new PlacementSettings().setRotation(BuildingGenerator.getRotation(x, z));//getRotation returns a random Rotation (EX Rotation.NONE, Rotation.CLOCKWISE_90)
        buildingGenerator.getBuilding(x, z).addBlocksToWorldChunk(world, new BlockPos(x * 16, BUILDING_Y_VALUE, z * 16), ps);//buildingGenerator.getBuilding(x, z) returns an object of class Template that is read from a .nbt file created by a structure block.
    	return false;//It crashes when I return true...?  I'm not sure why.
	}

 

If you need more clarification, I can always provide more information.  The crash log is attached.  Thanks in advance!

 

Edited by MajikalExplosions
Link to comment
Share on other sites

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Hi!  I have already seen that article on Reddit, but I'm not sure how I should go about carrying out the solution.  The Reddit post says:

Quote

The solution is often very simple, they just need an offset. 

However, I don't know how to add the offset.  Do I just rewrite the code to generate

buildingGenerator.getBuilding(x, z).addBlocksToWorldChunk(world, new BlockPos(x * 16 - 8, BUILDING_Y_VALUE, z * 16 - 8), ps);//buildingGenerator.getBuilding(x, z) returns an object of class Template that is read from a .nbt file created by a structure block.

I've tried that before, but it still doesn't work.  It still prints the error, and behaves just like how it was without the change.  Hints, maybe?  Thank you for taking your time to help me.

 

 

 

P.S.: Here's the error in case it helps:

[Server thread/WARN] [FML]: Tutorial Dimension loaded a new chunk [33, 20] in dimension 0 (overworld) while populating chunk [35, 22], causing cascading worldgen lag.

Link to comment
Share on other sites

On 2/5/2019 at 8:32 PM, MajikalExplosions said:

int x, int z

You see these? 

Have you tried adding 8 to them before you use them? No? Why not?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

On 2/6/2019 at 7:16 PM, MajikalExplosions said:

x * 16

Are you sure about this? I thought x and z were already block coordinates.
Also, you should use <<4 to avoid issues with negative values being incorrectly rounded when dealing with chunk<->block conversions.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Turning the Tables: My Journey to Reclaim Stolen Bitcoins with Expert Help. When my Bitcoin wallet was hacked and my entire cryptocurrency portfolio was stolen, I felt utterly devastated and hopeless. Having worked hard to build up my digital assets, the sudden loss was gut-wrenching. It felt like my financial future had been ripped away in an instant, leaving me overwhelmed by a sense of betrayal and despair. In my search for help, I discovered TECH CYBER FORCE Recovery, a renowned cybersecurity firm specializing in cryptocurrency recovery. I was met with professionalism and empathy from my first contact with them. The team demonstrated a steadfast commitment to helping me retrieve my stolen Bitcoins. They understood the emotional toll of my situation and approached my case with genuine concern. TECH CYBER FORCE Recovery swung into action immediately, leveraging its extensive expertise in blockchain forensics and hacker tracking techniques. Their process was meticulous. They analyzed my transaction history, followed the digital trail left by the hackers, and worked diligently to pinpoint the location of the stolen funds. I was impressed by their technical prowess; they employed advanced cryptographic methods and strategic negotiations with the perpetrators, all while keeping me informed about their progress. The recovery process was complex and fraught with challenges. However, the tenacity displayed by the team was truly awe-inspiring. They navigated cryptocurrency crime's murky and ever-evolving landscape with skill and determination. After a series of strategic moves, they managed to recover the majority of my Bitcoins successfully.  
    • I removed giacomos_hud, oculus, (dont know what you mean with iris), enhanced_boss_bars, epicfight and essential.  Server still doesnt want to boot. new logs after removing: https://pastebin.com/LuM2PFtN I dont quite understand the "server side" and "client side" difference..
    • There are client side only mods in your server files   Remove giacomos_hud, oculus, iris, enhanced_boss_bars and epicfight You can keep these mods in your client Maybe also remove essentials
    • Here is my Log with java 17: https://pastebin.com/RPdWSjwq
    • Been working on creating a server for this mod, but i keep getting this error over and over again.  I have tried updating/changing the Forge launcher, Removing/replacing the ops.json and whitelist.json folders, and removing certain mods. Crash report log: https://pastebin.com/Bu046cVq Debug.log https://pastebin.com/7hKm40ke Latest.log https://pastebin.com/nCRLUH3b any help would be great thanks!
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.