Inconsistency in styling

[DutchM]

More of a ... idk what to call it not really bug but weirdness in the code... report than a suggestion, but I don't know where else to put it. I don't quite get why EntityPlayer#openGui deviates from Java styleguides, even though the rest of the code seems to follow them neatly. To clarify: GUI is an acronym and thus should be spelled in all caps like this: EntityPlayer#openGUI, not EntityPlayer#openGui. I don't understand why this method specifically deviates from this, especially since other abbreviations I have encountered in the code are fully capitalized.

[larsgerrits]

3 hours ago, DutchM said:

More of a ... idk what to call it not really bug but weirdness in the code... report than a suggestion, but I don't know where else to put it. I don't quite get why EntityPlayer#openGui deviates from Java styleguides, even though the rest of the code seems to follow them neatly. To clarify: GUI is an acronym and thus should be spelled in all caps like this: EntityPlayer#openGUI, not EntityPlayer#openGui. I don't understand why this method specifically deviates from this, especially since other abbreviations I have encountered in the code are fully capitalized.

Mojang obfuscates the vanilla source code. Forge uses a tool called MCP which supplies names for each variable/method/parameter. However, those names are supplied by the community, which is why there are consistency issues throughout the code.

[larsgerrits]

29 minutes ago, diesieben07 said:

EntityPlayer#openGui is a Forge method.

I thought it was a vanilla method patched by Forge... My mistake!

[DutchM]

Either I figured I might as well report it ^^

[LexManos]

Wed on't strictly follow the Java guidelines. Yes GUI is a acronym, but in the programming world, it is a word of it's own. So it can go either way.

This is a non-issue.