Jump to content

Recommended Posts

Posted (edited)

Hello,
I'm going to add iron ladders to my mod. 
 

I created a class:

package ...

import ...

public class BlockIronLadder extends BlockLadder {
    public BlockIronLadder() {

        setUnlocalizedName("iron_ladder");
        setRegistryName("iron_ladder");

        BlockInit.BLOCKS.add(this);
        ItemInit.ITEMS.add(new ItemBlock(this).setRegistryName(this.getRegistryName()));
    }
}

And called it in my BlockInit:

public static final Block IRON_LADDER = new BlockIronLadder();

And successfully registered the block and the item to the game.

 

I also created all of the following JSON files:

assets/blockstates/iron_ladder.json
{
    "variants": {
        "facing=north": { "model": "iron_ladder" },
        "facing=east":  { "model": "iron_ladder", "y": 90 },
        "facing=south": { "model": "iron_ladder", "y": 180 },
        "facing=west":  { "model": "iron_ladder", "y": 270 }
    }
}
assets/models/block/iron_ladder.json
{
    "ambientocclusion": false,
    "textures": {
        "particle": "blocks/iron_ladder",
        "texture": "blocks/iron_ladder"
    },
    "elements": [
        {   "from": [ 0, 0, 15.2 ],
            "to": [ 16, 16, 15.2 ],
            "shade": false,
            "faces": {
                "north": { "uv": [ 0, 0, 16, 16 ], "texture": "#texture" },
                "south": { "uv": [ 0, 0, 16, 16 ], "texture": "#texture" }
            }
        }
    ]
}
assets/models/item/iron_ladder.json
{
  "parent": "item/generated",
  "textures": {
    "layer0": "blocks/iron_ladder"
  }
}

 

...and the texture:

assets/textures/blocks/iron_ladder.png


I added a record to the lang file as well:

tile.iron_ladder.name=Iron Ladder


The ladder works fine, but shows up as...
a pink-black cube with the texture_name#variant_name
scr1.png

[06:56:04] [main/ERROR] [TEXTURE ERRORS]: +=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=
[06:56:04] [main/ERROR] [TEXTURE ERRORS]: The following texture errors were found.
[06:56:04] [main/ERROR] [TEXTURE ERRORS]: ==================================================
[06:56:04] [main/ERROR] [TEXTURE ERRORS]:   DOMAIN minecraft
[06:56:04] [main/ERROR] [TEXTURE ERRORS]: --------------------------------------------------
[06:56:04] [main/ERROR] [TEXTURE ERRORS]:   domain minecraft is missing 1 texture
[06:56:04] [main/ERROR] [TEXTURE ERRORS]:     domain minecraft has 3 locations:
[06:56:04] [main/ERROR] [TEXTURE ERRORS]:       unknown resourcepack type net.minecraft.client.resources.DefaultResourcePack : Default
[06:56:04] [main/ERROR] [TEXTURE ERRORS]:       unknown resourcepack type net.minecraft.client.resources.LegacyV2Adapter : FMLFileResourcePack:Forge Mod Loader
[06:56:04] [main/ERROR] [TEXTURE ERRORS]:       unknown resourcepack type net.minecraft.client.resources.LegacyV2Adapter : FMLFileResourcePack:Minecraft Forge
[06:56:04] [main/ERROR] [TEXTURE ERRORS]: -------------------------
[06:56:04] [main/ERROR] [TEXTURE ERRORS]:     The missing resources for domain minecraft are:
[06:56:04] [main/ERROR] [TEXTURE ERRORS]:       textures/blocks/iron_ladder.png
[06:56:04] [main/ERROR] [TEXTURE ERRORS]: -------------------------
[06:56:04] [main/ERROR] [TEXTURE ERRORS]:     No other errors exist for domain minecraft
[06:56:04] [main/ERROR] [TEXTURE ERRORS]: ==================================================
[06:56:04] [main/ERROR] [TEXTURE ERRORS]: +=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=

 

Am I missing something..? Well, surely I do, but what is it...?
Thanks in advance!

Edited by Xander402
+ error log

A few bytes about me:

public class Xander402 extends Modder implements IForumMember {
    int javaExperience, moddingExperience;
    LearningWay preferredLearningWay;
    public Xander402() {
        this.javaExperience = BIG;
        this.moddingExperience = NOT_SO_BIG;
        this.preferredLearningWay = LearningWay.through("exampes");
      	super(/*displayName*/"Xander402", /*moddingSince*/"1.9", preferredLearningWay);
    }
    @Override
    public Goal getReasonOfJoining(Forum forum) { return new Goal(() -> { while (true) moddingExperience++; }); }
}

 

Posted (edited)
  On 2/16/2019 at 6:19 AM, Xander402 said:

 

{
  "parent": "item/generated",
  "textures": {
    "layer0": "blocks/iron_ladder"
  }
}

 

Expand  

Your texture path is missing a domain (mod id), so Minecraft thinks you are looking for "blocks/iron_ladder" in the vanilla Minecraft assets, which does contain a texture for "iron_ladder".

Change "blocks/iron_ladder" to "modid:blocks/iron_ladder"

Edited by DavidM

Some tips:

  Reveal hidden contents

 

Posted
  On 2/16/2019 at 7:06 AM, DavidM said:

Your texture path is missing a domain (mod id), so Minecraft thinks you are looking for "blocks/iron_ladder" in the vanilla Minecraft textures, which does not exists.

Change "blocks/iron_ladder" to "modid:blocks/iron_ladder"

Expand  

Thank you! That is actually something that I've done before.. but it was really long time ago and I have to learn it all again...

Anyway, the ladder looks good now, but only when placed. The held item is still a pink-black cube.

I tried linking the texture under assets/textures/blocks/iron_ladder.png, then I tried to copy the texture to assets/textures/items/iron_ladder.png and linking that copy

I also played with the "parent", setting it to "block/block", "item/generated", "item/item"...

but the big pink-black cube still shows up in my square hand and I really have no clue how to solve it

 

The only thing I changed in my code was adding the namespace with the mod ID

A few bytes about me:

public class Xander402 extends Modder implements IForumMember {
    int javaExperience, moddingExperience;
    LearningWay preferredLearningWay;
    public Xander402() {
        this.javaExperience = BIG;
        this.moddingExperience = NOT_SO_BIG;
        this.preferredLearningWay = LearningWay.through("exampes");
      	super(/*displayName*/"Xander402", /*moddingSince*/"1.9", preferredLearningWay);
    }
    @Override
    public Goal getReasonOfJoining(Forum forum) { return new Goal(() -> { while (true) moddingExperience++; }); }
}

 

Posted (edited)

So far you've only added a model for your block when placed in world; you did not add a model for your block as an item.

 

What you need to do is to add a iron_ladder.json in your models/item. In the ladder's case, the item should be a child of item/generated with the iron_ladder.png as the texture.

 

Since the model for ladder is flat, you can just add it like how you would add an item.

 

{
    "parent": "item/generated",
    "textures": {
        "layer0": "modid:items/iron_ladder"
    }
}

 

EDIT: send your iron_ladder.json in your model/item folder. You should also check your console to see if any missing textures are reported.

Edited by DavidM

Some tips:

  Reveal hidden contents

 

Posted (edited)
  On 2/16/2019 at 9:35 AM, DavidM said:

So far you've only added a model for your block when placed in world; you did not add a model for your block as an item.

Expand  

I did add a model for the ItemBlock:
 

  Quote

I also created all of the following JSON files:

 

[...]

 

assets/models/item/iron_ladder.json
{
  "parent": "item/generated",
  "textures": {
    "layer0": "blocks/iron_ladder"
  }
}
Expand  

 

  On 2/16/2019 at 9:35 AM, DavidM said:

EDIT: send your iron_ladder.json in your model/item folder. You should also check your console to see if any missing textures are reported.

Expand  

 

Now the files look like this:

{
    "parent": "block/block",
    "textures": {
        "particle": "modid:blocks/iron_ladder",
        "texture": "modid:blocks/iron_ladder"
    },
    "elements": [
        {   "from": [ 0, 0, 15.2 ],
            "to": [ 16, 16, 15.2 ],
            "faces": {
                "north": { "uv": [ 0, 0, 16, 16 ], "texture": "#texture" },
                "south": { "uv": [ 0, 0, 16, 16 ], "texture": "#texture" }
            }
        }
    ]
}
{
  "parent": "item/generated",
  "textures": {
    "layer0": "modid:items/iron_ladder"
  }
}

 

And the textures are both under

assets/textures/blocks/iron_ladder.png

and

assets/textures/items/iron_ladder.png


...and with all this, it works like I said, that is, it doesn't. :/

And, no, there are no errors in log about the iron ladder.

Edited by Xander402
information

A few bytes about me:

public class Xander402 extends Modder implements IForumMember {
    int javaExperience, moddingExperience;
    LearningWay preferredLearningWay;
    public Xander402() {
        this.javaExperience = BIG;
        this.moddingExperience = NOT_SO_BIG;
        this.preferredLearningWay = LearningWay.through("exampes");
      	super(/*displayName*/"Xander402", /*moddingSince*/"1.9", preferredLearningWay);
    }
    @Override
    public Goal getReasonOfJoining(Forum forum) { return new Goal(() -> { while (true) moddingExperience++; }); }
}

 

Posted

Show your item model registration code

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
  On 2/16/2019 at 12:30 PM, Cadiboo said:

Show your item model registration code

Expand  

Item model registration code? I'm not sure what do you mean, but I can show you what I think you're talking about.


Here's my RegistryHandler:

package ... .util.handlers;

import ...

@EventBusSubscriber
public class RegistryHandler {

    ...

    @SuppressWarnings("unused")
    @SubscribeEvent
    public static void onModelRegister(ModelRegistryEvent event) {
        for (Item item : ItemInit.ITEMS) {
            if (item instanceof IHasModel) {
                ((IHasModel) item).registerModels();
            }
        }

        ...
    }

    ...
}

 

The ItemInit class contains a field ITEMS which is an ArrayList<Item> with all registered items.

In addition, I can say that I don't have problems with any other Item model, I only have one with the ladder.

A few bytes about me:

public class Xander402 extends Modder implements IForumMember {
    int javaExperience, moddingExperience;
    LearningWay preferredLearningWay;
    public Xander402() {
        this.javaExperience = BIG;
        this.moddingExperience = NOT_SO_BIG;
        this.preferredLearningWay = LearningWay.through("exampes");
      	super(/*displayName*/"Xander402", /*moddingSince*/"1.9", preferredLearningWay);
    }
    @Override
    public Goal getReasonOfJoining(Forum forum) { return new Goal(() -> { while (true) moddingExperience++; }); }
}

 

Posted

Yet another IHasModel... Drop it.

Some tips:

  Reveal hidden contents

 

Posted
  On 2/16/2019 at 3:16 PM, DavidM said:

Yet another IHasModel... Drop it.

Expand  

Well, I've actually copied a ready workspace, so things like Handlers or Proxy weren't made by me..
I don't really know how to write the RegistryHandler without it.

A few bytes about me:

public class Xander402 extends Modder implements IForumMember {
    int javaExperience, moddingExperience;
    LearningWay preferredLearningWay;
    public Xander402() {
        this.javaExperience = BIG;
        this.moddingExperience = NOT_SO_BIG;
        this.preferredLearningWay = LearningWay.through("exampes");
      	super(/*displayName*/"Xander402", /*moddingSince*/"1.9", preferredLearningWay);
    }
    @Override
    public Goal getReasonOfJoining(Forum forum) { return new Goal(() -> { while (true) moddingExperience++; }); }
}

 

Posted (edited)

You want something to copy? https://github.com/Cadiboo/Example-Mod

You want to understand what you’re doing wrong? https://gist.github.com/Cadiboo/fbea89dc95ebbdc58d118f5350b7ba93

Edited by Cadiboo

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted (edited)
  On 2/17/2019 at 2:05 AM, Cadiboo said:
Expand  

Yeah, this might help with some things, thank you.

Edited by Xander402
Correction

A few bytes about me:

public class Xander402 extends Modder implements IForumMember {
    int javaExperience, moddingExperience;
    LearningWay preferredLearningWay;
    public Xander402() {
        this.javaExperience = BIG;
        this.moddingExperience = NOT_SO_BIG;
        this.preferredLearningWay = LearningWay.through("exampes");
      	super(/*displayName*/"Xander402", /*moddingSince*/"1.9", preferredLearningWay);
    }
    @Override
    public Goal getReasonOfJoining(Forum forum) { return new Goal(() -> { while (true) moddingExperience++; }); }
}

 

Posted
  On 2/17/2019 at 2:05 AM, Cadiboo said:

You want to understand what you’re doing wrong? https://gist.github.com/Cadiboo/fbea89dc95ebbdc58d118f5350b7ba93

Expand  

That was the most important part of the message

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
  On 2/17/2019 at 2:10 AM, Cadiboo said:

That was the most important part of the message

Expand  

Well, I don't deny it :)
I just don't think that I do need to fully understand every single part of my mod source code, since it's meant to be used only by me, to make my survival world builds look a little better :)
But I'll keep that for future.

A few bytes about me:

public class Xander402 extends Modder implements IForumMember {
    int javaExperience, moddingExperience;
    LearningWay preferredLearningWay;
    public Xander402() {
        this.javaExperience = BIG;
        this.moddingExperience = NOT_SO_BIG;
        this.preferredLearningWay = LearningWay.through("exampes");
      	super(/*displayName*/"Xander402", /*moddingSince*/"1.9", preferredLearningWay);
    }
    @Override
    public Goal getReasonOfJoining(Forum forum) { return new Goal(() -> { while (true) moddingExperience++; }); }
}

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.