[1.13.2][SOLVED] Registries limits?

[Krevik]

Hi! Do minecraft forge 1.13.x build have some block registries limits? I cannot register more blocks, they're just skipped? Or is it rather my fault?

here is my github link if needed https://github.com/Krevik/1.13.2-test/tree/master/src/main/java/mod/krevik/kathairis

Edited February 20, 2019 by Krevik

[DavidM]

1. Stop using BlockBase.

2. Stop using ItemBase.

3. Where did you register your registerBlocks and registerItems method? Are they being called?

[Krevik]

  On 2/20/2019 at 12:35 AM, DavidM said:

1. Stop using BlockBase.

2. Stop using ItemBase.

3. Where did you register your registerBlocks and registerItems method? Are they being called?

Expand  

BlockBase and ItemBase are used to register block and items easier, the code is easier to read, than vanilla one - aren't some conventions pointing that the code should be easy to read? Without them I would have to call Block.Properties.create, every time I create new Block. The code is pretty long then, so I created some more simple constructor.

 

They're all registred in RegistryHelper.
 

    @SubscribeEvent
    public static void registerBlocks(final RegistryEvent.Register<Block> event){
        final IForgeRegistry<Block> registry = event.getRegistry();
        for(Block block: KBlocks.blockRegistryList){
            registry.register(block);
        }
    }

    @SubscribeEvent
    public static void registerItems(final RegistryEvent.Register<Item> event){
        final IForgeRegistry<Item> registry = event.getRegistry();
        for(ItemBlock itemBlock:KBlocks.itemBlocksRegistryList){
            final Block block = itemBlock.getBlock();
            final ResourceLocation registryName = Preconditions.checkNotNull(block.getRegistryName(), "Block %s has null registry name", block);
            ItemBlock itemBlock1 = (ItemBlock) new ItemBlock(block,new Item.Properties().group(itemBlock.getGroup())).setRegistryName(registryName);
            registry.register(itemBlock1);
        }
        for(Item item: KItems.itemsToRegister){
         registry.register(item);
        }
        registry.register(new ItemBlock(KBlocks.KATHARIAN_PORTAL,new Item.Properties().group(KathairisItemGroups.kathairis_building_blocks)).setRegistryName(KBlocks.KATHARIAN_PORTAL.getRegistryName().toString()));
    }

Yes, register method are being called, cause as I said most of blocks works, just some of them are skipped. Even if I try to register them manually, they're not succesfully registred

Edited February 20, 2019 by Krevik

[DavidM]

  On 2/20/2019 at 7:55 AM, Krevik said:

  On 2/20/2019 at 12:35 AM, DavidM said:

1. Stop using BlockBase.

2. Stop using ItemBase.

3. Where did you register your registerBlocks and registerItems method? Are they being called?

Expand  

BlockBase and ItemBase are used to register block and items easier, the code is easier to read, than vanilla one - aren't some conventions pointing that the code should be easy to read? Without them I would have to call Block.Properties.create, every time I create new Block. The code is pretty long then, so I created some more simple constructor.

Expand  

1. No. In fact, the convention in terms of modding is against using BlockBase and ItemBase. They are an anti-pattern. I've linked some posts from others down below explaining why Block/ItemBases should not be used:

http://www.minecraftforge.net/forum/topic/68881-onblockactivated-not-being-called/?tab=comments#comment-332831

http://www.minecraftforge.net/forum/topic/68429-ore-variant-textures-not-working-properly/?tab=comments#comment-330456

In conclusion, there is already a BlockBase, it is called Block; you shouldn't be using inheritance just to write less code; extending from bases prevents you from extending from other stuff.

 

2. Check your log. Are there any errors during registry? If all of your blocks are in the list, then the problem is probably that some blocks failed to register. Try adding debug lines.

Edited February 20, 2019 by DavidM

[Krevik]

  On 2/20/2019 at 8:18 AM, DavidM said:

1. No. In fact, the convention in terms of modding is against using BlockBase and ItemBase. They are an anti-pattern. I've linked some posts from others down below explaining why Block/ItemBases should not be used:

http://www.minecraftforge.net/forum/topic/68881-onblockactivated-not-being-called/?tab=comments#comment-332831

http://www.minecraftforge.net/forum/topic/68429-ore-variant-textures-not-working-properly/?tab=comments#comment-330456

In conclusion, there is already a BlockBase, it is called Block; you shouldn't be using inheritance just to write less code; extending from bases prevents you from extending from other stuff.

 

2. Check your log. Are there any errors during registry? If all of your blocks are in the list, then the problem is probably that some blocks failed to register. Try adding debug lines.

Expand  

Yea, been checking logs really long actually. They're just skipped, no errors. Katharian_Multi_Grass, blue_cloud_bricks and yellow_cloud_block. Blue_Cloud_bricks and Yellow_Cloud_Block are extending BlockBase, so the same registration methods are used.

Edited February 20, 2019 by Krevik

[LTNightshade]

Maybe try something like this in your main class:

 

 // Register Items
        FMLJavaModLoadingContext.get().getModEventBus().addGenericListener(Item.class,this::onItemsRegistry);

  private void onItemsRegistry(final RegistryEvent.Register<Item> itemRegistryEvent) {
        LOGGER.info("Registering Items...");
        ModItems.register(itemRegistryEvent);
    }

 

[Krevik]

Solved: I updated the forge version to the newest, refreshed gradle project and generated new intelijj runs.