Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Custom dimension sky brightness changes with render distance.

weckar

By weckar
in Modder Support

 Share

Recommended Posts

weckar Stone Miner

weckar

Posted
Posted

I've been working on my own dimension with custom sky rendering, and I have come across an odd bug where increasing the render distance will make the sky (much) brighter, while lowering it makes it much darker. I would not even know what to look for causing this, but I am happy to take any pointers...

If anyone has a comprehensive, visual guide to GUIs - don't hesitate to message me. They make my head spin.

Link to comment
Share on other sites
Laike_Endaril Creeper Killer

Laike_Endaril

Posted
Posted (edited)

Well as a starting point, I'd make sure you're not testing with any other mods involved (if possible), especially any shaders, optifine, or anything else that is likely to do anything graphics-related.

That aside, the only things I can think of are the skybox color/texture, the sun/moon textures, and the fog color.  I haven't messed with any of these and don't know where they're being handled.  There might also be other factors I'm not aware of.

Edited by Laike_Endaril
Link to comment
Share on other sites
Krevik Creeper Killer

Krevik

Posted
Posted
32 minutes ago, weckar said:

I've been working on my own dimension with custom sky rendering, and I have come across an odd bug where increasing the render distance will make the sky (much) brighter, while lowering it makes it much darker. I would not even know what to look for causing this, but I am happy to take any pointers...

Hmmm I have not been playing with render distance but as far as I know you should play with sky color and fog color cause it seems they're affecting each other. Hope it will point you onto right way.

Link to comment
Share on other sites
Laike_Endaril Creeper Killer

Laike_Endaril

Posted
Posted (edited)

Yep, after doing a short experiment with render distance in the nether, I noticed the observed "sky color" is far darker at *short* view distances.  Really short view distances are dominated by the fog color, so the nether has a dark fog color, and when you increase the view distance, the fog color has less effect, so in the nether, the "sky" becomes brighter with longer view distances (up to a point)

 

In your case it may well be the opposite.  Ie. your fog color is probably brighter than your skybox color, and your fog color is probably the color you're trying to achieve, I'm guessing.  You may want to try setting the skybox color brighter.

 

Edit: You know what, I might have the skybox color and fog color backwards...in any case, try messing with both and observe the results

Edited by Laike_Endaril
Link to comment
Share on other sites
weckar Stone Miner

weckar

Posted
  • Author
Posted

Yeah, you're right. Turns out I was fighting the fog color the whole time with odd sky color values. Setting them to the same color vector circumvents the whole issue. Thanks!

If anyone has a comprehensive, visual guide to GUIs - don't hesitate to message me. They make my head spin.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • DDmce
      About mixin

      By DDmce · Posted

      So I saw that mixin is shipped as a library with forge, but is it available for 1.7.10 ?  
    • DDmce
      Weird idea on mods...

      By DDmce · Posted

      So I've read the EULA, and lets be straight...     If I split my modpack(of my mods, yeah I'm nuts) into several(many) individual mods(like just one boss) with minor additions(plus not working together), then have a complete/modpack version on patreon/onlyfans having each addon work together... Would people buy my idea?
    • graceholan64
      Gültige Ausgabe von Goethe A1-A2-B1-B2-C1-C2

      By graceholan64 · Posted

      German A1 – C1, TestDAF, Goethe B1, B2, C1, C2, valid GOETHE certificate German A1 – C1, TestDAF, Goethe B1, B2, C1, C2, valid GOETHE certificate(+27(838-80-8170
    • Bubbles Walker
      crash when getting to loading the mods

      By Bubbles Walker · Posted

      Done, it still crashed. New log https://paste.ee/p/kYv6e
    • Beothorn
      [1.20.2] Textures for Block States that worked on 1.16 for Tile Entity are not working for Block Entity

      By Beothorn · Posted

      I am migrating a mod from 1.16.5 to 1.20.2 The version for 1.16.5 can be found here https://github.com/beothorn/automataCraft For the block called automata_start, it uses TileEntities and has blockstates, model/block and textures on json files. This is currently working fine on 1.16.5 https://github.com/beothorn/automataCraft/tree/master/src/main/resources/assets/automata For 1.20.2 I migrated the logic from TileEntities to BlockEntity. The mod is working fine. All blocks and Items are working with the correct textures except for the textures for each state of the automata_start block. No changes where made to the json files. This is the branch I am working on (there were some refactorings, but all is basically the same): https://github.com/beothorn/automataCraft/tree/1_20/src/main/resources/assets/automata The only difference I can think that may be related is that i had to implement createBlockStateDefinition on the BaseEntityBlock: https://github.com/beothorn/automataCraft/blob/1_20/src/main/java/br/com/isageek/automata/automata/AutomataStartBlock.java#L43 This is driving me crazy. I know the jsons are being loaded as I put a breakpoint at `net.minecraft.client.resources.model.ModelBakery#loadModel` and I can see BlockModelDefinition.fromJsonElement being called with automata_start. I also printed the state from the arguments of the tick function call and they look correct (https://github.com/beothorn/automataCraft/blob/1_20/src/main/java/br/com/isageek/automata/automata/Ticker.java#L32 ): blockState Block{automata:automata_start}[state=loadreplaceables] In game, all I see is the no textures. I think it is weird it is not the "missing texture" texture so I think it may be related to the material, but I had no success tweaking it (https://github.com/beothorn/automataCraft/blob/1_20/src/main/java/br/com/isageek/automata/automata/AutomataStartBlock.java#L37).   public static final Property<AutomataStartState> state = EnumProperty.create("state", AutomataStartState.class); private final AtomicReference<RegistryObject<BlockEntityType<?>>> blockEntityType; private final Map<String, RegistryObject<Block>> registeredBlocks; public AutomataStartBlock( final AtomicReference<RegistryObject<BlockEntityType<?>>> blockEntityType, final Map<String, RegistryObject<Block>> registeredBlocks ) { super(BlockBehaviour.Properties.of().mapColor(MapColor.STONE).strength(1.5F, 6.0F)); this.blockEntityType = blockEntityType; this.registeredBlocks = registeredBlocks; this.registerDefaultState(this.getStateDefinition().any().setValue(state, AutomataStartState.LOAD_REPLACEABLES)); } @Override protected void createBlockStateDefinition(StateDefinition.Builder<Block, BlockState> stateBuilder) { stateBuilder.add(state); }     So my cry for help is, anyone has any ideas? Is there a way to easily debug this, for example somewhere where I can list the textures for a given state, or make sure this is loaded?   Thanks in advance for the hints

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept