[1.13.2] unFormattedComponentText not Equaling a String

[cleardragonf]

 

Hello So I run the below code

 	@SubscribeEvent
	public void arrowNocked(PlayerEvent.ItemPickupEvent event)
	{
		if(event.getStack().getItem().getDisplayName(null).getUnformattedComponentText().toString() =="Arrow"){
			logger.error(event.getPlayer().getName().getFormattedText()+ " has collected a Diamond at" + event.getPlayer().getPosition());
		}else{
			
			logger.warn("Hmm Doesn't seem to be working at all" + event.getStack().getItem().getDisplayName(null).getUnformattedComponentText().toString());
		}
		
	}

 

However I get the below result

Quote

[21:20:38.838] [Server thread/INFO] [dedicated.DedicatedServer/]: ºeCleardragonf joined the gameºr
[21:20:43.424] [Server thread/WARN] [asuramagica/]: Hmm Doesn't seem to be working at allArrow

Could Someone Please Explain Why it keeps going to the else? when i pick up an Arrow?

[DavidM]

1. Use String#equals when possible. Since strings are not primitive types, 

str_1 == str_2

will return false even if both strings are the same value given that both strings does not point to the same object.

 

2. Checking an item's type with its name is not accurate, as an item's name can be changed. Check the registry name or use some other methods of checking instead.

Edited March 1, 2019 by DavidM

[cleardragonf]

14 hours ago, DavidM said:

Your if statement will never be true.

String is not a primitive type, so

"Hello World" == "Hello World"

will always return false.

Use String#equals instead.

hmmm yea i didn't know that...my java is very basic and i've had .toString() == "asdf" work before in pure java...so i'll use the Equals() Thanks.

 

9 hours ago, diesieben07 said:

First of all, why do you call all of your event handlers arrowNocked? ?

Also, that is not how you check for something being an arrow. Make a tag for it or use some other kind of proper check. Checking the name of an item is not appropriate to determine what it is.

lol cause i'm learning i'm overwritten the same method over and over.  I'm learning to do things like i say...this is my first time ever getting into modding for minecraft...so i'm trying different things to understand the code a bit better and logic.  Could you explain why I would use Tag vs checking the name of an item? the reason i'm doing the name of an item is because once i figure out how to make items i may want to do things based upon picking that item up.

[cleardragonf]

hmmm perfect Explanation...i just didn't like the Tab cause at first glace...it didn't support individual items...but...i can make a Tag for arrows? yes? in a json? i'll have to look into that in the future.  Thank you for taking the time to explain

 

[Cadiboo]

19 hours ago, DavidM said:

Your if statement will never be true.

String is not a primitive type, so

"Hello World" == "Hello World"

will always return false.

Use String#equals instead.

Not quite, you are comparing 2 constants in that and because the JVM does some stuff with string constants to make them the same object, this expression will be true. However 

new String("Hello World") == new String("Hello World")

will always be false as they are not the same object 

[DavidM]

26 minutes ago, Cadiboo said:

Not quite, you are comparing 2 constants in that and because the JVM does some stuff with string constants to make them the same object, this expression will be true. However 

Thanks for the clarification.