I cannot for the life of me, get the following code to enter the writeToNBT and readFromNBT...

I used the info from https://mcforge.readthedocs.io/en/latest/datastorage/worldsaveddata/ but I don't think it's very clear what exactly to do...

 

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapStorage;
import net.minecraft.world.storage.WorldSavedData;

public class DataTest extends WorldSavedData {

    private static final String DATA_NAME = "ModID_Test";
    private static DataTest instance;
    private int testInt;

    public DataTest() {
        super(DATA_NAME);
    }

    public static DataTest get(World world) {
        MapStorage storage = world.getMapStorage();
        instance = (DataTest) storage.getOrLoadData(DataTest.class, DATA_NAME);

        if (instance == null) {
            instance = new DataTest();
            storage.setData(DATA_NAME, instance);
        }
        return instance;
    }

    @Override
    public void readFromNBT(NBTTagCompound nbt) {
        int temp = nbt.getCompoundTag("testData").getInteger("testInt");
        testInt = temp;
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        compound.setInteger("testInt", testInt);
        compound.setTag("testData", compound);
        return compound;
    }

    public void setCharData(int testInt) {
        this.testInt = testInt;
        markDirty();
    }

    public int getTestInt() {
        return testInt;
    }
}

 

Edited March 7, 20196 yr by Angercraft

21 minutes ago, Angercraft said:

compound.setInteger("testInt", testInt); compound.setTag("testData", compound);

Why are you trying to set a tag of the compound to itself?

I wasn't sure about how to do that, but my main problem is that i haven't been able to debug it, as it won't enter the readFromNBT() method.

Okay, i tried adding a public constructor with string parameter, and removed the tag on the compound. But sadly it still doesn't work.

 

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapStorage;
import net.minecraft.world.storage.WorldSavedData;

public class DataTest extends WorldSavedData {

    private static final String DATA_NAME = "ModID_Test";
    private static DataTest instance;
    private int testInt;

    public DataTest() {
        super(DATA_NAME);
    }

    public DataTest(String name) {
        super(name);
    }

    public static DataTest get(World world) {
        MapStorage storage = world.getMapStorage();
        instance = (DataTest) storage.getOrLoadData(DataTest.class, DATA_NAME);

        if (instance == null) {
            instance = new DataTest();
            storage.setData(DATA_NAME, instance);
        }
        return instance;
    }

    @Override
    public void readFromNBT(NBTTagCompound nbt) {
        int temp = nbt.getInteger("testInt");
        testInt = temp;
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        compound.setInteger("testInt", testInt);
        return compound;
    }

    public void setCharData(int testInt) {
        this.testInt = testInt;
        markDirty();
    }

    public int getTestInt() {
        return testInt;
    }
}

 

Oh sorry mate, should have mentioned that. Right now I just use a BreakEvent to trigger it.

 

@SubscribeEvent
    public static void brokeBlock(BlockEvent.BreakEvent event) {
        System.out.println("Block broken: "+event.getState().getBlock().getUnlocalizedName()+" by: "+event.getPlayer().getName());
        World world = Minecraft.getMinecraft().world;
        DataTest data = DataTest.get(world);
        if(data != null) {
            data.setCharData(1);
        }
    }

 

Oh thank you. Just wondering, would you know of an example showing proper usage of the worldSavedData? Right now i'm just trying to get anything to save persistently.

I'm not sure if I am getting this correctly, but does this mean I have to get a serverside world somehow?

I figured it out! Though I don't know if this is how it is meant to be done.

@SubscribeEvent
    public static void brokeBlock(BlockEvent.BreakEvent event) {
        DataTest data = DataTest.get(event.getWorld());
        if(data != null) {
            data.setCharData(1);
        }
    }

 

Edited March 7, 20196 yr by Angercraft

In case any other people are going to look at this in the future.

Final WorldSavedData object:

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapStorage;
import net.minecraft.world.storage.WorldSavedData;

public class DataTest extends WorldSavedData {

    private static final String DATA_NAME = "ModID_Test";
    private static DataTest instance;
    private int testInt;

    public DataTest() {
        super(DATA_NAME);
    }

    public DataTest(String name) {
        super(name);
    }

    public static DataTest get(World world) {
        MapStorage storage = world.getMapStorage();
        instance = (DataTest) storage.getOrLoadData(DataTest.class, DATA_NAME);

        if (instance == null) {
            instance = new DataTest();
            storage.setData(DATA_NAME, instance);
        }
        return instance;
    }

    @Override
    public void readFromNBT(NBTTagCompound nbt) {
        testInt = nbt.getInteger("testInt");
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        compound.setInteger("testInt", testInt);
        return compound;
    }

    public void setCharData(int testInt) {
        this.testInt = testInt;
        markDirty();
    }

    public int getTestInt() {
        return testInt;
    }
}

 

 

Using the WorldSavedData object from a PlayerEvent type: (Only example, you can get it from other ways, just keep in mind we have to use the Logical Server Side world)

import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.EventPriority;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.PlayerEvent;

@Mod.EventBusSubscriber(modid = Reference.MOD_ID)
public class ServerListener {

    @SubscribeEvent(priority = EventPriority.NORMAL)
    public static void playerConnected(PlayerEvent.PlayerLoggedInEvent event) {
        DataTest data = DataTest.get(event.player.world);
        if(data != null) {
            int testInt = data.getCharData();
            System.out.println("Value: "+testInt);
        }
    }

    @SubscribeEvent(priority = EventPriority.NORMAL)
    public static void playerDisconnected(PlayerEvent.PlayerLoggedOutEvent event) {
        DataTest data = DataTest.get(event.player.world);
        if(data != null) {
            data.setCharData(1);
            System.out.println("Value: "+testInt);
        }
    }
}