Jump to content

[Solved][1.12.2] Rendering issues with dynamic block model


Recommended Posts

Posted (edited)

Hello :)

I'm currently working on the mod that let players make blocks emit light. To achive this I am swaping original block with a custom one that uses texture of the original block. Original block state is stored in tile entity. I'm also using IBakedModel in conjunction with ModelBakeEvent to dynamically generate a model. It's all working fine but I have encountered some lesser rendering issues that I don't know are possible to fix :)

 

1. SOLVED. Transparent blocks like Ice that are directly behind my block are rendering sides (see picture below). This is probably imposible to fix due to BlockBreakable#shouldSideBeRendered implementation. (Opposite case is fine - fixed in my block's shouldSideBeRendered method).

Spoiler

4WfXJTf.png

 

2. My block is lacking shades (since it's emitting light) and looks "out of place" when next to "normal" blocks, especially when looking from the side . See picture below. 

Spoiler

YgxBIkj.png

 

3. Rendering gliches when in third person.

Spoiler

Fv3VKfc.pngazDa7Yx.png

 

4. SOLVED. I cannot set block particles (like block break particles). I have no access to extendedState in getParticleTexture method in my bakedModel, so I can't get the texture of original block. 

 

The code of my mod is available on GitHub, especially Block and bakedModel.

 

If anyone has an idea how to fix any of above issues I will be really gratefull. Thanks!

Edited by Pyre540
Issue solved
Posted

1. Override doesSideBlockRendering

2. Have ambientOcclusion be true in your model

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted (edited)

Hey, thanks for answer :)

8 hours ago, Cadiboo said:

1. Override doesSideBlockRendering

Thanks, that works great :)

    @Override
    public boolean doesSideBlockRendering(IBlockState state, IBlockAccess world, BlockPos pos, EnumFacing face) {
        IBlockState neighbourState = world.getBlockState(pos.offset(face));
        Block neighbourBlock = neighbourState.getBlock();
        Block originalBlock = getOriginalBlock(world, pos);

        if ((originalBlock.getBlockLayer() == BlockRenderLayer.TRANSLUCENT || originalBlock.getBlockLayer() == BlockRenderLayer.CUTOUT)
                && ((neighbourBlock == this && originalBlock == getOriginalBlock(world, pos.offset(face))) || originalBlock == neighbourBlock)) {
            return true;
        }
        return super.doesSideBlockRendering(state, world, pos, face);
    }

 

8 hours ago, Cadiboo said:

2. Have ambientOcclusion be true in your model

That unfortunately didn't help :/

{
  "parent": "block/cube_all",
  "ambientocclusion": true,
  "textures": {
    "all": "minecraft:blocks/glowstone"
  }
}

 

I also fixed the issue with particle textures (issue 4):

Spoiler

    @Override
    public boolean addLandingEffects(IBlockState state, WorldServer world, BlockPos blockPosition, IBlockState iblockstate, EntityLivingBase entity, int numberOfParticles) {
        IBlockState originalState = getTileEntitySafely(world, blockPosition).getOriginalBlockState();
        float f = (float) MathHelper.ceil(entity.fallDistance - 3.0F);
        double d0 = Math.min((double)(0.2F + f / 15.0F), 2.5D);
        int numOfParticles = (int)(150.0D * d0);
        world.spawnParticle(EnumParticleTypes.BLOCK_DUST, entity.posX, entity.posY, entity.posZ, numOfParticles,
                0.0D, 0.0D, 0.0D, 0.15000000596046448D, Block.getStateId(originalState));
        return true;
    }

    @Override
    public boolean addRunningEffects(IBlockState state, World world, BlockPos pos, Entity entity) {
        if (world.isRemote) {
            IBlockState originalState = getTileEntitySafely(world, pos).getOriginalBlockState();
            world.spawnParticle(EnumParticleTypes.BLOCK_CRACK,
                    entity.posX + ((double)world.rand.nextFloat() - 0.5D) * (double)entity.width,
                    entity.getEntityBoundingBox().minY + 0.1D,
                    entity.posZ + ((double)world.rand.nextFloat() - 0.5D) * (double)entity.width,
                    -entity.motionX * 4.0D, 1.5D, -entity.motionZ * 4.0D, Block.getStateId(originalState));
        }
        return true;
    }

    @SideOnly(Side.CLIENT)
    @Override
    public boolean addHitEffects(IBlockState state, World world, RayTraceResult target, ParticleManager manager) {
        BlockPos pos = target.getBlockPos();
        EnumFacing side = target.sideHit;
        IBlockState originalState = getTileEntitySafely(world, pos).getOriginalBlockState();

        int i = pos.getX();
        int j = pos.getY();
        int k = pos.getZ();

        AxisAlignedBB axisalignedbb = originalState.getBoundingBox(world, pos);
        double d0 = (double) i + world.rand.nextDouble() * (axisalignedbb.maxX - axisalignedbb.minX - 0.20000000298023224D) + 0.10000000149011612D + axisalignedbb.minX;
        double d1 = (double) j + world.rand.nextDouble() * (axisalignedbb.maxY - axisalignedbb.minY - 0.20000000298023224D) + 0.10000000149011612D + axisalignedbb.minY;
        double d2 = (double) k + world.rand.nextDouble() * (axisalignedbb.maxZ - axisalignedbb.minZ - 0.20000000298023224D) + 0.10000000149011612D + axisalignedbb.minZ;

        switch (side) {
            case DOWN:
                d1 = (double) j + axisalignedbb.minY - 0.10000000149011612D;
                break;
            case UP:
                d1 = (double) j + axisalignedbb.maxY + 0.10000000149011612D;
                break;
            case NORTH:
                d2 = (double) k + axisalignedbb.minZ - 0.10000000149011612D;
                break;
            case SOUTH:
                d2 = (double) k + axisalignedbb.maxZ + 0.10000000149011612D;
                break;
            case WEST:
                d0 = (double) i + axisalignedbb.minX - 0.10000000149011612D;
                break;
            case EAST:
                d0 = (double) i + axisalignedbb.maxX + 0.10000000149011612D;
        }

        ParticleDigging.Factory factory = new ParticleDigging.Factory();
        ParticleDigging particle = (ParticleDigging) factory.createParticle(1, world, d0, d1, d2,
                0.0D, 0.0D, 0.0D, Block.getStateId(originalState));
        particle.setBlockPos(pos).multiplyVelocity(0.2F).multipleParticleScaleBy(0.6F);
        manager.addEffect(particle);

        return true;
    }

    @SideOnly(Side.CLIENT)
    @Override
    public boolean addDestroyEffects(World world, BlockPos pos, ParticleManager manager) {
        IBlockState state = getTileEntitySafely(world, pos).getOriginalBlockState();
        ParticleDigging.Factory factory = new ParticleDigging.Factory();
        for (int j = 0; j < 4; ++j) {
            for (int k = 0; k < 4; ++k) {
                for (int l = 0; l < 4; ++l) {
                    double d0 = ((double) j + 0.5D) / 4.0D;
                    double d1 = ((double) k + 0.5D) / 4.0D;
                    double d2 = ((double) l + 0.5D) / 4.0D;

                    ParticleDigging particle = (ParticleDigging) factory.createParticle(0, world,
                            (double) pos.getX() + d0, (double) pos.getY() + d1, (double) pos.getZ() + d2,
                            d0 - 0.5D, d1 - 0.5D, d2 - 0.5D, Block.getStateId(state));
                    particle.setBlockPos(pos);
                    manager.addEffect(particle);
                }
            }
        }
        return true;
    }

 

 

So 2 down and 2 to go :)

Edited by Pyre540
Posted

Is there a way to "force" Minecraft to render block using BlockModelRenderer#renderModelSmooth method directly instead of BlockModelRenderer#renderModel method?

Posted

Set the game settings smooth lighting to smooth

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted

I'm sorry I should be more specific with my question. I'm trying to do something with issue #2. In BlockModelRenderer#renderModel there is a flag that determines if the block should be rendered "Smooth" or "Flat".

boolean flag = Minecraft.isAmbientOcclusionEnabled() && stateIn.getLightValue(worldIn, posIn) == 0 && modelIn.isAmbientOcclusion(stateIn);


Ambient Occlusion is enabled in the game and in my model. The problem is that my block is emitting light so stateIn.getLightValue(worldIn, posIn) is greater then 0. In my last post I was asking if I could "force" the game to use renderModelSmooth method directly to bypass light value check.


I can achive the effect I want quite easly by doing somthing like that in my block: 

Spoiler

    @Override
    public IBlockState getActualState(IBlockState state, IBlockAccess worldIn, BlockPos pos) {
        return getTileEntitySafely(worldIn, pos).getOriginalBlockState();
    }

D3pUWTK.png


But that is obviously bad (at least I think it is) and can probably cause hard to find bugs in the future, so I'm trying to avoid that.


Can I achive this effect in some other way? For example by getting rid of my block's model completly and using TESR/FastTESR to just render "original" block model?

Posted

Ok so I finally got some time to play with FastTESR idea and it ended up pretty well - I achieved the effect I wanted on almost all blocks. The biggest issue with this approach turned out to be transparent blocks. They were really glitchy due to rendering order. So I end up rendering them in the correct order (furthest to nearest) in RenderWorldLastEvent and the rest (solid, cutout...) in FastTESR. At first everything looked very good, but unfortunately I found 2 new issues.


1. Transparent blocks look good during the day, but at night or in another dark environment they are too bright.

Spoiler

imZgxC0.png5QQizxV.png


2. Looking at my block through another transparent block, my block has a different color (has ambient acclusion?). I probably can live with this issue but if someone know how to fix this, it would be great :)

Spoiler

tkFdLTd.png

 

My last concern is performance, but I don't think I can do something with it in current approach.

 

My FastTESR:

public class FastTESREnlightenedBlock extends FastTESR<TileEntityEnlightenedBlock> {

    private BlockRendererDispatcher blockRenderer;

    @Override
    public void renderTileEntityFast(TileEntityEnlightenedBlock te, double x, double y, double z, float partialTicks, int destroyStage, float partial, BufferBuilder buffer) {

        IBlockState originalBlockState = te.getOriginalBlockState();

        if (originalBlockState.getBlock().getBlockLayer() == BlockRenderLayer.TRANSLUCENT) {
            return;
        }

        if(blockRenderer == null) {
            blockRenderer = Minecraft.getMinecraft().getBlockRendererDispatcher();
        }

        BlockPos pos = te.getPos();
        World world = te.getWorld();
        IBlockState blockState = world.getBlockState(pos);
        IBakedModel model = blockRenderer.getModelForState(originalBlockState);

        buffer.setTranslation(x - pos.getX(), y - pos.getY(), z - pos.getZ());

        if (Minecraft.isAmbientOcclusionEnabled()) {
            blockRenderer.getBlockModelRenderer().renderModelSmooth(world, model, blockState, pos, buffer, true, MathHelper.getPositionRandom(pos));
        } else {
            blockRenderer.getBlockModelRenderer().renderModelFlat(world, model, blockState, pos, buffer, true, MathHelper.getPositionRandom(pos));
        }
    }
}

 

RenderWorldLastEvent:

    @SubscribeEvent
    public static void onRenderLastEvent(RenderWorldLastEvent event) {
        EntityPlayerSP player = Minecraft.getMinecraft().player;
        WorldClient world = Minecraft.getMinecraft().world;

        List<TileEntity> loadedTileEntityList = world.loadedTileEntityList;
        List<TileEntityEnlightenedBlock> alphas = loadedTileEntityList.stream()
                .filter(te -> te instanceof TileEntityEnlightenedBlock)
                //.filter(te -> canPlayerSeeTile(world, player, te))
                .map(te -> (TileEntityEnlightenedBlock)te)
                .filter(te -> te.getOriginalBlockState().getBlock().getBlockLayer() == BlockRenderLayer.TRANSLUCENT)
                .collect(Collectors.toList());

        if (alphas.isEmpty()) {
            return;
        }

        final double partialTicks = (double)event.getPartialTicks();
        final double playerX = player.prevPosX + (player.posX - player.prevPosX) * partialTicks;
        final double playerY = player.prevPosY + (player.posY - player.prevPosY) * partialTicks;
        final double playerZ = player.prevPosZ + (player.posZ - player.prevPosZ) * partialTicks;

        for (TileEntityEnlightenedBlock alpha : alphas) {
            alpha.setDistanceToPlayer(alpha.getDistanceSq(playerX, playerY, playerZ));
        }

        alphas.sort(Comparator.comparingDouble(TileEntityEnlightenedBlock::getDistanceToPlayer).reversed());

        for (TileEntityEnlightenedBlock alpha : alphas) {
            BlockPos pos = alpha.getPos();
            final double x = (double)pos.getX() - playerX;
            final double y = (double)pos.getY() - playerY;
            final double z = (double)pos.getZ() - playerZ;

            renderTransparentBlock(world, alpha, pos, x, y, z);
        }
    }

    private static void renderTransparentBlock(WorldClient world, TileEntityEnlightenedBlock alpha, BlockPos pos, double x, double y, double z) {
        GlStateManager.pushMatrix();
        RenderHelper.disableStandardItemLighting();
        if (Minecraft.isAmbientOcclusionEnabled()) {
            GlStateManager.shadeModel(GL11.GL_SMOOTH);
        } else {
            GlStateManager.shadeModel(GL11.GL_FLAT);
        }
        GlStateManager.disableLighting();
        GlStateManager.enableCull();
        GlStateManager.enableBlend();
        GlStateManager.blendFunc(GL11.GL_SRC_ALPHA, GL11.GL_ONE_MINUS_SRC_ALPHA);
        GlStateManager.disableAlpha();
        GlStateManager.enableDepth();
        GlStateManager.depthMask(false);

        GlStateManager.translate(x - alpha.getPos().getX(), y - alpha.getPos().getY(), z - alpha.getPos().getZ());

        IBlockState originalBlockState = alpha.getOriginalBlockState();
        IBlockState blockState = world.getBlockState(pos);
        BlockRendererDispatcher renderer = Minecraft.getMinecraft().getBlockRendererDispatcher();
        IBakedModel model = renderer.getModelForState(originalBlockState);

        Tessellator tessellator = Tessellator.getInstance();
        tessellator.getBuffer().begin(GL11.GL_QUADS, DefaultVertexFormats.BLOCK);
        if (Minecraft.isAmbientOcclusionEnabled()) {
            renderer.getBlockModelRenderer().renderModelSmooth(world, model, blockState, pos, tessellator.getBuffer(), true, MathHelper.getPositionRandom(pos));
        } else {
            renderer.getBlockModelRenderer().renderModelFlat(world, model, blockState, pos, tessellator.getBuffer(), true, MathHelper.getPositionRandom(pos));
        }
        tessellator.draw();

        RenderHelper.enableStandardItemLighting();
        GlStateManager.popMatrix();

        GlStateManager.enableLighting();
        GlStateManager.disableCull();
        GlStateManager.disableBlend();
        GlStateManager.enableAlpha();
        GlStateManager.depthMask(true);
    }

 

Full source code is available on GitHub

Posted

You might want to look at how Blocks are rendered in RenderChunk#rebuildChunk

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted

Hey, thanks for reply.
I looked into that method, but unfortunately I don't think I know what part of code you had in mind and for which issue. Can you elaborate?

Posted

That’s the vanilla code that renders all the blocks for a chunk, translucency works right for it so I was thinking you might want to compare your code to it

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted

I finally solved the issue with block brightness. It turned out to be really easy fix. All I had to do was add two lines of code:

Minecraft.getMinecraft().entityRenderer.enableLightmap();
//Rest of rendering stuff here
Minecraft.getMinecraft().entityRenderer.disableLightmap();

 

I also changed the structure of the code to call the drawing method for the transparent blocks only once. Here's updated code:

    @SubscribeEvent
    public static void onRenderLastEvent(RenderWorldLastEvent event) {
        EntityPlayerSP player = Minecraft.getMinecraft().player;
        WorldClient world = Minecraft.getMinecraft().world;

        List<TileEntity> loadedTileEntityList = world.loadedTileEntityList;
        List<TileEntityEnlightenedBlock> alphas = loadedTileEntityList.stream()
                .filter(te -> te instanceof TileEntityEnlightenedBlock)
                .map(te -> (TileEntityEnlightenedBlock)te)
                .filter(te -> te.getOriginalBlockState().getBlock().getBlockLayer() == BlockRenderLayer.TRANSLUCENT)
                .collect(Collectors.toList());

        if (alphas.isEmpty()) {
            return;
        }

        final double partialTicks = (double)event.getPartialTicks();
        final double playerX = player.prevPosX + (player.posX - player.prevPosX) * partialTicks;
        final double playerY = player.prevPosY + (player.posY - player.prevPosY) * partialTicks;
        final double playerZ = player.prevPosZ + (player.posZ - player.prevPosZ) * partialTicks;

        for (TileEntityEnlightenedBlock alpha : alphas) {
            alpha.setDistanceToPlayer(alpha.getDistanceSq(playerX, playerY, playerZ));
        }
        alphas.sort(Comparator.comparingDouble(TileEntityEnlightenedBlock::getDistanceToPlayer).reversed());

        preRenderTransparentBlocks();

        Tessellator tessellator = Tessellator.getInstance();
        BufferBuilder buffer = tessellator.getBuffer();
        buffer.begin(GL11.GL_QUADS, DefaultVertexFormats.BLOCK);

        for (TileEntityEnlightenedBlock alpha : alphas) {
            BlockPos pos = alpha.getPos();
            final double x = (double)pos.getX() - playerX;
            final double y = (double)pos.getY() - playerY;
            final double z = (double)pos.getZ() - playerZ;

            renderTransparentBlock(world, alpha, pos, x, y, z, buffer);
        }
        buffer.setTranslation(0, 0, 0);
        tessellator.draw();

        postRenderTransparentBlocks();
    }

    private static void preRenderTransparentBlocks() {
        Minecraft.getMinecraft().entityRenderer.enableLightmap();
        GlStateManager.pushMatrix();
        if (Minecraft.isAmbientOcclusionEnabled()) {
            GlStateManager.shadeModel(GL11.GL_SMOOTH);
        } else {
            GlStateManager.shadeModel(GL11.GL_FLAT);
        }
        GlStateManager.disableLighting();
        GlStateManager.enableCull();
        GlStateManager.enableBlend();
        GlStateManager.blendFunc(GL11.GL_SRC_ALPHA, GL11.GL_ONE_MINUS_SRC_ALPHA);
        GlStateManager.disableAlpha();
        GlStateManager.enableDepth();
        GlStateManager.depthMask(false);
    }

    private static void renderTransparentBlock(WorldClient world, TileEntityEnlightenedBlock alpha, BlockPos pos, double x, double y, double z, BufferBuilder buffer) {

        buffer.setTranslation(x - pos.getX(), y - pos.getY(), z - pos.getZ());

        IBlockState originalBlockState = alpha.getOriginalBlockState();
        IBlockState blockState = world.getBlockState(pos);
        BlockRendererDispatcher renderer = Minecraft.getMinecraft().getBlockRendererDispatcher();
        IBakedModel model = renderer.getModelForState(originalBlockState);

        if (Minecraft.isAmbientOcclusionEnabled()) {
            renderer.getBlockModelRenderer().renderModelSmooth(world, model, blockState, pos, buffer, true, MathHelper.getPositionRandom(pos));
        } else {
            renderer.getBlockModelRenderer().renderModelFlat(world, model, blockState, pos, buffer, true, MathHelper.getPositionRandom(pos));
        }
    }

    private static void postRenderTransparentBlocks() {
        GlStateManager.popMatrix();
        GlStateManager.enableLighting();
        GlStateManager.disableCull();
        GlStateManager.disableBlend();
        GlStateManager.enableAlpha();
        GlStateManager.depthMask(true);
        Minecraft.getMinecraft().entityRenderer.disableLightmap();
    }

 

That being said, I think this topic can be considered solved. The only issue left is the issue with looking at my block through another transparent block, but as I said, this is not a big deal and I can live with that :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.