Jump to content

Sound Not Working


outflows

Recommended Posts

 

So all I want to do is add a sound to the registry but for some reason it's not working. This is what I did:

public class SoundRegistrator 
{
	public static final SoundEvent BOND;
	
	static {
		BOND = addSoundsToRegistry("bond");
	}
	
	private static SoundEvent addSoundsToRegistry(String soundId) {
		ResourceLocation shotSoundLocation = new ResourceLocation("pokalert", soundId);
		SoundEvent soundEvent = new SoundEvent(shotSoundLocation);
		soundEvent.setRegistryName(shotSoundLocation);
		return soundEvent;
	}
}
public class SoundRegisterListener 
{
  @SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
  public void registerSOundEvents(RegistryEvent.Register<SoundEvent> event) {
	  event.getRegistry().registerAll(SoundRegistrator.BOND);
  }
}
EntityPlayer player = Minecraft.getMinecraft().player;
EntityPlayerSP sp = (EntityPlayerSP)player;
ResourceLocation location = new ResourceLocation("pokalert", "bond");
SoundEvent sevent = new SoundEvent(location);
sp.playSound(sevent, 5.0f, 5.0f);
{
  "bond": {
    "category": "player",
    "sounds": [{ "name": "pokalert:bond.ogg", "stream": true }]
    }
}

 

Link to comment
Share on other sites

24 minutes ago, CrashDbo said:

I think you want registerSoundEvent, not registerSOundEvent.

The method name does not matter in this case.

 

1 hour ago, outflows said:

static { BOND = addSoundsToRegistry("bond"); }

Do not statically instantiate your sounds. Instantiate and register them in the appropriate event.

  • Thanks 1

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

1 hour ago, DavidM said:

The method name does not matter in this case.

 

Do not statically instantiate your sounds. Instantiate and register them in the appropriate event.

what would the appropriate event be? Also, would I put the eventbus for this in the init or preinit? One last thing, the sound file I'm using is like 3 minutes long so would that affect anything?

Edited by outflows
Link to comment
Share on other sites

1.

2 hours ago, outflows said:

what would the appropriate event be?

This:

5 hours ago, outflows said:

public void registerSOundEvents(RegistryEvent.Register<SoundEvent> event) { event.getRegistry().registerAll(SoundRegistrator.BOND); }

In this event subscriber, instead of doing:

event.getRegistry().registerAll(SoundRegistrator.BOND);

, create the SoundEvents instead. Something similar to:

event.getRegistry().registerAll(new SoundEvent(...).setRegistryName(...), new SoundEvent(...)...);

 

2.

2 hours ago, outflows said:

would I put the eventbus for this in the init or preinit

If I'm understanding what you are doing correctly, you should not need init or preinit.

All your sound registration goes in the RegistryEvent.Register<SoundEvent> event subscriber.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

2 minutes ago, DavidM said:

 

This:

In this event subscriber, instead of doing:


event.getRegistry().registerAll(SoundRegistrator.BOND);

, create the SoundEvents instead. Something similar to:


event.getRegistry().registerAll(new SoundEvent(...).setRegistryName(...), new SoundEvent(...)...);

Thanks for the help with that but I have one more question if you don't mind helping. Although this is somewhat unrelated, I've been searching through forum posts for hours now and can't figure out how to make the sound follow the player. If you could help that would be awesome

Link to comment
Share on other sites

Just now, diesieben07 said:

Check out MovingSoundMinecart.

Yes, I have seen you on like 3 other posts saying that. I looked at the class and I didn't really understand how on earth I was supposed to implement that into my code. Granted I only started modding like a week ago. I actually figured it out though for anyone who wants to know. It's incredibly simple:

 

Minecraft.getMinecraft().getSoundHandler().playSound(PositionedSoundRecord.getMusicRecord(SoundEvent));

Link to comment
Share on other sites

4 minutes ago, diesieben07 said:

Minecraft#getSoundHandler()#sndManager#playingSounds. Note that both sndManager and playingSounds are private fields, so you'll have to use reflection to access them.

For some reason I'm getting an error while trying to call this. I don't know if you meant to put the pound signs there but maybe that's some syntax I'm unfamiliar with. I am also unfamiliar with reflection if you could help me out there too.

Link to comment
Share on other sites

The "#" is the same as a ".", it just means "instance method" "instance" rather than "static method" "static"

Read https://stackoverflow.com/questions/37628/what-is-reflection-and-why-is-it-useful

Then use the ObfuscationReflectionHelper (only in Forge versions above 2782)

Edited by Cadiboo
  • Like 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

My bad, It doesn't have to be a method, it can also be a field.

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Just now, Cadiboo said:

My bad, It doesn't have to be a method, it can also be a field.

So how would I format it so that I don't get the error. Sorry btw I'm really new to modding and I didn't learn any of this in my java class for whatever reason

Link to comment
Share on other sites

Minecraft.getMinecraft().getSoundHandler().sndManager.playingSounds.

As diesieben07 said, sndManager and playingSounds are private, so you will need to use Reflection or an Access Transformer to access them.

  • Thanks 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

1 minute ago, Cadiboo said:

Minecraft.getMinecraft().getSoundHandler().sndManager.playingSounds.

As diesieben07 said, sndManager and playingSounds are private, so you will need to use Reflection or an Access Transformer to access them.

Oh I see, that makes more sense now. Thanks for all the help.

Link to comment
Share on other sites

7 minutes ago, Cadiboo said:

Minecraft.getMinecraft().getSoundHandler().sndManager.playingSounds.

As diesieben07 said, sndManager and playingSounds are private, so you will need to use Reflection or an Access Transformer to access them.

I'm sorry to keep asking questions but I am thoroughly confused as to how I can use reflection to get these methods. Right now I have:

 

Minecraft mc = Minecraft.getMinecraft();
Method method = mc.getClass().getMethod("sndManager", null);

Link to comment
Share on other sites

26 minutes ago, Cadiboo said:

Then use the ObfuscationReflectionHelper (only in Forge versions above 2782)

Example of something similar (getting and then setting Minecraft#blockRendererDispatcher#fluidRenderer) https://github.com/Cadiboo/NoCubes/blob/ef2968d83544597fd5d267e476742beb2ec9a177/src/main/java/io/github/cadiboo/nocubes/client/ClientProxy.java#L89 

  • Thanks 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

2 hours ago, Cadiboo said:

Example of something similar (getting and then setting Minecraft#blockRendererDispatcher#fluidRenderer) https://github.com/Cadiboo/NoCubes/blob/ef2968d83544597fd5d267e476742beb2ec9a177/src/main/java/io/github/cadiboo/nocubes/client/ClientProxy.java#L89 

Hey so I tried using reflection to get the necessary fields and it works the first time to obtain the sndManager object but when I try to use that in order to obtain the playingSounds variable, I end up getting an error because it apparently doesn't exist as an instance variable of the sndManager object. I tried checking to see what fields I get from the sndManager object but none of them were the same as in the SoundManager class. All I remember was that one of the fields was clazz and another was fieldAccessor. I really hope you can help me because I've been stuck on this problem for hours now. Here is my code: 

 

        SoundHandler sh = Minecraft.getMinecraft().getSoundHandler();
        Class cls = sh.getClass();
        Class snd = cls.getDeclaredField("sndManager").getClass();
        Field ps = snd.getDeclaredField("playingSounds");

Link to comment
Share on other sites

1 hour ago, diesieben07 said:
  • Do not use getClass to get class object. Use class literals (Foo.class).
  • You need to use the methods in ObfuscationReflectionHelper and you need to use SRG names.  Otherwise your code will not work outside the development environment.

It would really help if you could show me how to do it because I am very lost at the moment

Link to comment
Share on other sites

3 minutes ago, diesieben07 said:

Which part do you have problems with exactly...?

Well I have no idea how to format this tbh. Also, I don't know what SRG means and how to use the helper thing. If you could just at least give me a template for how I could access the playingSounds method that would be awesome

Link to comment
Share on other sites

1 hour ago, diesieben07 said:

Minecraft code is obfuscated when it is distributed by Mojang. Forge uses MCP mappings to translate the obfuscated names to readable names. The SRG names are an intermediary step in this process. You can use the MCPBot (see linked page) to look up the SRG name for any method or field.

This is what I was able to get but it definitely does not work

 

        Class mc = Minecraft.class;
        java.lang.reflect.Method sh = mc.getMethod("getSoundHandler", null);
        sh.setAccessible(true);
        SoundHandler soundH = (SoundHandler)sh.invoke(mc, null);
        ObfuscationReflectionHelper.getPrivateValue(soundH.class, new Object(), "playingSounds");

Link to comment
Share on other sites

3 minutes ago, diesieben07 said:
  • Do not use getPrivateValue. Use findField, etc. to get the Field / Method instance.
  • Please learn the basics of reflection.

I'm sorry, I've been trying to learn it but it's not very intuitive for me. Should I be using the ObfuscationReflectionHelper to get the soundhandler as well?

Edited by outflows
Link to comment
Share on other sites

37 minutes ago, diesieben07 said:
  • Do not use getPrivateValue. Use findField, etc. to get the Field / Method instance.
  • Please learn the basics of reflection.

I can't find any info online about SRG names and the website that they use is down for some reason. I am just really confused right now

Link to comment
Share on other sites

You need

- the SoundHandler instance from getSoundHandler

- Field Objects for sndManager and playingSounds

Then get the value of each field using Field#get on the appropriate instance.

 

Critique:

9 hours ago, outflows said:

Class mc = Minecraft.class;

Why do you store this in a variable? You only use it once

9 hours ago, outflows said:

java.lang.reflect.Method

Why is this fully qualified?

9 hours ago, outflows said:

Method sh = mc.getMethod("getSoundHandler", null);

Isn’t this method public?

9 hours ago, outflows said:

ObfuscationReflectionHelper.getPrivateValue(soundH.class, new Object(), "playingSounds");

What is soundH? The SoundHandler doesn’t have this value, the SoundManager does. The SoundHandler  has an instance of the SoundManager which you need to get though (sndManager). You also need to use the SRG name of the field which you can look up at many places.

  • Thanks 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • BALON168🎈: Situs Slot Gacor Terbaik, Termewah, dan Tergacor 2024 dengan RTP 99,99% Mudah Maxwin Jika Anda pencinta judi online, mencari situs yang dapat diandalkan dan memberikan pengalaman bermain yang memuaskan tentu menjadi prioritas. Salah satu opsi terbaik yang patut dipertimbangkan adalah BALON168🎈. Situs ini tidak hanya menawarkan berbagai permainan slot yang menarik, tetapi juga mempersembahkan keunggulan dan kenyamanan bagi para pemainnya. Keunggulan BALON168🎈 BALON168🎈 tidak hanya sekadar situs slot online biasa. Dengan reputasi yang solid dan terpercaya, BALON168🎈 telah menjadi destinasi favorit bagi para penggemar judi online di tahun 2024. Keunggulan yang ditawarkan mencakup: 1. RTP Tinggi 99,99% Salah satu hal yang membuat BALON168🎈 menonjol adalah tingkat pengembalian (RTP) yang luar biasa tinggi, mencapai 99,99%. Ini berarti pemain memiliki peluang besar untuk memenangkan hadiah besar setiap kali mereka memutar gulungan di slot BALON168🎈. 2. Permainan Slot Gacor BALON168🎈 dikenal sebagai situs slot gacor terbaik di tahun 2024. "Gacor" adalah istilah yang digunakan untuk mesin slot yang sering memberikan kemenangan kepada pemainnya. Dengan koleksi permainan slot yang beragam dan sering memberikan jackpot besar, BALON168🎈 memastikan pengalaman bermain yang memuaskan bagi para pengunjungnya. 3. Maxwin yang Mudah Di BALON168🎈, peluang maxwin tidak hanya menjadi impian belaka. Dengan fitur yang mudah dimengerti dan diakses, pemain memiliki kesempatan yang besar untuk meraih kemenangan maksimum dalam setiap permainan yang mereka mainkan. Keamanan dan Kepuasan Pemain BALON168🎈 mengutamakan keamanan dan kepuasan para pemainnya. Dengan sistem keamanan terkini dan perlindungan data yang canggih, para pemain dapat bermain dengan tenang tanpa khawatir tentang privasi dan keamanan mereka. Layanan pelanggan yang responsif dan ramah juga selalu siap membantu para pemain dalam setiap masalah atau pertanyaan yang mereka miliki.       ❱❱❱❱❱ DAFTAR DI SINI ❰❰❰❰❰ ❱❱❱❱❱ DAFTAR AKUN PRO ❰❰❰❰❰ ❱❱❱❱❱ DAFTAR AKUN VIP ❰❰❰❰❰            
    • LadangToto2 adalah pilihan terbaik bagi Anda yang mencari pengalaman bermain slot gacor dengan transaksi mudah menggunakan Bank Mestika. Berikut adalah beberapa alasan mengapa Anda harus memilih LadangToto2: Slot Gacor Terbaik Kami menyajikan koleksi slot gacor terbaik yang menawarkan kesenangan bermain dan peluang kemenangan besar. Dengan fitur-fitur unggulan dan tema-tema menarik, setiap putaran permainan akan memberikan Anda pengalaman yang tak terlupakan. Transaksi Mudah dengan Bank Mestika Kami menyediakan layanan transaksi mudah melalui Bank Mestika untuk kenyamanan dan keamanan Anda. Dengan proses yang cepat dan efisien, Anda dapat melakukan deposit dan penarikan dana dengan lancar dan tanpa hambatan. Hadiah Hingga 100 Juta LadangToto2 memberikan kesempatan untuk meraih hadiah hingga 100 juta dalam kemenangan. Dengan jackpot dan hadiah-hadiah besar yang ditawarkan, setiap putaran permainan bisa menjadi peluang untuk meraih keberuntungan besar.  
    • Mengapa Memilih LadangToto? LadangToto adalah pilihan terbaik bagi Anda yang mencari pengalaman bermain slot gacor WD Maxwin dengan transaksi mudah menggunakan Bank BNI. Berikut adalah beberapa alasan mengapa Anda harus memilih LadangToto: Slot Gacor WD Maxwin Terbaik Kami menyajikan koleksi slot gacor WD Maxwin terbaik yang menawarkan kesenangan bermain dan peluang kemenangan besar. Dengan fitur-fitur unggulan dan tema-tema menarik, setiap putaran permainan akan memberikan Anda pengalaman yang tak terlupakan. Transaksi Mudah dengan Bank BNI Kami menyediakan layanan transaksi mudah melalui Bank BNI untuk kenyamanan dan keamanan Anda. Dengan proses yang cepat dan efisien, Anda dapat melakukan deposit dan penarikan dana dengan lancar dan tanpa hambatan.  
    • Akun Pro Kamboja adalah pilihan terbaik bagi Anda yang mencari pengalaman bermain slot Maxwin dengan transaksi mudah menggunakan Bank Lampung. Berikut adalah beberapa alasan mengapa Anda harus memilih Akun Pro Kamboja: Slot Maxwin Terbaik Kami menyajikan koleksi slot Maxwin terbaik yang menawarkan kesenangan bermain dan peluang kemenangan besar. Dengan fitur-fitur unggulan dan tema-tema menarik, setiap putaran permainan akan memberikan Anda pengalaman yang tak terlupakan. Transaksi Mudah dengan Bank Lampung Kami menyediakan layanan transaksi mudah melalui Bank Lampung untuk kenyamanan dan keamanan Anda. Dengan proses yang cepat dan efisien, Anda dapat melakukan deposit dan penarikan dana dengan lancar dan tanpa hambatan. Anti Rungkat Akun Pro Kamboja memberikan jaminan "anti rungkat" kepada para pemainnya. Dengan fitur ini, Anda dapat merasakan sensasi bermain dengan percaya diri, karena kami memastikan pengalaman bermain yang adil dan menyenangkan bagi semua pemain.  
    • BINGO188: Destinasi Terbaik untuk Pengalaman Slot yang Terjamin Selamat datang di BINGO188, tempat terbaik bagi para pecinta slot yang mencari pengalaman bermain yang terjamin dan penuh kemenangan. Di sini, kami menawarkan fitur unggulan yang dirancang untuk memastikan kepuasan dan keamanan Anda. Situs Slot Garansi Kekalahan 100 Kami memahami bahwa kadang-kadang kekalahan adalah bagian dari permainan. Namun, di BINGO188, kami memberikan jaminan keamanan dengan fitur garansi kekalahan 100. Jika Anda mengalami kekalahan, kami akan mengembalikan saldo Anda secara penuh. Kemenangan atau uang kembali, kami memastikan Anda tetap merasa aman dan nyaman. Bebas IP Tanpa TO Nikmati kebebasan bermain tanpa batasan IP dan tanpa harus khawatir tentang TO (Turn Over) di BINGO188. Fokuslah pada permainan Anda dan rasakan sensasi kemenangan tanpa hambatan. Server Thailand Paling Gacor Hari Ini Bergabunglah dengan server terbaik di Thailand hanya di BINGO188! Dengan tingkat kemenangan yang tinggi dan pengalaman bermain yang lancar, server kami dijamin akan memberikan Anda pengalaman slot yang tak tertandingi. Kesimpulan BINGO188 adalah pilihan terbaik bagi Anda yang menginginkan pengalaman bermain slot yang terjamin dan penuh kemenangan. Dengan fitur situs slot garansi kekalahan 100, bebas IP tanpa TO, dan server Thailand paling gacor hari ini, kami siap memberikan Anda pengalaman bermain yang aman, nyaman, dan menguntungkan. Bergabunglah sekarang dan mulailah petualangan slot Anda di BINGO188!
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.