Jump to content

[1.13.2] GUI wont open


TheRedMelon

Recommended Posts

I right click on the block and nothing happens.  All relevant code below.  If I'm missing something you need to see, just let me know ?.

I've looked at previous threads where people ask for help and looked for their code as examples but can't figure out where I'm going wrong.

 

GUI Class:

Spoiler

public class GUIThreefoldCombiner extends GuiContainer {
	
	private static final ResourceLocation TEXTURE = new ResourceLocation(Reference.MOD_ID + ":textures/gui/threefold_combiner.png");
	
	public GUIThreefoldCombiner(InventoryPlayer inventory, TileEntityThreefoldCombiner te) {
		
		super(new ContainerThreefoldCombiner(inventory, te));
		
	}
	
	@Override
	public void render(int mouseX, int mouseY, float partialTicks) {

		drawDefaultBackground();
		super.render(mouseX, mouseY, partialTicks);
		renderHoveredToolTip(mouseX, mouseY);
		
	}

	@Override
	protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
		
		mc.getTextureManager().bindTexture(TEXTURE);
		drawModalRectWithCustomSizedTexture(guiLeft, guiTop, 0, 0, xSize, ySize, xSize, ySize);
		
	}
	
}

 

 

Main Class with GUI Handler:

Spoiler

@Mod(Reference.MOD_ID)
public class EnhancedMechanisms {

	public EnhancedMechanisms() {
		
		ModLoadingContext.get().registerExtensionPoint(ExtensionPoint.GUIFACTORY, () -> {
			
			return (OpenContainer) -> {
				
				ResourceLocation loc = OpenContainer.getId();
				
				if (loc.toString().equals(Reference.MOD_ID + ":threefold_combiner")) {
					
					EntityPlayerSP player = Minecraft.getInstance().player;
					BlockPos pos = OpenContainer.getAdditionalData().readBlockPos();
					TileEntity te = player.world.getTileEntity(pos);
					
					if (te instanceof TileEntityThreefoldCombiner) {
						
						return new GUIThreefoldCombiner(player.inventory, (TileEntityThreefoldCombiner) te);
						
					}
					
				}
				
				return null;
				
			};
			
		});
		
	}
	
}

 

 

onBlockActived:

Spoiler

	@Override
	public boolean onBlockActivated(IBlockState state, World worldIn, BlockPos pos, EntityPlayer player, EnumHand hand, EnumFacing side, float hitX, float hitY, float hitZ) {
		
		if (worldIn.isRemote) {
			
			return true;
			
		} else {
			
			TileEntity tEntity = worldIn.getTileEntity(pos);
			
			if (tEntity instanceof TileEntityThreefoldCombiner) {
				
				NetworkHooks.openGui((EntityPlayerMP) player, (TileEntityThreefoldCombiner) tEntity, pos);
				
			}
			
			return true;
			
		}
		
	}

 

 

Tile Entity createContainer & getGuiID:

Spoiler

	@Override
	public Container createContainer(InventoryPlayer playerInventory, EntityPlayer playerIn) {

		return new ContainerThreefoldCombiner(playerInventory, this);
		
	}

	@Override
	public String getGuiID() {

		return Reference.MOD_ID + ":threefold_combiner";
		
	}

 

 

Tile Entity Registry:

Spoiler

	public static TileEntityType<TileEntityThreefoldCombiner> tileEntityThreefoldCombiner;

	@SubscribeEvent
	public static void OnRegisterTileEntities (RegistryEvent.Register<TileEntityType<?>> e) {
		
		tileEntityThreefoldCombiner = TileEntityType.register(Reference.MOD_ID + ":threefold_combiner", TileEntityType.Builder.create(TileEntityThreefoldCombiner::new));
		
	}

 

 

Thanks for any help.

Link to comment
Share on other sites

9 hours ago, TheRedMelon said:

new ResourceLocation(Reference.MOD_ID + ":textures/gui/threefold_combiner.png");

Don’t use this constructor, use the constructor that takes in your modid and the path as separate parameters.

 

9 hours ago, TheRedMelon said:

NetworkHooks.openGui((EntityPlayerMP) player, (TileEntityThreefoldCombiner) tEntity, pos);

I’m not sure that this is the correct way to open a mod GUI in 1.13.2.

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

above the method openGui in NetworkHooks, it specifically says "Request to open a GUI on the client, from the server", so I'm pretty sure this isn't the correct method. We used to use the openGui method in EntityPlayer, but that no longer exists, nor does the class FMLNetworkHandler exist.

Edited by KingIceCream
Link to comment
Share on other sites

Hold on, try replacing 

if (worldIn.isRemote) {
			
	return true;
			
} else {
			
	TileEntity tEntity = worldIn.getTileEntity(pos);
			
	if (tEntity instanceof TileEntityThreefoldCombiner) {
				
		NetworkHooks.openGui((EntityPlayerMP) player, (TileEntityThreefoldCombiner) tEntity, pos);
				
	}
			
	return true;
			
}

with

if (!worldIn.isRemote) {
			
	TileEntity tEntity = worldIn.getTileEntity(pos);
	NetworkHooks.openGui((EntityPlayerMP) player, (TileEntityThreefoldCombiner) tEntity, pos);
}
return true;

 

Link to comment
Share on other sites

I'm using the proper ResourceLocation  constructor now.

I tried changing that code like KingIceCream said, it basically does the same thing though so nothing changed.  I followed it through with the debugger and it gets to the GUI Factory and runs

return new GUIThreefoldCombiner(player.inventory, (TileEntityThreefoldCombiner) te);

So I think the issue is with the GUI or Container perhaps.

Link to comment
Share on other sites

4 hours ago, KingIceCream said:

Could you post or dm me all of the code so I can try to debug it more easily? (Like, all the code.

The best way to do this is to post your code as a working GitHub repository 

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Can you post your code as a GitHub repo?

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I have a problem, I am trying to put two different effects to two different armors but when I run it only the emerald armor effect works. This is the code public class ModArmorItem extends ArmorItem{ private static final Map<ArmorMaterial, MobEffectInstance> MATERIAL_TO_EFFECT_MAP = (new ImmutableMap.Builder<ArmorMaterial, MobEffectInstance>()) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.HERO_OF_THE_VILLAGE,200, 1,false,false, true)) .put(ModArmorMaterials.OBSIDIAN, new MobEffectInstance(MobEffects.FIRE_RESISTANCE,200, 1,false,false, true)).build(); public ModArmorItem(ArmorMaterial pMaterial, Type pType, Properties pProperties) { super(pMaterial, pType, pProperties); } @Override public void onArmorTick(ItemStack stack, Level world, Player player){ if (!world.isClientSide()) { if (hasFullSuitOfArmorOn(player)) { evaluateArmorEffects(player); } } } private void evaluateArmorEffects(Player player) { for (Map.Entry<ArmorMaterial,MobEffectInstance> entry : MATERIAL_TO_EFFECT_MAP.entrySet()){ ArmorMaterial mapArmorMaterial = entry.getKey(); MobEffectInstance mapStatusEffect = entry.getValue(); if (hasCorrectArmorOn(mapArmorMaterial, player)) { addStatusEffectForMaterial(player, mapArmorMaterial, mapStatusEffect); } } } private void addStatusEffectForMaterial(Player player, ArmorMaterial mapArmorMaterial, MobEffectInstance mapStatusEffect) { boolean hasPlayerEffect = player.hasEffect(mapStatusEffect.getEffect()); if (hasCorrectArmorOn(mapArmorMaterial, player) && !hasPlayerEffect) { player.addEffect(new MobEffectInstance(mapStatusEffect)); } } private boolean hasCorrectArmorOn(ArmorMaterial material, Player player) { for (ItemStack armorStack : player.getInventory().armor){ if (!(armorStack.getItem() instanceof ArmorItem)) { return false; } } ArmorItem helmet = ((ArmorItem)player.getInventory().getArmor(3).getItem()); ArmorItem breastplace = ((ArmorItem)player.getInventory().getArmor(2).getItem()); ArmorItem leggins = ((ArmorItem)player.getInventory().getArmor(1).getItem()); ArmorItem boots = ((ArmorItem)player.getInventory().getArmor(0).getItem()); return helmet.getMaterial() == material && breastplace.getMaterial() == material && leggins.getMaterial() == material && boots.getMaterial() == material; } private boolean hasFullSuitOfArmorOn(Player player){ ItemStack helmet = player.getInventory().getArmor(3); ItemStack breastplace = player.getInventory().getArmor(2); ItemStack leggins = player.getInventory().getArmor(1); ItemStack boots = player.getInventory().getArmor(0); return !helmet.isEmpty() && !breastplace.isEmpty() && !leggins.isEmpty() && !boots.isEmpty(); } } Also when I place two effects on the same armor, the game crashes. Here is the crash file. The code is the same, only this part is different   private static final Map<ArmorMaterial, MobEffectInstance> MATERIAL_TO_EFFECT_MAP = (new ImmutableMap.Builder<ArmorMaterial, MobEffectInstance>()) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.HERO_OF_THE_VILLAGE,200, 1,false,false, true)) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.FIRE_RESISTANCE,200, 1,false,false, true)).build(); I hope you guys can help me. Thanks.
    • I removed all related embeddium and oculus mods, i just tested it by disconnecting and the error happened again. heres the report https://pastebin.com/1kcR5wAt   EDIT: i tried removing xaeros and also smoothboot thinking there may be an issue there, nothing, heres that report too. https://pastebin.com/zQS7i9rM
    • Hi, I need suggestions. I am a beginner in Minecraft Modding. I would like to apply custom effects to some armors, something like: more chance to drop seeds, change zombie awareness, drop more pieces of wood when chopping logs, and things like that. How would you recommend me to do it, is there any library that has something similar and which ones would you recommend me?.
    • "downloading minecraft server failed, invalid Checksum. try again, or manually place server.jar to skip download"    
    • You have to create an Entity class called PlayerPart and use multiple of them to make the different parts of the player. See EnderDragonPart.java source code. The green hitboxes of the dragon are all EnderDragonParts
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.