[1.12.2] Custom Tree Problems

[nov4e]

Hello. I'm trying to make a custom tree. For now I maded the log(that extends BlockLog) and the leaves(extends BlockLeaves).

When I place the actual block game crashes saying it has not log axis ecc... 

Same for leaves.

How can I setup these things? I have seen a tutorial how to do it with metadata but i want a single item.

Thanks for the help.

Edited April 18, 2019 by nov4e

[Cadiboo]

Post your code and the crash. You probably want to extend the base log and leaves classes rather than the vanilla ones that have the variants hardcoded

[nov4e]

Well, I fixed this error. I just setted the blockstates with enum axis ec...

But I have another issue. First of all, these are the classes:

 

GenerateMysticTree, the tree WorldGenAbstractTree class.

Spoiler

package com.minecraft.exa.trees;

import java.util.Random;

import com.minecraft.exa.features.ModBlocks;

import net.minecraft.block.BlockLeaves;
import net.minecraft.block.BlockVine;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.PropertyBool;
import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Blocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.gen.feature.WorldGenAbstractTree;

public class GenerateMysticTree extends WorldGenAbstractTree
{
	
	private static final IBlockState DEFAULT_TRUNK = ModBlocks.MYSTIC_LOG.getDefaultState();
	private static final IBlockState DEFAULT_LEAF = ModBlocks.MYSTIC_LEAVES.getDefaultState().withProperty(BlockLeaves.CHECK_DECAY, Boolean.valueOf(false));
	
	private final int minTreeHeight = 4;
	private final boolean vinesGrow = true;
	private final IBlockState metaWood = DEFAULT_TRUNK;
	private final IBlockState metaLeaves = DEFAULT_LEAF;

	public GenerateMysticTree()
	{
		super(false);
	}

	@Override
	public boolean generate(World world, Random rand, BlockPos pos)
	{
		int i = rand.nextInt(3) + this.minTreeHeight;
		boolean flag = true;

		if (pos.getY() >= 1 && pos.getY() + i + 1 <= world.getHeight())
		{
			for (int j = pos.getY(); j <= pos.getY() + 1 + i; ++j)
			{
				int k = 1;

				if (j == pos.getY())
				{
					k = 0;
				}

				if (j >= pos.getY() + 1 + i - 2)
				{
					k = 2;
				}

				BlockPos.MutableBlockPos blockpos$mutableblockpos = new BlockPos.MutableBlockPos();

				for (int l = pos.getX() - k; l <= pos.getX() + k && flag; ++l)
				{
					for (int i1 = pos.getZ() - k; i1 <= pos.getZ() + k && flag; ++i1)
					{
						if (j >= 0 && j < world.getHeight())
						{
							if (!this.isReplaceable(world,blockpos$mutableblockpos.setPos(l, j, i1)))
							{
								flag = false;
							}
						}
						else
						{
							flag = false;
						}
					}
				}
			}

			if (!flag)
			{
				return false;
			}
			else
			{
				IBlockState state = world.getBlockState(pos.down());

				if (state.getBlock().canSustainPlant(state, world, pos.down(), net.minecraft.util.EnumFacing.UP, (net.minecraft.block.BlockSapling)Blocks.SAPLING) && pos.getY() < world.getHeight() - i - 1)
				{
					this.setDirtAt(world, pos.down());
					int k2 = 3;
					int l2 = 0;

					for (int i3 = pos.getY() - 3 + i; i3 <= pos.getY() + i; ++i3)
					{
						int i4 = i3 - (pos.getY() + i);
						int j1 = 1 - i4 / 2;

						for (int k1 = pos.getX() - j1; k1 <= pos.getX() + j1; ++k1)
						{
							int l1 = k1 - pos.getX();

							for (int i2 = pos.getZ() - j1; i2 <= pos.getZ() + j1; ++i2)
							{
								int j2 = i2 - pos.getZ();

								if (Math.abs(l1) != j1 || Math.abs(j2) != j1 || rand.nextInt(2) != 0 && i4 != 0)
								{
									BlockPos blockpos = new BlockPos(k1, i3, i2);
									state = world.getBlockState(blockpos);

									if (state.getBlock().isAir(state, world, blockpos) || state.getBlock().isLeaves(state, world, blockpos) || state.getMaterial() == Material.VINE)
									{
										this.setBlockAndNotifyAdequately(world, blockpos, this.metaLeaves);
									}
								}
							}
						}
					}

					for (int j3 = 0; j3 < i; ++j3)
					{
						BlockPos upN = pos.up(j3);
						state = world.getBlockState(upN);

						if (state.getBlock().isAir(state, world, upN) || state.getBlock().isLeaves(state, world, upN) || state.getMaterial() == Material.VINE)
						{
							this.setBlockAndNotifyAdequately(world, pos.up(j3), this.metaWood);

							if (this.vinesGrow && j3 > 0)
							{
								if (rand.nextInt(3) > 0 && world.isAirBlock(pos.add(-1, j3, 0)))
								{
									this.addVine(world, pos.add(-1, j3, 0), BlockVine.EAST);
								}

								if (rand.nextInt(3) > 0 && world.isAirBlock(pos.add(1, j3, 0)))
								{
									this.addVine(world, pos.add(1, j3, 0), BlockVine.WEST);
								}

								if (rand.nextInt(3) > 0 && world.isAirBlock(pos.add(0, j3, -1)))
								{
									this.addVine(world, pos.add(0, j3, -1), BlockVine.SOUTH);
								}

								if (rand.nextInt(3) > 0 && world.isAirBlock(pos.add(0, j3, 1)))
								{
									this.addVine(world, pos.add(0, j3, 1), BlockVine.NORTH);
								}
							}
						}
					}

					if (this.vinesGrow)
					{
						for (int k3 = pos.getY() - 3 + i; k3 <= pos.getY() + i; ++k3)
						{
							int j4 = k3 - (pos.getY() + i);
							int k4 = 2 - j4 / 2;
							BlockPos.MutableBlockPos blockpos$mutableblockpos1 = new BlockPos.MutableBlockPos();

							for (int l4 = pos.getX() - k4; l4 <= pos.getX() + k4; ++l4)
							{
								for (int i5 = pos.getZ() - k4; i5 <= pos.getZ() + k4; ++i5)
								{
									blockpos$mutableblockpos1.setPos(l4, k3, i5);

									state = world.getBlockState(blockpos$mutableblockpos1);
									if (state.getBlock().isLeaves(state, world, blockpos$mutableblockpos1))
									{
										BlockPos blockpos2 = blockpos$mutableblockpos1.west();
										BlockPos blockpos3 = blockpos$mutableblockpos1.east();
										BlockPos blockpos4 = blockpos$mutableblockpos1.north();
										BlockPos blockpos1 = blockpos$mutableblockpos1.south();

										if (rand.nextInt(4) == 0 && world.isAirBlock(blockpos2))
										{
											this.addHangingVine(world, blockpos2, BlockVine.EAST);
										}

										if (rand.nextInt(4) == 0 && world.isAirBlock(blockpos3))
										{
											this.addHangingVine(world, blockpos3, BlockVine.WEST);
										}

										if (rand.nextInt(4) == 0 && world.isAirBlock(blockpos4))
										{
											this.addHangingVine(world, blockpos4, BlockVine.SOUTH);
										}

										if (rand.nextInt(4) == 0 && world.isAirBlock(blockpos1))
										{
											this.addHangingVine(world, blockpos1, BlockVine.NORTH);
										}
									}
								}
							}
						}

					}

					return true;
				}
				else
				{
					return false;
				}
			}
		}
		else
		{
			return false;
		}
	}

	private void addVine(World worldIn, BlockPos pos, PropertyBool prop)
	{
		this.setBlockAndNotifyAdequately(worldIn, pos, Blocks.VINE.getDefaultState().withProperty(prop, Boolean.valueOf(true)));
	}

	private void addHangingVine(World worldIn, BlockPos pos, PropertyBool prop)
	{
		this.addVine(worldIn, pos, prop);
		int i = 4;

		for (pos = pos.down(); worldIn.isAirBlock(pos) && i > 0; --i)
		{
			this.addVine(worldIn, pos, prop);
			pos = pos.down();
		}
	}
}	
	

 

MysticSaplingWood, The sapling class:

Spoiler

package com.minecraft.exa.block;

import java.util.Random;

import com.minecraft.exa.trees.GenerateMysticTree;

import net.minecraft.block.BlockBush;
import net.minecraft.block.IGrowable;
import net.minecraft.block.SoundType;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyInteger;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Blocks;
import net.minecraft.util.math.AxisAlignedBB;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraft.world.gen.feature.WorldGenBigTree;
import net.minecraft.world.gen.feature.WorldGenTrees;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.event.terraingen.TerrainGen;

public class MysticSaplingWood extends BlockBush implements IGrowable
{
	
	public static final PropertyInteger STAGE = PropertyInteger.create("stage", 0, 1);
	protected static final AxisAlignedBB SAPLING_AABB = new AxisAlignedBB(0.09999999403953552D, 0.0D, 0.09999999403953552D, 0.8999999761581421D, 0.800000011920929D, 0.8999999761581421D);	

	private static final String name = "sapling";
	
	public MysticSaplingWood() 
	{
		this.setRegistryName(name);
		this.setUnlocalizedName(name);
		
		this.setSoundType(SoundType.PLANT);
		
		this.setDefaultState(this.blockState.getBaseState().withProperty(STAGE, Integer.valueOf(0)));
	}
	
	@Override
	public AxisAlignedBB getBoundingBox(IBlockState state, IBlockAccess source, BlockPos pos)
	{
		return SAPLING_AABB;
	}
	
	@Override
	public boolean isOpaqueCube(IBlockState state) 
	{
		return false;
	}
	
	@Override
	public boolean isFullCube(IBlockState state) 
	{
		return false;
	}
	
	@Override
	public int damageDropped(IBlockState state)
	{
		return 0;
	}
	
	@Override
	public void updateTick(World world, BlockPos pos, IBlockState state, Random random)
	{
		if (!world.isRemote)
		{
			this.checkAndDropBlock(world, pos, state);
			if (world.getLightFromNeighbors(pos.up()) >= 9 && random.nextInt(7) == 0)
			{
 
			}
		}
	}

	@Override
	public boolean canGrow(World world, BlockPos pos, IBlockState state, boolean isClient)
	{
		return true;
	}

	@Override
	public boolean canUseBonemeal(World world, Random rand, BlockPos pos, IBlockState state)
	{
		return (double)world.rand.nextFloat() < 0.45D;
	}

	@Override
	protected boolean canSustainBush(IBlockState state) 
	{
		return state.getBlock() == Blocks.GRASS || state.getBlock() == Blocks.DIRT || state.getBlock() == Blocks.FARMLAND;
	}
	
	public static void generateTree(World world, Random rand, BlockPos pos, IBlockState state)
	{
		if (!TerrainGen.saplingGrowTree(world, rand, pos)) return;
		WorldGenerator worldgenerator = (WorldGenerator)(rand.nextInt(10) == 0 ? new GenerateMysticTree() : new GenerateMysticTree());
		int i, j = 0;
		boolean flag =false;
		
		
		IBlockState air = Blocks.AIR.getDefaultState();
		
		if(flag)
		{
			world.setBlockState(pos.add(0,0,0), air, 4);
			world.setBlockState(pos.add(1,0,0), air, 4);
			world.setBlockState(pos.add(0,0,1), air, 4);
			world.setBlockState(pos.add(1,0,0), air, 4);
		}
		else
		{
			world.setBlockState(pos, air, 4);
		}
		
		if(worldgenerator.generate(world, rand, pos))
		{
			if(flag)
			{
				world.setBlockState(pos.add(0,0,0), air, 4);
				world.setBlockState(pos.add(1,0,0), air, 4);
				world.setBlockState(pos.add(0,0,1), air, 4);
				world.setBlockState(pos.add(1,0,0), air, 4);
			}
			else
			{
				world.setBlockState(pos, air, 4);
			}
		}
	}
	
	@Override
	public void grow(World world, Random rand, BlockPos pos, IBlockState state)
	{
		if(((int)state.getValue(STAGE).intValue() == 0))
		{
			world.setBlockState(pos, state.cycleProperty(STAGE), 4);
		} 
		else
		{
			this.generateTree(world, rand, pos, state);
		}
	}

	@Override
	public IBlockState getStateFromMeta(int meta)
	{
		return this.getDefaultState().withProperty(STAGE, Integer.valueOf((meta & 8) >> 3));
	}

	@Override
	public int getMetaFromState(IBlockState state)
	{
		int i = 0;
		i = i | ((Integer)state.getValue(STAGE)).intValue() << 3;
		return i;
	}
	
	@Override
	protected BlockStateContainer createBlockState()
	{
		return new BlockStateContainer(this, new IProperty[] { STAGE });
	}
	
}

 

 

The issue is that when the sapling grows it doesnt grows but theres a crash:

Quote

[15:12:02] [Server thread/FATAL] [minecraft/MinecraftServer]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: Could not initialize class com.minecraft.exa.trees.GenerateMysticTree
	at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_191]
	at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_191]
	at net.minecraft.util.Util.runTask(Util.java:54) [Util.class:?]
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:798) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:743) [MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) [IntegratedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:592) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_191]
Caused by: java.lang.NoClassDefFoundError: Could not initialize class com.minecraft.exa.trees.GenerateMysticTree
	at com.minecraft.exa.block.MysticSaplingWood.generateTree(MysticSaplingWood.java:100) ~[MysticSaplingWood.class:?]
	at com.minecraft.exa.block.MysticSaplingWood.grow(MysticSaplingWood.java:144) ~[MysticSaplingWood.class:?]
	at net.minecraft.item.ItemDye.applyBonemeal(ItemDye.java:131) ~[ItemDye.class:?]
	at net.minecraft.item.ItemDye.onItemUse(ItemDye.java:62) ~[ItemDye.class:?]
	at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:876) ~[ForgeHooks.class:?]
	at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:200) ~[ItemStack.class:?]
	at net.minecraft.server.management.PlayerInteractionManager.processRightClickBlock(PlayerInteractionManager.java:518) ~[PlayerInteractionManager.class:?]
	at net.minecraft.network.NetHandlerPlayServer.processTryUseItemOnBlock(NetHandlerPlayServer.java:769) ~[NetHandlerPlayServer.class:?]
	at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:68) ~[CPacketPlayerTryUseItemOnBlock.class:?]
	at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:13) ~[CPacketPlayerTryUseItemOnBlock.class:?]
	at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) ~[PacketThreadUtil$1.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_191]
	at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_191]
	at net.minecraft.util.Util.runTask(Util.java:53) ~[Util.class:?]
	... 5 more

 

Thanks for all the help given. 

[nov4e]

Do I have to register the treegen in preinit?

Edited April 18, 2019 by nov4e

[nov4e]

What's the problem?

[nov4e]

2 minutes ago, diesieben07 said:

Does this crash happen in the development environment? Or in normal Minecraft?

In the test client in eclipse, also in the debug client.

[nov4e]

3 minutes ago, diesieben07 said:

What is a "test client" or "debug client"?

Developing Enviroment.

Just now I tried to rename the package, still not work.

 

Thanks for the help.

[nov4e]

Here is the repository:

https://github.com/nov4e/Exa

[nov4e]

Ok now should be fixed.

[nov4e]

9 hours ago, diesieben07 said:

The crash you reported does not happen with that repository. Instead I get a NullPointerException, because you never assign a value to ModBlocks.MYSTIC_LOG, but try to use it.

In ModBlocks I assigned MYSTIC_LOG to new MysticLogWood() (line 31)

[DavidM]

1. Update your repo.

2. "exa" is not a good mod id; 3 characters long name can cause conflicts.

3. This method is unnecessary; just do something like:

modBlocks.add(STATIC_BLOCK_HOLDER = new MyBlockThingy("blah"));

4. These loggings at info level are pointless; the player doesn't care what state mods are at, and logging random stuff at info level can clog up the log easily.

[Cadiboo]

1 minute ago, DavidM said:

modBlocks.add(STATIC_BLOCK_HOLDER = new MyBlockThingy("blah"));

@ObjectHolder instead pls

[nov4e]

38 minutes ago, DavidM said:

1. Update your repo.

Its updated

 

38 minutes ago, DavidM said:

2. "exa" is not a good mod id; 3 characters long name can cause conflicts.

Just why. There are no mods called exa

39 minutes ago, DavidM said:

This method is unnecessary; just do something like:

modBlocks.add(STATIC_BLOCK_HOLDER = new MyBlockThingy("blah"));

Why do I have to do that? Its just the same thing.

40 minutes ago, DavidM said:

4. These loggings at info level are pointless; the player doesn't care what state mods are at, and logging random stuff at info level can clog up the log easily.

I will remove them, its just for help me while developing.

[Cadiboo]

25 minutes ago, nov4e said:

Just why. There are no mods called exa

3 letters is still a bit too short to be unique. I also have no idea what “exa” means - you should be able to look at the modid and get a rough understanding of what the mod does & the modid and mod name should be really similar.

27 minutes ago, nov4e said:

Why do I have to do that? Its just the same thing.

Do you know what @ObjectHolder is? Do you know what static initialisers are? Do you know why static initialisers are bad for Modding? Well, here’s a paragraph explaining all of them.

 

Bad and improper registration code is the leading cause of bad and/or broken mods. These bad/broken mods can also break other mods that are doing everything right *and* improper registration stops Forge from being able to implement useful new features. These features that could be implemented by Forge include dynamically reloading the registries (adding/removing items while the game is running) and even adding/removing entire mods without restarting the game. Forge has wanted to enable these features for more than 4 years now, but mods that do their registration in the wrong way has been stopping this from happening.

For Forge to be able to do this (and for registry replacements to work properly) Mods need to instantiate and register their objects in the correct registry event. They also need to use references to their objects that can change as mods are loaded & unloaded (and registry replacements are activated/deactivated). Mods can do this by using the @ObjectHolder annotation (which automatically fills fields with the appropriate values after each registry event fires) or manually by setting their fields after all other registration has been done (by subscribing to the registry event and running after everything else). Mods that create and/or register their objects with static initialisers stop Forge from being able to do cool stuff AND they can break unexpectedly and uncontrollably if/when their registration classes are loaded before the expected time (you have no control over when your classes are loaded). Static initialisers are initialising objects inside a “static {}” block or doing “static Object object = new Object();” in a class.

[nov4e]

Ok I added @ObjectHolder in ModBlocks class: https://github.com/nov4e/Exa/blob/master/src/main/java/exa/minecraft/features/ModBlocks.java

But how can I fix the problem related to the tree gen?

 

Edit: Everything works now. The tree grows

Edited April 19, 2019 by nov4e

[DavidM]

56 minutes ago, nov4e said:

Just why. There are no mods called exa

This is not original but:

TiC is the name of a mod; its mod ID is tconstruct.

IC2 is the name of a mod; its mod ID is industrialcraft2.

 

58 minutes ago, nov4e said:

Why do I have to do that? Its just the same thing.

Creating an extra method just to assign a reference to a variable is unwise (considering memory usage, code readability and design pattern), especially when the Java language's syntax allows you to do it inline.

 

10 minutes ago, nov4e said:

But how can I fix the problem related to the tree gen?

Please update your crash log; the old one no longer applies to your updated repo (line numbers have changed).

[nov4e]

11 minutes ago, DavidM said:

Please update your crash log; the old one no longer applies to your updated repo (line numbers have changed).

Everything is fixed now. Setting the @ObjectHolder now for some reason works

[DavidM]

1. I'm pretty sure the string given to @ObjectHolder should include the mod id of your mod to avoid conflict.

2. Personally, I would avoid storing references to the same block in both a static field and a list; only one of them is needed (preferably the static field with @ObjectHolder).

3.

Quote

withProperty(STAGE, Integer.valueOf(0)))

Quote

withProperty(DECAYABLE, Boolean.valueOf(true)))

Wut? I’m pretty sure you can just use literals here.

Edited April 19, 2019 by DavidM

[Cadiboo]

9 hours ago, DavidM said:

Wut? I’m pretty sure you can just use literals here.

You can, but vanilla uses boxed values because it was written before autoboxing was a thing. 

[Cadiboo]

30 minutes ago, diesieben07 said:

Vanilla does not used boxed values. But vanilla code is decompiled, so autoboxing (which is done by the Java compiler) cannot be distinguished from manual boxing.

TIL. I thought autoboxing was done by the JVM for some reason. It makes a lot more sense that it’s the compiler though.