[1.12.2] Potion Effect stuck at 0 time left

[Seynox]

Hi!

I want the player that has less than 9 food level to get Mining Fatigue.

Everything is working except the Mining fatigue effect that get stuck at 0:00s left

I know i could easily fix that by clearing his Mining Fatigue effect but if that happen, i guess something is wrong

 

The code :

Spoiler

	int ticksworld;
	private static PotionEffect HungryFatigue = new PotionEffect(MobEffects.MINING_FATIGUE, 40, 0, false, false);

	@SubscribeEvent
	public void onWorldTick(WorldTickEvent event) {
		World world = event.world;
		EntityPlayer player = Minecraft.getMinecraft().player;
		
		if(!(player == null) && !(world == null)) {
		
		if(ticksworld == 20) {
			ticksworld = 0;
			
			if(player.getFoodStats().getFoodLevel() <= 9 && player.getActivePotionEffect(MobEffects.MINING_FATIGUE) == null) {
				
				player.addPotionEffect(HungryFatigue);
				
				System.out.println("Effect Added"); //I used this to check if it stacks, and no its not
				}
			
		} else {ticksworld++;}
	}
	}

 

 

[DavidM]

1. You should create a new PotionEffect each time; do not store it in a static field.

2. You cannot create a field and use it as the cool down value; the field will be “shared” across all players, thus will mess up your cool down.

3. Check World#isRemote to make sure your code is only ran on the server side.

[Seynox]

29 minutes ago, DavidM said:

1. You should create a new PotionEffect each time; do not store it in a static field.

2. You cannot create a field and use it as the cool down value; the field will be “shared” across all players, thus will mess up your cool down.

3. Check World#isRemote to make sure your code is only ran on the server side.

I now have that, but still stuck at 0:00

Spoiler

int ticksworld;
	@SubscribeEvent
	public void onWorldTick(WorldTickEvent event) {
		World world = event.world;
		EntityPlayer player = Minecraft.getMinecraft().player;
		
		if(!(player == null) && !(world == null)) {
		
		if(ticksworld == 20) {
			ticksworld = 0;
			
			if(player.getFoodStats().getFoodLevel() <= 9 && player.getActivePotionEffect(MobEffects.MINING_FATIGUE) == null) {
				
				if(!world.isRemote) {
					
					player.addPotionEffect(new PotionEffect(MobEffects.MINING_FATIGUE, 40, 0, false, false));
				}
				
				System.out.println("Effect Added");
				}
			
		} else {ticksworld++;}
		}
	}

 

 

[Seynox]

16 minutes ago, diesieben07 said:

• WorldTickEvent is entirely server side, as such in your code you are reaching across logical sides by accessing Minecraft#player. Use PlayerTickEvent instead and check that you are on the server (World#isRemote). Only the server can manipulate potion effects.
• TickEvent fires twice every tick, check TickEvent#phase.
• As mentioned above, you cannot have a global counter like that. If you just want to check every 20 ticks on the server use (World#getTotalWorldTime() % 20) == 0.

Fixed! Thanks