[1.12.2] Item Property Overrides Changes All Item Textures

[Triphion 0]

So the problem is very simple, i want the item i'm holding to change, and not the other ones of the same item in my inventory. Here is the class with the method. Any ideas?

	EntityLightningBolt lightning;
	
	private int lightning_index;
	
	public ItemZeusLightningCharged(String unlocalizedName) 
	{
		super(unlocalizedName);
		this.setCreativeTab(CreativeTabs.COMBAT);
		this.lightning_index = 0;
		
		this.addPropertyOverride(new ResourceLocation(Reference.MODID, "zeus_mode"), new IItemPropertyGetter() 
		{
			@Override
			public float apply(ItemStack stack, World worldIn, EntityLivingBase entityIn) 
			{
				Utils.getLogger().info("Itemstack: " + stack);
				if (entityIn != null && entityIn.getHeldItem(EnumHand.MAIN_HAND).getItem() == ModItems.ZEUS_LIGHTNING_CHARGED)
				{
					Utils.getLogger().info("Player has Item.");
					return (float)((ItemZeusLightningCharged)entityIn.getHeldItem(EnumHand.MAIN_HAND).getItem()).lightning_index;
				}
				else 
				{
					return 0.0F;
				}
			}
		});
	}

To clarify, the lightning index is an int that resembles the different modes. 

 

Edit: This doesn't actually work serverside either.

Edited April 24, 2019 by Triphion

[diesieben07 7415]

Items are singleton-like. There is only one instance of your item class around (in single player even shared between server and client). Things like your lightning_index (please follow Java naming conventions, by the way...) must be stored in the ItemStack, in this case probably as NBT data.

[Triphion 0]

Thank you for the advice. I have tried to make something like that. However, the problem is that the player doesn't register the active itemstack, and instead has it as simple air. And i don't really know how to fix that. 

			((ItemZeusLightningCharged)player.getHeldItemMainhand().getItem()).setLightningIndex(player.getActiveItemStack(), +1);

This is the function that i'm calling when the player presses a button to change the firing mode. After that, the lightning index is going up, and then the item property is supposed to override and give the item a new texture. 

	public static int getLightningIndex(ItemStack item) 
	{
	    NBTTagCompound nbtTagCompound = item.getTagCompound();
	    
	    if(nbtTagCompound != null)
		    return nbtTagCompound.getInteger("lIndex");
	   
	   return 0;
    }
   
    public static void setLightningIndex(ItemStack item, int lightningValue) 
    {
	    NBTTagCompound nbtTagCompound = item.getTagCompound();
	    
	    if (lightningValue < 2) 
	    {
	    }
	    else if (lightningValue == 2) 
	    {
	    	lightningValue = 0;
	    }
	    
	    nbtTagCompound.setInteger("lIndex", lightningValue);
	   
	    ItemZeusLightningCharged.lightningIndex = lightningValue;
	    
	    Utils.getLogger().info(lightningValue);
	}

This is the methods i'm using to get the index number. 

	public static int lightningIndex;

This is the int/float i'm using to check if the item should override. 

[diesieben07 7415]

Now you made your lightningIndex static. Do you know what static means? Obviously not.

Again: This must be stored in the ItemStack. Not elsewhere.

 

And why are you calling static methods with a receiver ("on an object")? Your IDE should be yelling at you for this. Again, please learn learn basic Java and understand what static means.

[Triphion 0]

I do in-fact know how static works, this was actually me being frustrated and just trying everything(which is never a good thing). Static is a declaration that has the same value for the class, including all individual objects that stem from the class has the same value. I have now removed those. I realized now aswell, but i don't know how to get that specific itemstack and then use the method since i cannot cast directly to an itemstack. This is what i have for now, and it is not valid/or working method, just starting the method. 

		if (player.getHeldItem(EnumHand.MAIN_HAND).getItem() == ModItems.ZEUS_LIGHTNING_CHARGED) 
		{
			System.out.println("Succesfully retrieved Item.");
			
			ItemStack weapon = player.getHeldItem(EnumHand.MAIN_HAND);
			((ItemZeusLightningCharged)weapon).setLightningIndex(weapon, + 1);
		}

How do i cast directly to the itemstack and not the item class as a whole? Because i can get the itemstack, but not cast it directly to the itemstack and change that specific itemstack. 

[16:42:22] [Netty Server IO #1/INFO] [STDOUT]: [com.etauricstaff.etauricmod.network.MessageGetPlayer:handleServerSide:36]: Succesfully retrieved Item.
[16:42:22] [Netty Server IO #1/INFO] [STDOUT]: [com.etauricstaff.etauricmod.network.MessageGetPlayer:handleServerSide:39]: Itemstack: 1xitem.zeus_lightning_charged@0

 

[diesieben07 7415]

I have no idea what you mean by "cast directly to the itemstack".

Again: You have to store the value in the ItemStack instance, which you already did in your last post's setLightningIndex / getLightningIndex methods (except you also stored it in a static field, which is not needed).

You now just have to use these two methods to set / retrieve the value whenever it is needed.

[Triphion 0]

EDIT: I realized that there is actually the setLightningIndex function that gets the server to crash. And this is the error i get everytime:

Quote

[19:52:05] [Netty Server IO #1/ERROR] [FML]: There was a critical exception handling a packet on channel etauric
java.lang.NullPointerException: null
    at com.etauricstaff.etauricmod.items.ItemZeusLightningCharged.setLightningIndex(ItemZeusLightningCharged.java:92) ~[ItemZeusLightningCharged.class:?]
    at com.etauricstaff.etauricmod.network.MessageGetPlayer.handleServerSide(MessageGetPlayer.java:43) ~[MessageGetPlayer.class:?]
    at com.etauricstaff.etauricmod.network.MessageBase.onMessage(MessageBase.java:17) ~[MessageBase.class:?]

And this is how my setLightningFunction looks right now:

Quote

    public void setLightningIndex(ItemStack item, int lightningValue) 
    {
        NBTTagCompound nbtTagCompound = item.getTagCompound();
        
        if (lightningValue < 2) 
        {
        }
        else if (lightningValue == 2) 
        {
            lightningValue = 0;
        }
        
        nbtTagCompound.setInteger("lIndex", lightningValue);
        
        Utils.getLogger().info(lightningValue);
    }

 

Edited April 25, 2019 by Triphion

[diesieben07 7415]

1 hour ago, Triphion said:

NBTTagCompound nbtTagCompound = item.getTagCompound();

This can be null if the ItemStack does not have an NBT tag yet. Your code does not handle that case.

[Triphion 0]

3 minutes ago, diesieben07 said:

This can be null if the ItemStack does not have an NBT tag yet. Your code does not handle that case.

I SOLVED IT! Thank you so much diesieben! ❤️

This is how i did it: 

Quote

    public void setLightningIndex(ItemStack item, int lightningValue) 
    {
        NBTTagCompound nbtTagCompound = item.getTagCompound();
        System.out.println(nbtTagCompound);
        
        if (nbtTagCompound == null) 
        {
            nbtTagCompound = new NBTTagCompound();
            item.setTagCompound(nbtTagCompound);
        }
        
        if (lightningValue < 2) 
        {
        }
        else if (lightningValue == 2) 
        {
            lightningValue = 0;
        }
        
        nbtTagCompound.setInteger("lIndex", lightningValue);
        System.out.println("Lightning Value: " + lightningValue);
    }

[Draco18s 2378]

8 hours ago, Triphion said:

System.out.println(nbtTagCompound);

1) remove this

2) use the logger the FMLPreInitializationEvent gives you

 

8 hours ago, Triphion said:

if (lightningValue < 2) 
        {
        }

Did you mean to leave this empty?

[Triphion 0]

2 hours ago, Draco18s said:

1) remove this

2) use the logger the FMLPreInitializationEvent gives you

 

Did you mean to leave this empty?

I have removed the printlns, and i usually use the logger, but for this i used the printlns because of a whim i guess? ?

And that check is actually not needed, so i removed it. I always add +1 as the lightning index, so it always goes up, then i check if it goes up to 2, and if it does, it resets the value. But thanks for pointing those out. ?

[Draco18s 2378]

7 hours ago, Triphion said:

I always add +1 as the lightning index, so it always goes up, then i check if it goes up to 2, and if it does, it resets the value. But thanks for pointing those out. 

So, it will do this:

 

0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0...

 

Yes?

 

If so, why do you need an integer? Or an if statement at all?

 

1 - currentValue will do this just fine. So will (currentValue + 1) % maximum

[Triphion 0]

14 minutes ago, Draco18s said:

So, it will do this:

 

0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0...

 

Yes?

 

If so, why do you need an integer? Or an if statement at all?

 

1 - currentValue will do this just fine. So will (currentValue + 1) % maximum

I need the integer since i have added more than just 2 modes. This is how it looks now:

    public void setLightningIndex(ItemStack item, int lightningValue) 
    {
	    NBTTagCompound nbtTagCompound = item.getTagCompound();
	    
	    if (nbtTagCompound == null) 
	    {
	    	nbtTagCompound = new NBTTagCompound();
	    	item.setTagCompound(nbtTagCompound);
	    }
	    
	    if (lightningValue == 4) 
	    {
	    	lightningValue = 0;
	    }
	    
	    nbtTagCompound.setInteger("lIndex", lightningValue);
	}

And this works just fine for this case. 

But i am very appreciative of the advice however. ^^

 

EDIT: Actually, i do not need that integer parameter, my bad, thanks for pointing that out.

Quote

    public void setLightningIndex(ItemStack item) 
    {
        NBTTagCompound nbtTagCompound = item.getTagCompound();
        
        if (nbtTagCompound == null) 
        {
            nbtTagCompound = new NBTTagCompound();
            item.setTagCompound(nbtTagCompound);
        }
        
        nbtTagCompound.setInteger("lIndex", nbtTagCompound.getInteger("lIndex") + 1);
        
        if (nbtTagCompound.getInteger("lIndex") == 4) 
        {
            nbtTagCompound.setInteger("lIndex", 0);
        }
    }

This works easier than the above mentioned, thanks Draco. ^^

Edited April 26, 2019 by Triphion

[Draco18s 2378]

I can replace this:

11 hours ago, Triphion said:

        nbtTagCompound.setInteger("lIndex", nbtTagCompound.getInteger("lIndex") + 1);
        
        if (nbtTagCompound.getInteger("lIndex") == 4) 
        {
            nbtTagCompound.setInteger("lIndex", 0);
        }

 

With this:

nbtTagCompound.setInteger("lIndex", (nbtTagCompound.getInteger("lIndex") + 1) % 4);

[Triphion 0]

7 hours ago, Draco18s said:

I can replace this:

With this:

nbtTagCompound.setInteger("lIndex", (nbtTagCompound.getInteger("lIndex") + 1) % 4);

Oh wow! Worked wonders, didn't know you could actually do it like that. Thanks for tellinig me. ?

[Draco18s 2378]

https://stackoverflow.com/q/17524673/1663383