[SOLVED 1.12.2] Server to Client Sync Problem

[PJack]

Hello guys,

 

i have a problem with my network that send Data from Server to Client.

 

This is my Event, where is sending the Packet:

	 @SubscribeEvent
	 public void onPlayerTick(PlayerTickEvent event) 
	 {
		if(event.side == Side.SERVER) 
		{
			EntityPlayer player = event.player;
			ICharacterData cd = player.getCapability(CD_CAPABILITY, null);
			
			if(cd != null)
			{
				PacketHandler.INSTANCE.sendTo(new PlayerCapabilitiesMessage(cd), (EntityPlayerMP) player);				
			}		
		}
	}

 

And this is my PlayerCapabilitiesMessage:

public class PlayerCapabilitiesMessage implements IMessage {

	@CapabilityInject(ICharacterData.class)
	public static Capability<ICharacterData> CD_CAPABILITY = null;	
	
	private static ICharacterData value;

	public PlayerCapabilitiesMessage() {}
	
	public PlayerCapabilitiesMessage(ICharacterData value) {
		this.value = value;
	}	

	@Override
	public void toBytes(ByteBuf buf) 
	{
		if(this.value != null) {
			buf.writeInt(this.value.GetReiPlayer());
			buf.writeInt(this.value.GetReiPlayerMax());
			buf.writeInt(this.value.PlayerisGhost(0));
		}
	}	
	
	@Override
	public void fromBytes(ByteBuf buf) 
	{
		if(this.value != null) {
			this.value.SetReiPlayer(buf.readInt());
			this.value.SetReiPlayerMax(buf.readInt());
			this.value.PlayerisGhost(buf.readInt());
		}
	}
	
	public ICharacterData getValue(ICharacterData value) {
		return this.value;
	}	
	
	public static class Handler implements IMessageHandler<PlayerCapabilitiesMessage, IMessage>{

		@Override
		public IMessage onMessage(PlayerCapabilitiesMessage message, MessageContext ctx) 
		{
			final ICharacterData newvalue = message.getValue(value);
			final EntityPlayerSP p = Minecraft.getMinecraft().player;
			final ICharacterData oldvalue = p.getCapability(CD_CAPABILITY, null);
			IThreadListener mainThread = Minecraft.getMinecraft();
			
			mainThread.addScheduledTask(() -> {
				
				if(oldvalue != null && newvalue != null) 
				{
					oldvalue.SetReiPlayer(newvalue.GetReiPlayer());
					oldvalue.SetReiPlayerMax((newvalue.GetReiPlayerMax()));
					oldvalue.PlayerisGhost(newvalue.PlayerisGhost(0));
				}
				
			});
			return null;
		}
		
	}
}

 

Now my problem is:

 

The Server and the Client are sync in Singleplayer, there is no problem.

 

In Mulitplayer it isnt working, because the value is null, but sometimes it works with the first Player/Client who join the Server and the second one got null.

 

Someone any idea? Thanks in advance

Edited April 26, 2019 by PJack
Got solved

[V0idWa1k3r]

6 hours ago, PJack said:

private static ICharacterData value;

You can't do this in your packet. You must reconstruct the data in your handler, you can't store it like that. 

[PJack]

4 hours ago, V0idWa1k3r said:

You can't do this in your packet. You must reconstruct the data in your handler, you can't store it like that.  

You mean, it should be like this?:
 

private int GetReiPlayer

private int GetReiPlayerMax

....

 

instead

 

private static ICharacterData value;

 

[DavidM]

1 hour ago, PJack said:

You mean, it should be like this?:
 

private int GetReiPlayer

private int GetReiPlayerMax

....

 

instead

 

private static ICharacterData value;

 

The point is the values cannot be static, and should contain the data to be send across the sides each time.

[PJack]

Okay, i removed the static.

private ICharacterData value;

 

Edit:

 

I found out that my this.value getting null in here, but i still dont know why.

	@Override
	public void fromBytes(ByteBuf buf) 
	{
		System.out.println("Check:" + this.value);
		if(this.value != null) {
			value.SetReiPlayer(buf.readInt());
			value.SetReiPlayerMax(buf.readInt());
			value.PlayerisGhost(buf.readInt());
		}
	}

 

Edited April 26, 2019 by PJack

[PJack]

I got the solution. Thanks to a post from diesieben07.

 

Instead of sending the capability, i send the raw data from it and it works now fine in Single and Multiplayer.