Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

Hello. Does exist a @SubscribeEvent  that makes the item break when has durability 0? If yes how its called? 

20 hours ago, nov4e said:

yes

Then override Item#setDamage(ItemStack, int) for your item. In your overridden method, just make sure that the stack's item damage never exceeds its max damage, and the item won't break.

  • Author
   @Override
	public void setDamage(ItemStack stack, int damage) {
		if(damage > 1) {
			stack.setItemDamage(damage);
		}
	}

 

20 minutes ago, nov4e said:

   @Override
	public void setDamage(ItemStack stack, int damage) {
		if(damage > 1) {
			stack.setItemDamage(damage);
		}
	}

 

No, you want to check that damage <= item.getMaxDamage() before you update the item's damage.  Remember that the item damage increases as it becomes more damaged.

  • Author

I changed it a little bit:

@Override
	public void setDamage(ItemStack stack, int damage) {
		if(stack == new ItemStack(this)) {
			if(damage < stack.getItem().getMaxDamage()) {
				if(damage > 1) {
					super.setDamage(stack, damage);
				}
			}
		}
	}

 

What on earth is this for? 

if(stack == new ItemStack(this))

 

And why do you keep trying to compare damage > 1 ?  What do you think that's achieving?

 

All you need to do is clamp the item's damage value between 0 (undamaged) and item.maxDamage() (fully damaged, just before breaking) inclusive.

 

By the way, you should be testing your code (and ideally running it through your IDE's debugger when it fails) rather than just inventing snippets to post here.

Edited by desht

  • Author

I tested everything and seems that removing

2 hours ago, desht said:

if(stack == new ItemStack(this))

works.

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.