[1.12.2] Itemstack information is not updated [SOLVED]

[GloriousAlpaca]

Hello,

 

I have made an item with the energy capability, a custom description showing the currently stored energy and a durability bar that also shows the stored energy.
Sadly however the information of the itemstack is only set on the creation of a new itemstack, so the durability bar just stays the same even if the energy changes.

That also applies if I put my item in something like an energetic infuser by thermal expansion: It just gives out an item with a full durability bar after a while.
This is the Code of my item:
https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/item/ItemTrap.java

Thank you for your help!

Edited May 31, 2019 by GloriousAlpaca
Solved!

[V0idWa1k3r]

Capability data isn't synced by default. You need to use the NBT share tag to sync it.

Edited May 30, 2019 by V0idWa1k3r

[Draco18s]

Also, why are these here?

https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/item/ItemTrap.java#L31-L32

 

This line is irrelevant:

https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/item/ItemTrap.java#L74

The explosion will destroy the stack.

 

Pretty sure this is not called when you think it is:

https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/item/ItemTrap.java#L84-L88

 

Why are you using NBT and a Capability?

https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/item/ItemTrap.java#L100

 

What is this method even meant to do?

https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/item/ItemTrap.java#L96

Right click ten times and then it gains the power of...exploding if it doesn't have enough energy (and otherwise consumes 100 energy, why would you ever charge this item?)

[GloriousAlpaca]

The Item is supposed to be for crafting:
You charge it in a machine after which you need to supply it with energy to keep it from exploding.

You can craft things with the void stored in it.

9 hours ago, Draco18s said:

Also, why are these here?

https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/item/ItemTrap.java#L31-L32

The capacity is useless I can see that, however the timer integer is for slowly reducing the energy stored or am I doing something wrong ?

10 hours ago, Draco18s said:

This line is irrelevant:

https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/item/ItemTrap.java#L74

The explosion will destroy the stack. 

I don't think it did when I tested it.

10 hours ago, Draco18s said:

Pretty sure this is not called when you think it is:

https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/item/ItemTrap.java#L84-L88

I thought it's called when the item is crafted, is it not ?

10 hours ago, Draco18s said:

Why are you using NBT and a Capability?

https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/item/ItemTrap.java#L100

You're right I could just save the value in the energy capability.

10 hours ago, Draco18s said:

What is this method even meant to do?

https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/item/ItemTrap.java#L96

Right click ten times and then it gains the power of...exploding if it doesn't have enough energy (and otherwise consumes 100 energy, why would you ever charge this item?) 

The onRightClick Method is only temporarily there for me to test things.

 

Thank you!

[GloriousAlpaca]

12 hours ago, V0idWa1k3r said:

Capability data isn't synced by default. You need to use the NBT share tag to sync it.

How can I use the NBT share tag (or where can I see an example of it being used)?

 

Thank you very much.

[GloriousAlpaca]

33 minutes ago, diesieben07 said:

Override Item#getNBTShareTag and Item#readNBTShareTag.

Thank you very much!

[Draco18s]

5 hours ago, GloriousAlpaca said:

The capacity is useless I can see that, however the timer integer is for slowly reducing the energy stored or am I doing something wrong ?

What happens when you have 7 of these on the server? Now it won't reduce the values every half second, but rather every 3.5 seconds.

 

Server tick 1

Stack 1: increment to 1

Stack 2: increment to 2

Stack 3: increment to 3

...

Server tick 2:

Stack 1: increment to 8

Stack 2: increment to 9

Stack 3: increment to 10 (and do thing)

Stack 4: increment to 1

Stack 5: increment to 2

...

[GloriousAlpaca]

1 minute ago, Draco18s said:

What happens when you have 7 of these on the server? Now it won't reduce the values every half second, but rather every 3.5 seconds.

 

Server tick 1

Stack 1: increment to 1

Stack 2: increment to 2

Stack 3: increment to 3

...

Server tick 2:

Stack 1: increment to 8

Stack 2: increment to 9

Stack 3: increment to 10 (and do thing) 

Stack 4: increment to 1

Stack 5: increment to 2

...

Oh, thank you! Where should I save the timer int then ?

Or rather how should I time the method ?

Edited May 31, 2019 by GloriousAlpaca

[Draco18s]

1 hour ago, GloriousAlpaca said:

Oh, thank you! Where should I save the timer int then ?

On the item stack, as part of your existing (or, if you want, a new) capability.

[GloriousAlpaca]

3 hours ago, Draco18s said:

On the item stack, as part of your existing (or, if you want, a new) capability.

I'll just make a seperate capability.

Thanks!