Jump to content

1.13.2 Registering custom triggers


salvestrom

Recommended Posts

So this is how I have it in 1.12:

Method method;
        for (int i=0; i < JungleTriggerRegistry.TRIGGER_ARRAY.length; i++)
        {
            try
            {
                method = ReflectionHelper.findMethod(CriteriaTriggers.class, "register", "func_192118_a", ICriterionTrigger.class);
                method.setAccessible(true);            

                method.invoke(null, JungleTriggerRegistry.TRIGGER_ARRAY[i]);
            }
            catch (SecurityException | IllegalAccessException | IllegalArgumentException | InvocationTargetException e)
            {
                System.out.println("Failed to register trigger " + JungleTriggerRegistry.TRIGGER_ARRAY[i].getId() + "!");
                e.printStackTrace();
            }
        }

Reflection helper doesn't exist in 1.13. The reflection class available doesn't seem to have a similar "find method" method. Is there a substitute for this? Is using reflection to do this necessary any more? The method for registering criteria is public, I noticed.

Link to comment
Share on other sites

You can use ObfuscationReflectionHelper.

An example of the findMethod method:

ObfuscationReflectionHelper.findMethod(EntityLiving.class, "func_184647_J", new Class[0]);

1st param: The class in which the findMethod method should look.

2nd param: The SRG name of the method.

3rd param: An array of the classes of the parameters of the method to be found.

 

In addition, do not use reflection to find the same method every time, as reflections are expensive. Find the method once and store it in a static field, and use the value stored in the static field after that.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

I’m pretty sure that in recent versions you only need the name and not the class or parameters.

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.