Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

[1.14.2] [Solved] Having trouble with making custom block drop when mined

Featured Replies

Posted

ISSUE SOLVED

Somewhere along the way my json file's extension was capitalized as .JSON and not .json

Minecraft apparently cares VERY MUCH about the extension case. Whoops, I'm a huge idiot.

OK so, first post. Sorry if i mess something up.
Anyways, I've been trying to get my custom block to drop the item version of itself for like a good few hours now, but nothing seems to work.
I've searched here a few times and it still doesn't seem to work right, even with other people's solutions. not sure if i did something horrendously wrong, or just missed something minor.


Here's what i have:

The block's Registry name is copper_ore.

There is both the Block and the ItemBlock for it (bsm:copper_ore, block.bsm.copper_ore) and both work perfectly fine.
Block class: ahndreklicyri/bsm/blocks/ModOreBlock.java

Spoiler

package ahndreklicyri.bsm.blocks;

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.material.Material;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.common.ToolType;

public class ModOreBlock extends Block {
    public ModOreBlock(String Name, Float Resist) {
        super(Properties.create(Material.ROCK).hardnessAndResistance(Resist));
        this.setRegistryName(Name);
    }
    @Override
    public ToolType getHarvestTool(BlockState State){
        return ToolType.PICKAXE;
    }
    @Override
    public int getHarvestLevel(BlockState State){
        return 1;
    }
    @Override
    public ResourceLocation getLootTable(){
        return super.getLootTable();
    }
}

 

ItemBlock Class: ahndreklicyri/bsm/items/ModItemBlock.java

Spoiler

package ahndreklicyri.bsm.items;

import net.minecraft.block.Block;
import net.minecraft.item.BlockItem;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;

public class ModItemBlock extends BlockItem {
    public ModItemBlock(Block block, String name) {
        super(block, new Item.Properties().group(ItemGroup.MISC));
        this.setRegistryName("bsm",name);
    }
}

 

Loot Table: /resources/data/bsm/loot_tables/blocks/copper_ore.json

Spoiler

{
  "type": "minecraft:block",
  "pools": [
    {
      "name": "bsm:copperorepool",
      "rolls": 1,
      "entries": [
        {
          "type": "minecraft:item",
          "name": "bsm:copper_ore"
        }
      ],
      "conditions": [
        {
          "condition": "minecraft:survives_explosion"
        }
      ]
    }
  ]
}

 

I setup a quick print to see what the loot table was set as and it comes up as
Block Block{bsm:copper_ore} has loot table bsm:blocks/copper_ore

 

Am i just doing something minor wrong or did i mess something major up? Any help would be appreciated. Thanks.

Edited by Ahndrek Li'Cyri

1 hour ago, SaltStation said:

Just override the getDrops method and add the item to the drops Itemstack.

blocks use loot tables now, so this is not helpful.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Author
8 hours ago, SaltStation said:

Just override the getDrops method and add the item to the drops Itemstack.

6 hours ago, Draco18s said:

blocks use loot tables now, so this is not helpful.

Yeah, and that's what i'm trying to work around. Blocks use the loot table system now instead of the getDrops system. And like i said, everything seems to be set up right, but still doesn't seem to work.

  • Author

OK so, it seems like Minecraft or forge just isn't seeing the json file at all, or is trying to read from a file that doesn't exist (in that case, my file is in the wrong place/mis-named?).
I purposely malformed the JSON loot table file i have, and no errors were thrown at all. It's like it doesn't even exist at all.
I'm now just very confused at what the issue is now.

  • Author

ISSUE SOLVED

Somewhere along the way my json file's extension was capitalized as .JSON and not .json

Minecraft apparently cares VERY MUCH about the extension case. Whoops, I'm a huge idiot.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.