Search the Forums BEFORE making a new post.

[1.14.2] Step height change not removed when removing armor piece

Posted June 28, 20196 yr

Hi All,

I'm having some trouble with an armor class. When the player remove the boots, the change in step height does not go away. Is there a different way I should be implementing this or am I missing something important?

Any guidance would help.

Thank you.

package com.kwpugh.gobber2.items.armor;

import com.kwpugh.gobber2.lists.ItemList;
import com.kwpugh.gobber2.util.SpecialAbilities;

import net.minecraft.entity.LivingEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.inventory.EquipmentSlotType;
import net.minecraft.item.ArmorItem;
import net.minecraft.item.IArmorMaterial;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Effect;
import net.minecraft.world.World;

public class ItemCustomArmor extends ArmorItem
{
	public ItemCustomArmor(IArmorMaterial materialIn, EquipmentSlotType slots, Properties builder)
	{
		super(materialIn, slots, builder);
	}
	
	
	public void onArmorTick(final ItemStack stack, final World world, final PlayerEntity player)
	{
		if(player instanceof PlayerEntity)
		{	
			ItemStack head = player.getItemStackFromSlot(EquipmentSlotType.HEAD);
			ItemStack chest = player.getItemStackFromSlot(EquipmentSlotType.CHEST);
			ItemStack legs = player.getItemStackFromSlot(EquipmentSlotType.LEGS);
		    ItemStack feet = player.getItemStackFromSlot(EquipmentSlotType.FEET);	
		 
		    //Full Set

	    	if(head != null && head.getItem() == ItemList.gobber2_helmet && 
	    			chest != null && chest.getItem() == ItemList.gobber2_chestplate && 
	    			legs != null && legs.getItem() == ItemList.gobber2_leggings && 
	    			feet != null && feet.getItem() == ItemList.gobber2_boots)
	    	{
	    		((LivingEntity) player).removePotionEffect(Effect.get(19)); //Poison
	    	}	
		    
		    //Helmet
		    if(head.getItem() == ItemList.gobber2_helmet)
			{
				int newfoodlevel = 1;
				float newsatlevel = 0.0F;
				SpecialAbilities.giveRegenffect(world, player, stack, newfoodlevel, newsatlevel);			
			}
			else
			{
				
			}
		    
		    //Chestplate
		    if(chest.getItem() == ItemList.gobber2_chestplate)
			{
		 		if(player.isInWater())
		 		{
		 			SpecialAbilities.giveBreathing(world, player, chest);
		 		}
			}
		    
		    //Leggings
		    if(legs.getItem() == ItemList.gobber2_leggings)
			{
				player.fallDistance = 0.0F;
			}
			else
			{
				player.fallDistance = 1.0F;
			}	
		    
		    //Boots
		    if(feet.getItem() == ItemList.gobber2_boots)
			{
				player.stepHeight = 2.1F;
				
				if(!player.onGround)
				{
					//player.jumpMovementFactor += 0.09F;
				}
		    }
			else
		    {
				player.stepHeight = 0.0F;
		    }		 	
		}
	}
	
	@Override
	public boolean isBookEnchantable(ItemStack stack, ItemStack book)
	{
		return true;
	}

	@Override
	public boolean getIsRepairable(ItemStack toRepair, ItemStack repair)
	{
		return repair.getItem() == ItemList.gobber2_armor_repair;
	}
}

Quote

June 28, 20196 yr

Author

ok, I should use inventroyTick to remove?

From an educational perspective, why do potion effects stop when the armor piece is removed, but no step height?

Quote

June 28, 20196 yr

30 minutes ago, kwpugh said:

if(head != null ...

ItemStacks can't be null.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

June 28, 20196 yr

Author

So, this seems to work. Is this a proper way to do it?

package com.kwpugh.gobber2.items.armor;

import com.kwpugh.gobber2.lists.ItemList;
import com.kwpugh.gobber2.util.SpecialAbilities;

import net.minecraft.entity.LivingEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.inventory.EquipmentSlotType;
import net.minecraft.item.ArmorItem;
import net.minecraft.item.IArmorMaterial;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Effects;
import net.minecraft.world.World;
import net.minecraftforge.registries.ForgeRegistries;

public class ItemCustomArmor extends ArmorItem
{
	public ItemCustomArmor(IArmorMaterial materialIn, EquipmentSlotType slots, Properties builder)
	{
		super(materialIn, slots, builder);
	}	
	
	public void onArmorTick(final ItemStack stack, final World world, final PlayerEntity player)
	{
		if(player instanceof PlayerEntity)
		{	
		    
			ItemStack head = player.getItemStackFromSlot(EquipmentSlotType.HEAD);
			ItemStack chest = player.getItemStackFromSlot(EquipmentSlotType.CHEST);
			ItemStack legs = player.getItemStackFromSlot(EquipmentSlotType.LEGS);
		    ItemStack feet = player.getItemStackFromSlot(EquipmentSlotType.FEET);
		    
		    //Full Set
	    	if(head.getItem() == ItemList.gobber2_helmet && 
	    			chest.getItem() == ItemList.gobber2_chestplate && 
	    			legs.getItem() == ItemList.gobber2_leggings && 
	    			feet.getItem() == ItemList.gobber2_boots)
	    	{
	    		((LivingEntity) ForgeRegistries.POTIONS).removePotionEffect(Effects.POISON);
	    	}	
		    
		    //Helmet
		    if(head.getItem() == ItemList.gobber2_helmet)
			{
				int newfoodlevel = 1;
				float newsatlevel = 0.0F;
				SpecialAbilities.giveRegenffect(world, player, stack, newfoodlevel, newsatlevel);			
			}
		    
		    //Chestplate
		    if(chest.getItem() == ItemList.gobber2_chestplate)
			{
		 		if(player.isInWater())
		 		{
		 			SpecialAbilities.giveBreathing(world, player, chest);
		 		}
			}
		    
		    //Leggings
		    if(legs.getItem() == ItemList.gobber2_leggings)
			{
				player.fallDistance = 0.0F;
			}	
		    
		    //Boots
		    if(feet.getItem() == ItemList.gobber2_boots)
			{
				player.stepHeight = 2.1F;
				
				if(!player.onGround)
				{
					//player.jumpMovementFactor += 0.09F;
				}
		    }		 	
		}
	}
	
	public void inventoryTick(ItemStack stack, World world, PlayerEntity player, int itemSlot, boolean isSelected)
	{			
		ItemStack head = player.getItemStackFromSlot(EquipmentSlotType.HEAD);
		ItemStack chest = player.getItemStackFromSlot(EquipmentSlotType.CHEST);
		ItemStack legs = player.getItemStackFromSlot(EquipmentSlotType.LEGS);
	    ItemStack feet = player.getItemStackFromSlot(EquipmentSlotType.FEET);
	    
		if(!(legs.getItem() == ItemList.gobber2_leggings))
		{
			player.fallDistance = 1.0F;
		}	
		
		if(!(feet.getItem() == ItemList.gobber2_boots))
		{
			player.stepHeight = 0.0F;
	    }		
	}
	
	@Override
	public boolean isBookEnchantable(ItemStack stack, ItemStack book)
	{
		return true;
	}

	@Override
	public boolean getIsRepairable(ItemStack toRepair, ItemStack repair)
	{
		return repair.getItem() == ItemList.gobber2_armor_repair;
	}
}

Quote

June 29, 20196 yr

Author

Ok, I figured it out, thank you for the pointers.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/72251-1142-step-height-change-not-removed-when-removing-armor-piece/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Failed loading villager cartographer registered at cartographer - frozen tick

Allocated 10 Gb of ram. Could try again with more but I read using too much can slow things down as well. Going to try another big modpack and see if i can replicate the problem. It seems like this cartographer problem is kind of popular and doesn't have a solid solution yet, but i suspect its some generation mod since it's a crash that happens when specific chunks are being loaded. so i'll still try to lookout for what mod it could be as i add. i'll report back after testing as you suggested for a bit

By chemba21 · 29 minutes ago29 min
Failed loading villager cartographer registered at cartographer - frozen tick

I have no idea - is enough RAM allocated?
Do other pre-configured modpacks work? Maybe use such a modpack as working base and add new mods one by one

By TileEntity · 57 minutes ago57 min
Minecraft Mod Gradle Build not working

<repository> looks like a placeholder
url "https://maven.minecraftforge.net/<repository>"

By TileEntity · 59 minutes ago59 min
Minecraft Mod Gradle Build not working

The settings.gradle file has been fixed. But, the build.gradle has an error now.
Error:
* Where:
Build file 'C:\Users\csonn\OneDrive\Desktop\fusionlucky\build.gradle' line: 3
* What went wrong:
Plugin [id: 'net.minecraftforge.gradle', version: '6.1.+'] was not found in any of the following sources:
- Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
- Included Builds (No included builds contain this plugin)
- Plugin Repositories (could not resolve plugin artifact 'net.minecraftforge.gradle:net.minecraftforge.gradle.gradle.plugin:6.1.+')
Searched in the following repositories:
Gradle Central Plugin Repository
MinecraftForge
Forge Maven
Forge Maven
Maven Repository for Minecraft Forge. <br/>You should be on:)
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Get more help at https://help.gradle.org.

Build.Gradle File:
plugins { id 'java' id 'net.minecraftforge.gradle' version '6.1.+' } group = 'io.github.csonnic03.fusionlucky' version = '1.0.0' archivesBaseName = 'fusionlucky' java { toolchain { languageVersion = JavaLanguageVersion.of(17) } } repositories { mavenCentral() maven { name "forgeMaven" url "https://maven.minecraftforge.net/<repository>" } } dependencies { minecraft 'net.minecraftforge:forge:1.20.1-47.1.0' } minecraft { mappings channel: 'official', version: '1.20.1' runs { client { workingDirectory project.file('run') } server { workingDirectory project.file('run') } } } tasks.withType(JavaCompile) { options.encoding = 'UTF-8' } jar { manifest { attributes( "Specification-Title": "Fusion Lucky Block", "Specification-Vendor": "example", "Implementation-Title": project.name, "Implementation-Version": project.version, "Implementation-Vendor": "example", "ModLauncher-TargetFMLVersion": "[47,)" ) } }

By Fairygamer03 · 2 hours ago2 hr
Failed loading villager cartographer registered at cartographer - frozen tick

no change, thank you for the patience ^^
https://mclo.gs/rgg7kUd

By chemba21 · 9 hours ago9 hr

TileEntity

Sign In

[1.14.2] Step height change not removed when removing armor piece

Featured Replies

Join the conversation

Posts

Failed loading villager cartographer registered at cartographer - frozen tick

Failed loading villager cartographer registered at cartographer - frozen tick

Minecraft Mod Gradle Build not working

Minecraft Mod Gradle Build not working

Failed loading villager cartographer registered at cartographer - frozen tick

Topics

Failed loading villager cartographer registered at cartographer - frozen tick

Minecraft Mod Gradle Build not working

[SOLVED][1.21.8 | Forge 58.0.5] How to cancel InputEvent.MouseScrollingEvent?

Mod not building

My Minecraft crashes after I try to load into a world.

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)