[1.13.2] Mix Classes derived from same Parent Class

[Simon_kungen]

Hi

 

This is more a Java problem, but because it is in a modding environment it might be better to ask here:

 

I have this ColorHandler function to do all my colour registration. Before I had it split into two functions (items and blocks) and just kept adding exceptions when I made a new item. So some automation is necessary:

 

Spoiler

public static void ColorHandler(ColorHandlerEvent event)
    {


        /**
        * Groups which are supposed to be coloured
        * */

        ItemElementGroup[] groups = {
                IntercraftItems.COPPER,
                IntercraftItems.LEAD,
                IntercraftItems.SILVER,
                IntercraftItems.TIN,
                IntercraftItems.TUNGSTEN,
                IntercraftItems.URANIUM
        };


        /**
         * Single items which are supposed to be coloured
         * */

        List<Item> items = Arrays.asList(
                IntercraftItems.COPPERCHUNK,
                IntercraftItems.TINCHUNK
        );


        List<Block> blocks = Arrays.asList(
                IntercraftBlocks.COPPERORE,
                IntercraftBlocks.TINORE
        );


        /**
         * Filter out- and placing the group's content into the @items variable
         * */

        for (ItemElementGroup group: groups) {
            Item[] i = { group.INGOT, group.NUGGET, group.DUST, group.DUST_SMALL, group.PLATE };
            for (Item item: i) {
                if ( item != null)
                    items.add(item);
            }
        }



        Type generic = event.getClass();

        if (generic == ColorHandlerEvent.Block.class) {
			// Block colouring.
        } else if (generic == ColorHandlerEvent.Item.class) {

            for (Item item : items) {

                if (item.getClass() == ItemHardChunk.class) {
                    ((ColorHandlerEvent.Item) event).getItemColors().register((ItemHardChunk)item);
                } else if (item.getClass() == ItemElement.class) {
                    ((ColorHandlerEvent.Item) event).getItemColors().register((ItemElement)item);
                }
            }


        }
    }

 

 

 

The compiler says it is fine. But Minecraft crashes with UnsupportedOperationException error; when I first try and put stuff into the items variable it throws the error. They all derive from the Item class so I thought it would be fine to do it that way, but I suppose not, or I did something wrong which is why I'm here.

 

Can Java ArrayList not be mixed with different sub-classes?

[Simon_kungen]

2 hours ago, diesieben07 said:

You are calling add on the result of Arrays.asList. That method returns a list that cannot change in size (since it is backed by an array).

Also, please don't do this. Just subscribe to ColorHandlerEvent.Item and ColorHandlerEvent.Block separately.

Note also that you cannot implement IItemColor on your item classes, this will crash on a server, since IItemColor (and IBlockColor for that matter) is a client-only class.

Ok. Got it.

Not really sure how I would solve the issue with server crashing. I have one item where I colour the top layer and I kind of need to implement IItemColor for it to work:

Spoiler

@OnlyIn(Dist.CLIENT)
public int getColor(ItemStack stack, int tint) {

    if (tint == 0)
        return 0xFFFFFF;
    else
        return this.tint;
}

 

 

 

I didn't really find a good way of doing it, and when I learned to use IItemColor I solved it that way. This is how I coloured items before, but I have no idea how to colour a certain layer in that case:

Spoiler

itemColorHandlerEvent.getItemColors().register((a,b) ->  {
	return ((ItemElement)a.getItem()).getColor();
}, IntercraftItems.COPPER);

 

 

 

[Simon_kungen]

On 7/6/2019 at 7:28 PM, diesieben07 said:

You need to implement IItemColor on a different class than your item class. It's a separate interface for a reason. Also make sure you do all this either from your client proxy or a client-only event handler (using @EventBusSubscriber).

 

I'm a bit confused about how to do this. I added this to my item class (ItemHardChunk.java\):

Spoiler

@Mod.EventBusSubscriber
public class ColorHandler implements IItemColor
{
    public int getColor(ItemStack stack, int tint) {
        if (tint == 0)
            return 0xFFFFFF;
        else
            return ItemHardChunk.this.tint;
    }
}

 

 

 

I'm just guessing and not sure how to do this. It does compile but how to register it to EVENT_BUS I have no idea.

Edited July 14, 2019 by Simon_kungen
Made a Emoji for some reason.

[Simon_kungen]

Alright, got this:

@OnlyIn(Dist.CLIENT)
@SubscribeEvent
public static void ItemColorHandlerEvent(ColorHandlerEvent.Item event) {

    Item[] items = {
            IntercraftItems.COPPERCHUNK,
            IntercraftItems.TINCHUNK
    };

  // Register the appropriate colour to the item from the ColorHandler class in the item class.
    
}

 

How would I go about registering the ColorHandler in my item class? This is mainly what I've been stuck on, the help you just gave me cleaned up the code somewhat which I like.