Diferentiating items on the Player's Inventory [SOLVED]

[Doctor Moonbad]

Hi there, I'm Moonbad.

 

I've recently started developing a mod, called "Grazodia" for Minecraft 1.12.2, and I found something to be really strange.

I want an item to detect a another certain item inside the player's inventory by comparing names with the methods getUnlocalizedName or getDisplayName, but none of them seem to work.

Here's a code I made for detecting Dirt Blocks:

@Override
	public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected) 
	{	
		this.clock++;
		if(this.clock >= 40) 
		{
			this.clock = 0;
			
			EntityPlayer player = (EntityPlayer)entityIn;
			InventoryPlayer inventory = player.inventory;
			for (int i = 0; i < 27; i++) 
			{
				ItemStack item = inventory.mainInventory.get(i);
				String itemName = item.getUnlocalizedName();
				if (itemName == "tile.dirt.default") 
				{
					System.out.println("I:[ " + i + " ] [ " + itemName + " ]");
				}
			}
		}

 

Can someone help me, please? I'm really confused because when I remove the if statement, all Dirt Blocks' names in my inventory are displayed correctly, exactly as "tile.dirt.default".

Edited July 22, 2019 by Doctor Moonbad

[DaemonUmbra]

Why are you trying to compare using translation keys rather than comparing the items directly?

[Doctor Moonbad]

I did not know that it was possible. Thank you for your lightning-speed answer. How can I do that?

EDIT: I'm trying right now with new ItemStack(Blocks.Dirt);

Edited July 22, 2019 by Doctor Moonbad

[DaemonUmbra]

Item classes are singletons, i.e. all stacks of an item reference the same Item instance, so if you can get the Item instance of your itemstack and compare it to the desired item instance stored in vanilla's Items class...

[Doctor Moonbad]

2 minutes ago, DaemonUmbra said:

Item classes are singletons, i.e. all stacks of an item reference the same Item instance, so if you can get the Item instance of your itemstack and compare it to the desired item instance stored in vanilla's Items class...

Yeah, I thought about that, but there is no Items.Dirt or something like that.

[DaemonUmbra]

Check the Blocks class for dirt block and there should be a method to get the Item representing that block.

[Doctor Moonbad]

Just now, DaemonUmbra said:

Check the Blocks class for dirt block and there should be a method to get the Item representing that block.

Alright, I'll try

itemstack.getItem() == Item.getItemFromBlock(Blocks.DIRT)

 

[Doctor Moonbad]

1 minute ago, Doctor Moonbad said:

Alright, I'll try

itemstack.getItem() == Item.getItemFromBlock(Blocks.DIRT)

 

It worked! Thank you DaemonUmbra!

[DavidM]

Please note that items and blocks are singleton. Your method of adding timer won't work as the same timer will be used on all players and all instances of ItemStack with your Item.