1.13.2 Alternative to PotionBrewing.addmix ? [SOLVED]

[sunsigne]

Hello,

 

Does anyone find how to implement a brewing reciepe in 1.13.2 yet ? It doesn't seem to be in datapack, the fonction "addmix" in PotionBrewing class is now private, and IForgeRegistry doesn't work for this class (as it's neither Potion class, neither PotionType class)

 

Thank

[The_Wabbit]

This was registered as an issue. Probably pretty low on the devs priority list for 1.14 just yet though. https://github.com/MinecraftForge/MinecraftForge/issues/5814

[sunsigne]

ok ty  i'll probably try to see if i can rewitre entirely the brewing_stand by now ^^ it's a lot of work for a tiny potion, but as long as it works as final ...

[DavidM]

  On 7/25/2019 at 7:17 AM, sunsigne said:

ok ty  i'll probably try to see if i can rewitre entirely the brewing_stand by now ^^ it's a lot of work for a tiny potion, but as long as it works as final ...

Expand  

Even if there is no way of adding a brewing recipe, there is reflection.

It would be better than copying & pasting an entire vanilla class and screwing all mods with custom brewing stands...

Edited July 26, 2019 by DavidM

[sunsigne]

Perfect ! I finally found out how to register potion recipes ! (thank to reflection)

 

for curious people, here is the solution :

  Reveal hidden contents

In MAIN class :

 

public YourMainClass () {

FMLJavaModLoadingContext.get().getModEventBus().addListener(this::RegisterPlus);

}

 

private void RegisterPlus(final FMLCommonSetupEvent event)
        {
             
         try { RegisterPlus.addMix(PotionTypes.AWKWARD, Items.REDSTONE, ModPotionType.your_potion);
            } catch (Exception e) {    e.printStackTrace();}
       
        }

 

 

In a classe you called RegisterPlus :

 

public class RegisterPlus {

    
    public static void addMix(PotionType p_193357_0_, Item p_193357_1_, PotionType p_193357_2_) throws Exception {
        
        Method method = PotionBrewing.class.getDeclaredMethod("addMix", PotionType.class, Item.class, PotionType.class);
        method.setAccessible(true);
        method.invoke(null, p_193357_0_, p_193357_1_, p_193357_2_);
        }

}

Hope it will help someone ^^

[The_Wabbit]

If you only need to use addMix there is also a non-reflection alternative that uses a brewing recipe via BrewingRecipeRegistry.addRecipe(...). Note there is a bug (1.14.3) in the Forge default BrewingRecipe so you should roll your own fixing the following in the isInput method like:

public class ModBrewingRecipe extends BrewingRecipe {
  public ModBrewingRecipe(ItemStack input, Ingredient ingredient, ItemStack output) {
    super(input,ingredient,output);
  }
  @Override
  public boolean isInput(ItemStack stack) {
    return ItemStack.areItemsEqual(super.getInput(),stack); //THIS IS BROKEN in super 1.14.3
  }
}

Pass in filled in potion itemstacks (see PotionUtils.addPotionToItemStack) for the input and outputs (eg Awkward potion -> Your potion)

[DavidM]

  On 7/30/2019 at 3:38 PM, sunsigne said:

public static void addMix(PotionType p_193357_0_, Item p_193357_1_, PotionType p_193357_2_) throws Exception {
        
        Method method = PotionBrewing.class.getDeclaredMethod("addMix", PotionType.class, Item.class, PotionType.class);
        method.setAccessible(true);
        method.invoke(null, p_193357_0_, p_193357_1_, p_193357_2_);
        }

Expand  

Reflection is expensive. Use it once and store the method in a static field.