[Solved][1.14.4] Adding Potion Effects to Armor Sets

[Sauuuuucey]

Hello all,

 

I'm looking to create a method that checks if armor items from a particular set are all equipped before granting some sort of potion effect so long as they're all worn, like a set bonus. I adapted a method from some older source code, but I'm not getting the desired outcome. Any suggestions?

 

Here's an example for reference:

Spoiler

public class SilverArmor extends ArmorItem 
{
	private final EffectInstance potionEffect;

	public SilverArmor(IArmorMaterial materialIn, EquipmentSlotType slot, final EffectInstance potionEffect ,Properties builder) {
		super(materialIn, slot, builder);
		this.potionEffect = potionEffect;
	}

Builder/Properties

Spoiler

    public void onArmorTick(World world, PlayerEntity player, ItemStack item) {
		if(player.inventory.armorItemInSlot(0) 
				!= null && player.inventory.armorItemInSlot(1) 
				!= null && player.inventory.armorItemInSlot(2) 
				!= null && player.inventory.armorItemInSlot(3) 
				!= null) 
		{
			if(player.inventory.armorItemInSlot(0).getItem() == ModItems.silver_chestplate && player.inventory.armorItemInSlot(1).getItem() == ModItems.silver_leggings && player.inventory.armorItemInSlot(2).getItem() == ModItems.silver_boots && player.inventory.armorItemInSlot(3).getItem() == ModItems.silver_helmet) {				
				player.addPotionEffect(new EffectInstance(potionEffect));
			}
		}
	}

Method that checks if all pieces are being worn

Spoiler

	@SubscribeEvent
	public static void onRegisterItems(final RegistryEvent.Register<Item> event) {
		final IForgeRegistry<Item> registry = event.getRegistry();
		
		registry.registerAll
		(
				new SilverArmor(ModArmorMaterials.silver, EquipmentSlotType.HEAD, new EffectInstance(Effects.INVISIBILITY), new Item.Properties().group(ModGroup.MOD_ITEM_GROUP)).setRegistryName("silver_helmet"),
				new SilverArmor(ModArmorMaterials.silver, EquipmentSlotType.CHEST, new EffectInstance(Effects.INVISIBILITY), new Item.Properties().group(ModGroup.MOD_ITEM_GROUP)).setRegistryName("silver_chestplate"),
				new SilverArmor(ModArmorMaterials.silver, EquipmentSlotType.LEGS, new EffectInstance(Effects.INVISIBILITY), new Item.Properties().group(ModGroup.MOD_ITEM_GROUP)).setRegistryName("silver_leggings"),
				new SilverArmor(ModArmorMaterials.silver, EquipmentSlotType.FEET, new EffectInstance(Effects.INVISIBILITY), new Item.Properties().group(ModGroup.MOD_ITEM_GROUP)).setRegistryName("silver_boots")
				
		);
	}

Registry with placeholder effect

 

[Sauuuuucey]

Figured it out after a bit of testing/digging through some references. Here's the updated method example in case anyone was wondering:

Spoiler

    @Override
    public void onArmorTick(ItemStack stack, World world, PlayerEntity player) {
		if(player.getItemStackFromSlot(EquipmentSlotType.HEAD).getItem() == ModItems.silver_helmet && 
			player.getItemStackFromSlot(EquipmentSlotType.CHEST).getItem() == ModItems.silver_chestplate && 
			player.getItemStackFromSlot(EquipmentSlotType.LEGS).getItem() == ModItems.silver_leggings && 
			player.getItemStackFromSlot(EquipmentSlotType.FEET).getItem() == ModItems.silver_boots) 
		{				
				player.addPotionEffect(new EffectInstance(Effects.INVISIBILITY));
		}
	}

 

 

[Barlords]

Bonjour,

 

L'effet se retire et se remet à chaque tick

Serait t-il possible de donné une durée de plusieurs secondes afin de résoudre ce problème?

Edited January 13, 2020 by Barlords

[TheSarlaacSweep]

I think you could also get away with leaving it more generic like this example:

 

    @Override
    public void onArmorTick(ItemStack stack, World world, PlayerEntity player) {
      if(
        !player.getItemStackFromSlot(EquipmentSlotType.HEAD).isEmpty() &&
        !player.getItemStackFromSlot(EquipmentSlotType.CHEST).isEmpty() &&
        !player.getItemStackFromSlot(EquipmentSlotType.LEGS).isEmpty() &&
        !player.getItemStackFromSlot(EquipmentSlotType.FEET).isEmpty()
      )
      {
        player.addPotionEffect(new EffectInstance(Effects.INVISIBILITY));
      }
    }

This way if you create more armors you don't have to write new conditions to check more items. Although, yours is better if you want to guarantee that all armor pieces match the suit in their slots.

Edited June 4, 2020 by TheSarlaacSweep
It's more of a variation rather than an improvement.

[DavidM]

15 hours ago, TheSarlaacSweep said:

I think you could also get away with leaving it more generic like this example:

 

    @Override
    public void onArmorTick(ItemStack stack, World world, PlayerEntity player) {
      if(
        !player.getItemStackFromSlot(EquipmentSlotType.HEAD).isEmpty() &&
        !player.getItemStackFromSlot(EquipmentSlotType.CHEST).isEmpty() &&
        !player.getItemStackFromSlot(EquipmentSlotType.LEGS).isEmpty() &&
        !player.getItemStackFromSlot(EquipmentSlotType.FEET).isEmpty()
      )
      {
        player.addPotionEffect(new EffectInstance(Effects.INVISIBILITY));
      }
    }

This way if you create more armors you don't have to write new conditions to check more items. Although, yours is better if you want to guarantee that all armor pieces match the suit in their slots.

Slots not being empty != the player is wearing the specified armor piece.