Scheduling a random event

[Briggybros]

I'm trying to create a random event in a ticker. The code is as so:

package mods.XXXXXX;

import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;
import java.util.ArrayList;
import java.util.EnumSet;
import java.util.List;
import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.client.Minecraft;
import net.minecraft.src.ModLoader;
import net.minecraft.util.MathHelper;
import net.minecraft.world.World;
import net.minecraft.world.WorldServer;
import net.minecraft.world.WorldType;
import net.minecraft.world.biome.BiomeGenBase;
import net.minecraft.world.gen.MapGenRavine;
import cpw.mods.fml.common.ITickHandler;
import cpw.mods.fml.common.TickType;
import cpw.mods.fml.common.network.PacketDispatcher;

public class TickHandler implements ITickHandler
{	
    @Override
    public void tickStart(EnumSet<TickType> type, Object... tickData) {}

    @Override
    public void tickEnd(EnumSet<TickType> type, Object... tickData)
    {
        if (type.equals(EnumSet.of(TickType.WORLD)))
        {
        	onWorldTick(new Random());
        }
    }

    @Override
    public EnumSet<TickType> ticks()
    {
        return EnumSet.of(TickType.WORLD);
    }

    @Override
    public String getLabel()
    {
    	return "TickHandler";
    }


    public void onWorldTick(Random rand)
    {
    	int probability = rand.nextInt(40);
    	if (probability == 0) {
    		
            World world = null;
        	
        	for(int i = 0; i < ModLoader.getMinecraftServerInstance().worldServers.length; i ++) {
        		World w = ModLoader.getMinecraftServerInstance().worldServers[i];
        		if (w.getBiomeGenForCoords(0, 0) != BiomeGenBase.hell && w.getBiomeGenForCoords(0, 0) != BiomeGenBase.sky) {
        			world = w;
        		}
        	}
        	
        	
        	int x = world.getSpawnPoint().posX + (rand.nextInt(1000) - 500);
    		int z = world.getSpawnPoint().posZ + (rand.nextInt(1000) - 500);
    		int totalY = world.getHeightValue(x, z);
    		int y = totalY - rand.nextInt(totalY - 5);
    		
    		doStuff(world,x,y,z,rand);
    	}
    }
    
    public static void doStuff(World world, int x, int y, int z, Random rand) {
    	//Do stuff *it's a secret!*
    }
}

The doStuff() method works as I've also got a method to trigger it by command and it works fine, however, when it's run through the ticker it doesn't work, it's supposed to happen on average every 2 seconds but nothing is happening over a period of 5 minutes. What is wrong with the ticker so that the doStuff() method is not run?

[Alex_hawks]

try using the following Psuedocode

@Override
    public void tickEnd(EnumSet<TickType> type, Object... tickData)
    {
        if (type.contains(TickType.WORLD))
        {
         onWorldTick(new Random());
        }
    }

[Briggybros]

It still doesn't work with the new code, and I've created a class wide random.

[SanAndreaP]

1. Don't use the ModLoader class. It's bad when using Forge. Look into that class, since the ModLoader class is only a compatibility layer, there are the right Forge methods you should use.

2. Where do you register your TickHandler?

[Briggybros]

The code now works, how can I make it forge dependant rather than ModLoader dependant? also, how can I improve the random location picker to choose a random location anywhere in the generated world? it is, at the moment, like this;

        	int x = world.getSpawnPoint().posX + (rand.nextInt(1000) - 500);
    		int z = world.getSpawnPoint().posZ + (rand.nextInt(1000) - 500);
    		int totalY = world.getHeightValue(x, z);
    		int y = totalY - rand.nextInt(totalY - 5);

[Briggybros]

Nobody?