Potion Icon Bug [1.12.2] [Resolved]

[theishiopian]

I'm attempting to make a custom potion effect, and I'm very close! But theres one last issue that I can't seem to fix. The potion effect's icon has a speed icon behind it. I know very little about rendering, so any help getting rid of this bug would be appreciated, as well as an explanation as to why it happens.

 

My rendering code, in the potion effect class:

		@Override
		@SideOnly(Side.CLIENT)
		public void renderHUDEffect(int x, int y, PotionEffect effect, Minecraft mc, float alpha)
		{
			mc.getTextureManager().bindTexture(icon);
			
			Gui.drawModalRectWithCustomSizedTexture(x + 3, y + 3, 0, 0, 18, 18, 18, 18);
		}

		@Override
		@SideOnly(Side.CLIENT)
		public void renderInventoryEffect(int x, int y, PotionEffect effect, Minecraft mc)
		{
			mc.getTextureManager().bindTexture(icon);
			Gui.drawModalRectWithCustomSizedTexture(x + 6, y + 7, 0, 0, 18, 18, 18, 18);
		}

 

A picture of the glitch, notice the second HUD icon:

 

 

The glitch happens regardless of other active effects, the speed icon on top was just me testing.

Edited August 2, 2019 by theishiopian
resolved

[Animefan8888]

11 minutes ago, theishiopian said:

My rendering code, in the potion effect class:

Post all of your code. What is the icon field? Where do you initialize it?

[theishiopian]

Its a ResourceLocation that points to a 16*16 png in my assets

 

Here's the whole class for context:

 

public static class ImmortalityEffect extends Potion
{

  protected ImmortalityEffect() 
  {
    super(false, 8331833);
    this.setPotionName("effect.immortality");
    this.setIconIndex(0, 0);
    this.setRegistryName(Immortality.MODID + ":" + "immortality");
  }

  ResourceLocation icon = new ResourceLocation(Immortality.MODID +":textures/gui/icon.png");

  @Override
    @SideOnly(Side.CLIENT)
    public void renderHUDEffect(int x, int y, PotionEffect effect, Minecraft mc, float alpha)
  {
    mc.getTextureManager().bindTexture(icon);

    Gui.drawModalRectWithCustomSizedTexture(x + 3, y + 3, 0, 0, 18, 18, 18, 18);
  }

  @Override
    @SideOnly(Side.CLIENT)
    public void renderInventoryEffect(int x, int y, PotionEffect effect, Minecraft mc)
  {
    mc.getTextureManager().bindTexture(icon);
    Gui.drawModalRectWithCustomSizedTexture(x + 6, y + 7, 0, 0, 18, 18, 18, 18);
  }
}

 

[theishiopian]

I figured it out, a night's sleep really helps with coding apaprently. The setIconIndex is the culprit, removing it fixed it. Now I know what that does!