Jump to content

[SOLVED][1.12.2] Ore Dictionnary problem with Wildcard value


Recommended Posts

Posted (edited)

Hello,

 

My Forge version : Forge 14.23.5.2768

 

First, my crafting JSON file is here

 

Spoiler

{

  "type": "minecraft:crafting_shapeless",
  "ingredients": [

    {

      "type": "forge:ore_dict",
      "ore": "ufPlatesHammer"

    },
    {

      "type": "forge:ore_dict",
      "ore": "cobblestone"

    }

  ],
  "result": {

    "item": "ultimatefurnaces:lithium_block"

  }

}

 

My item class is here : (I have this hammer, and three other similar classes for Iron hammer, diamond and emerald.)

 

Spoiler

public class Hammer extends Item {

    public Hammer(){

        setRegistryName("plates_hammer");
        setUnlocalizedName("plates_hammer");
        setMaxStackSize(1);
        setMaxDamage(40);
        setNoRepair();
        setCreativeTab(Super.instance.creativeTab);

    }

    @Override
    public ItemStack getContainerItem(ItemStack itemstack) {

        ItemStack item = itemstack.copy();
        item.setItemDamage(item.getItemDamage() + 1);
        return item;

    }

    @Override
    public boolean hasContainerItem(ItemStack stack) {

        return stack.getItemDamage()<39;

    }

    @Override
    public boolean isBookEnchantable(ItemStack stack, ItemStack book){

        return false;

    }

    @Override
    public boolean isEnchantable(ItemStack stack) {

        return false;

    }

}

 

 

And i register my ore dict like this :

 

Spoiler

OreDictionary.registerOre("ufPlatesHammer", new ItemStack(ModItems.INSTANCE.hammer, 1, OreDictionary.WILDCARD_VALUE));
OreDictionary.registerOre("ufPlatesHammer", new ItemStack(ModItems.INSTANCE.ironhammer, 1, OreDictionary.WILDCARD_VALUE));
OreDictionary.registerOre("ufPlatesHammer", new ItemStack(ModItems.INSTANCE.diamondhammer, 1, OreDictionary.WILDCARD_VALUE));
OreDictionary.registerOre("ufPlatesHammer", new ItemStack(ModItems.INSTANCE.emeraldhammer, 1, OreDictionary.WILDCARD_VALUE));

 

 

So, my problem is that i can craft one times the lithium block, then, when the hammer is damaged, I can't craft the block once again. I don't know if adding WILDCARD_VALUE when registering Ore is doing something. I tried to put "data": 32767 in json file but doesn't work.

Thanks for helping me.

 

Bye.

 

 

Edited by Zeide
Posted
12 hours ago, Zeide said:

but doesn't work.

Define "doesn't work"

 

12 hours ago, Zeide said:

    @Override
    public ItemStack getContainerItem(ItemStack itemstack) {

        ItemStack item = itemstack.copy();
        item.setItemDamage(item.getItemDamage() + 1);
        return item;

    }

You should use damageItem so that Unbreakable enchantments work.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • You can check mod compatibility remove new mods and test them one by one.
    • @Tsuk1 Also, new note, you can use blockbench to make the custom item model for when it is not on the head.   EDIT: Funny story, I am making a mod similar to yours! Mine is called NorseMC.
    • @Nood_dev Could you send a screenshot of your weapon code? Here is the one I made (for a dagger): The specific UUID does not matter, just that it is the same every time, which is why UUID#randomUUID does not work public class DaggerItem extends TieredItem implements Vanishable { protected static final double REACH_MODIFIER = -1.5D; protected final Multimap<Attribute, AttributeModifier> defaultModifiers; protected final UUID BASE_ATTACK_REACH_UUID = UUID.fromString("6fe75b5c-9d1b-4e83-9eea-a1d5a94e8dd5") public DaggerItem(Tier pTier, int pAttackDamageModifier, float pAttackSpeedModifier, Properties pProperties) { super(pTier, pAttackDamageModifier, pAttackSpeedModifier, pProperties); this.attackDamage = (float) pAttackDamageModifier + pTier.getAttackDamageBonus(); ImmutableMultimap.Builder<Attribute, AttributeModifier> builder = ImmutableMultimap.builder(); builder.put(Attributes.ATTACK_DAMAGE, new AttributeModifier(BASE_ATTACK_DAMAGE_UUID, "Weapon modifier", this.attackDamage, AttributeModifier.Operation.ADDITION)); builder.put(Attributes.ATTACK_SPEED, new AttributeModifier(BASE_ATTACK_SPEED_UUID, "Weapon modifier", pAttackSpeedModifier, AttributeModifier.Operation.ADDITION)); // THE ONE YOU WANT: builder.put(ForgeMod.ENTITY_REACH.get(), new AttributeModifier(BASE_ATTACK_REACH_UUID, "Weapon modifier", REACH_MODIFIER, AttributeModifier.Operation.ADDITION)); this.defaultModifiers = builder.build(); } @Override public Multimap<Attribute, AttributeModifier> getDefaultAttributeModifiers(EquipmentSlot pEquipmentSlot) { return pEquipmentSlot == EquipmentSlot.MAINHAND ? this.defaultModifiers : super.getDefaultAttributeModifiers(pEquipmentSlot); } }
    • https://images.app.goo.gl/1PxFKdxByTgkxvSu6
    • That's what we'll try out. I could never figure out how to recreate the crash, so I'll just have to wait and see.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.