Jump to content

[1.14.x] What does the ordering in mods.toml actually do?


Recommended Posts

I'm trying to understand all the bits that you can declare in your mods.toml file and can't seem to get the ordering option for a dependency to have any meaning.


I have a mod "B" that depends on mod "A" so I assumed (uh-oh) that if I put "A" as a required dependency for "B" that it would be loaded after; I made the BMod.Amod 'ordering' field equal 'AFTER' as shown below. However, after some testing it seems that things get loaded in any which way as "B" would be created before "A" (I put a hard dependency in B's constructor to use an object created in A's constructor as a test; also logging).  I see no reference to the IModInfo.getOrdering method in the Forge code either. I have tried changing the order in the dependency (BMod.AMod)  to 'BEFORE' and that didn't seem to have any effect.


Has anyone tried using dependencies/ordering=AFTER (like for libraries or mod extensions where you really need the first mod created first)?


# Find more information on toml format here:  https://github.com/toml-lang/toml
loaderVersion="[25,)" #(25 is current forge version)
credits="Forge, Donald Trump's Hair"
# Mod List (usually just the one)
    displayName="Bestest Mod Ever"
    # Mod description (multi line!)
Something witty said here

# Dependency: BMod.Forge
# Dependency: BMod.Minecraft
# Dependency: BMod.AMod


Link to comment
Share on other sites

I...haven't actually verified that my things are loading in the order I set, but 


Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.


Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.


DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

My mods.toml looks similar to yours. Best I can tell from the Forge debug logging: the initial construction of mods is done in parallel, independent of that particular mods.toml setting. For example some real IDE outputs (extendedfoodpantry wants to be loaded AFTER vanillafoodpantry per its mods.toml file).

[09Aug2019 08:48:11.748] [Client thread/DEBUG] [net.minecraftforge.fml.ModList/LOADING]: Dispatching parallel event LifecycleEvent:CONSTRUCT
[09Aug2019 08:48:11.752] [Client thread/TRACE] [net.minecraftforge.fml.loading.ModJarURLHandler/CORE]: Loading modjar...SNIPPED
[09Aug2019 08:48:12.047] [modloading-worker-3/DEBUG] [net.minecraftforge.fml.javafmlmod.FMLModContainer/LOADING]: Loading mod instance extendedfoodpantry of type...SNIPPED
[09Aug2019 08:48:12.049] [modloading-worker-3/TRACE] [net.minecraftforge.fml.loading.ModJarURLHandler/CORE]: Loading modjar...SNIPPED
[09Aug2019 08:48:12.074] [modloading-worker-1/DEBUG] [net.minecraftforge.fml.javafmlmod.FMLModContainer/LOADING]: Loading mod instance vanillafoodpantry of type...SNIPPED
[09Aug2019 08:48:12.077] [modloading-worker-1/TRACE] [net.minecraftforge.fml.loading.ModJarURLHandler/CORE]: Loading modjar...SNIPPED
[09Aug2019 08:48:12.080] [modloading-worker-2/DEBUG] [net.minecraftforge.fml.javafmlmod.FMLModContainer/LOADING]: Loading mod instance upsizer of type...SNIPPED
[09Aug2019 08:48:12.080] [modloading-worker-2/TRACE] [net.minecraftforge.fml.loading.ModJarURLHandler/CORE]: Loading modjar...SNIPPED

Notice the separate modloading-worker-xxx threads. The mods.toml ordering may only apply to event notification ordering after the mod's instance has been constructed (the ordering of which is undefined). The lesson here might be to put any ordering-dependent referential code into an event callback, not your constructor. Will close this thread once I've tried that...

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Create New...

Important Information

By using this site, you agree to our Terms of Use.